Skip to content
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@

## Prerequisites

- macOS 14+
- Xcode 15+
- macOS 26+

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 macOS minimum is overstated

The project still targets macOS 14 and its compatibility workflow exercises macOS 14, 15, and 26, so documenting macOS 26+ as a prerequisite incorrectly directs contributors with supported macOS 14 or 15 environments to upgrade.

Context Used: CLAUDE.md (source)

- Xcode 26+ (see `.xcode-version` for the exact pinned version)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Document the supported Xcode version precisely

The repository pins Xcode to 26.0, and scripts/check-pbxproj.sh currently rejects any major version other than 26. Writing Xcode 26+ implies newer majors are supported when they are not validated.

Suggested fix
-- Xcode 26+ (see `.xcode-version` for the exact pinned version)
+- Xcode 26.0 (see `.xcode-version` for the exact pinned version)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- macOS 26+
- Xcode 26+ (see `.xcode-version` for the exact pinned version)
- macOS 26+
- Xcode 26.0 (see `.xcode-version` for the exact pinned version)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@CONTRIBUTING.md` around lines 5 - 6, Update the Xcode requirement in
CONTRIBUTING.md to state the precisely supported pinned version, Xcode 26.0,
instead of implying that all newer major versions are supported. Keep the
existing macOS requirement unchanged.

- [Zig](https://ziglang.org/) (install via `brew install zig`)
- [Rust](https://rustup.rs/)

## Getting Started

Expand Down