Repository navigation
Conversation
setup.sh requires Xcode 26 (per .xcode-version) and Rust, but the doc still listed Xcode 15+ / macOS 14+ and omitted Rust entirely.
📝 WalkthroughWalkthroughChangesDeveloper prerequisites
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 25✅ Passed checks (25 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Greptile SummaryUpdates contributor prerequisites to match the development toolchain:
Confidence Score: 5/5The documentation-only change appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "docs: correct macOS/Xcode version number..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| - macOS 14+ | ||
| - Xcode 15+ | ||
| - macOS 26+ |
Contributor
There was a problem hiding this comment.
The project still targets macOS 14 and its compatibility workflow exercises macOS 14, 15, and 26, so documenting macOS 26+ as a prerequisite incorrectly directs contributors with supported macOS 14 or 15 environments to upgrade.
Context Used: CLAUDE.md (source)
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CONTRIBUTING.md`:
- Around line 5-6: Update the Xcode requirement in CONTRIBUTING.md to state the
precisely supported pinned version, Xcode 26.0, instead of implying that all
newer major versions are supported. Keep the existing macOS requirement
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 429e066a-daa5-4fbb-bf28-0de56bb48b2c
📒 Files selected for processing (1)
CONTRIBUTING.md
Comment on lines
+5
to
+6
| - macOS 26+ | ||
| - Xcode 26+ (see `.xcode-version` for the exact pinned version) |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Document the supported Xcode version precisely
The repository pins Xcode to 26.0, and scripts/check-pbxproj.sh currently rejects any major version other than 26. Writing Xcode 26+ implies newer majors are supported when they are not validated.
Suggested fix
-- Xcode 26+ (see `.xcode-version` for the exact pinned version)
+- Xcode 26.0 (see `.xcode-version` for the exact pinned version)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| - macOS 26+ | |
| - Xcode 26+ (see `.xcode-version` for the exact pinned version) | |
| - macOS 26+ | |
| - Xcode 26.0 (see `.xcode-version` for the exact pinned version) |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CONTRIBUTING.md` around lines 5 - 6, Update the Xcode requirement in
CONTRIBUTING.md to state the precisely supported pinned version, Xcode 26.0,
instead of implying that all newer major versions are supported. Keep the
existing macOS requirement unchanged.
Xcode 26.0 requires macOS 15.6+, not macOS 26 — the App Store gate that suggested macOS 26.2 was for a later Xcode point release, not the 26.0 version this repo pins. Also state the Xcode requirement as the exact pinned 26.0 rather than an open-ended "26+".
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Update CONTRIBUTING prerequisites to match the current toolchain. Replace macOS 14+/Xcode 15+ with macOS 15.6+ and Xcode 26.0 (pinned in
.xcode-versionand enforced byscripts/check-pbxproj.sh), and add Rust to avoid setup errors.Written for commit 5974cbd. Summary will update on new commits.
Summary by CodeRabbit