Skip to content

Stabilize concurrent Bun runner assertions #8947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lawrencecchen wants to merge 1 commit into from
Closed

Stabilize concurrent Bun runner assertions #8947

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions web/tests/web-test-runner-isolation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ test("shared web test runner isolates module mocks across files", () => {
expect(result.output).toContain("0 fail");
});

test("shared web test runner preserves sorted recursive discovery", () => {
test("shared web test runner preserves recursive discovery", () => {
const fixtureRoot = createRunnerFixture();
try {
mkdirSync(join(fixtureRoot, ".hidden"));
Expand Down Expand Up @@ -98,7 +98,7 @@ test("shared web test runner preserves sorted recursive discovery", () => {
"tests/nested/gamma_test.tsx:",
"tests/nested/omega.spec.mjs:",
];
expectHeadingsInOrder(result.output, expectedHeadings);
expectHeadings(result.output, expectedHeadings);
expect(result.output).not.toContain("ignored.test.ts:");

const optionedResult = runChild(
Expand All @@ -111,7 +111,7 @@ test("shared web test runner preserves sorted recursive discovery", () => {
`option-only web test run lost discovery:\n${optionedResult.output}`,
);
}
expectHeadingsInOrder(optionedResult.output, expectedHeadings);
expectHeadings(optionedResult.output, expectedHeadings);
expect(optionedResult.output).not.toContain("ignored.test.ts:");

const scopedResult = runChild(
Expand Down Expand Up @@ -142,7 +142,7 @@ test("shared web test runner preserves sorted recursive discovery", () => {
`default Bun test root was not preserved:\n${rootedResult.output}`,
);
}
expectHeadingsInOrder(rootedResult.output, [
expectHeadings(rootedResult.output, [
"tests/beta.test.ts:",
"tests/nested/gamma_test.tsx:",
"tests/nested/omega.spec.mjs:",
Expand All @@ -164,7 +164,7 @@ test("shared web test runner preserves sorted recursive discovery", () => {
`alternate Bun test root was not preserved:\n${configuredResult.output}`,
);
}
expectHeadingsInOrder(configuredResult.output, [
expectHeadings(configuredResult.output, [
"tests/beta.test.ts:",
"tests/nested/gamma_test.tsx:",
"tests/nested/omega.spec.mjs:",
Expand Down Expand Up @@ -240,11 +240,11 @@ function runChild(
return { status: result.status, output };
}

function expectHeadingsInOrder(output: string, headings: string[]): void {
let previousIndex = -1;
function expectHeadings(output: string, headings: string[]): void {
// Bun can execute files concurrently and report their headings in completion
// order. The shell guard asserts the runner passes files to Bun in sorted
// order; this integration test asserts every discovered file actually runs.
for (const heading of headings) {
const index = output.indexOf(heading);
expect(index).toBeGreaterThan(previousIndex);
previousIndex = index;
expect(output).toContain(heading);
}
}