Skip to content

Stabilize concurrent Bun runner assertions - #8947

Closed
lawrencecchen wants to merge 1 commit into
fix/founders-welcome-test-isolationfrom
fix-web-runner-output-order
Closed

lawrencecchen wants to merge 1 commit into
fix/founders-welcome-test-isolationfrom
fix-web-runner-output-order

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Jul 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • stop treating Bun heading emission order as test invocation order
  • keep exact sorted argv coverage in the shell guard
  • retain integration coverage for every recursively discovered test file

Testing

  • bash tests/test_ci_self_hosted_guard.sh
  • cd web && bun test tests/web-test-runner-isolation.test.ts
  • cd web && bun run typecheck

Repairs the Linux failure in PR 8941 gate run. The runner sorts argv before invoking Bun; Bun may report concurrently executed files in completion order.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.


Summary by cubic

Stabilizes the web test runner by allowing Bun’s concurrent execution and removing order-dependent assertions that caused Linux flakes. The shell guard still verifies sorted argv; integration tests now only assert that all discovered files ran.

  • Bug Fixes
    • Replaced order-based heading checks with presence checks in web/tests/web-test-runner-isolation.test.ts (expectHeadingsInOrder → expectHeadings); renamed test to “preserves recursive discovery”.
    • Kept exact sorted argv coverage in the CI shell guard to prevent regressions while Bun may report headings in completion order.

Written for commit f151bd3. Summary will update on new commits.

Review in cubic

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9420842b-e90d-4764-8097-8365d5309720

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-web-runner-output-order

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: f151bd30d5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@greptile-apps

greptile-apps Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates the Bun runner isolation test to tolerate concurrent file-heading emission while retaining per-file recursive discovery coverage.

  • Replaces ordered heading assertions with presence assertions.
  • Renames the recursive discovery test to reflect its narrower responsibility.
  • Documents that sorted argv coverage belongs to the shell guard.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The changed assertions continue verifying that every expected recursive fixture executes while no longer relying on Bun’s nondeterministic concurrent heading order.

Important Files Changed

Filename Overview
web/tests/web-test-runner-isolation.test.ts Correctly separates recursive execution coverage from argv-order coverage because Bun may emit headings in concurrent completion order.

Reviews (1): Last reviewed commit: "test: allow concurrent Bun heading order" | Re-trigger Greptile

@lawrencecchen
lawrencecchen deleted the branch fix/founders-welcome-test-isolation July 26, 2026 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant