Repository navigation
Stabilize concurrent Bun runner assertions - #8947
lawrencecchen wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Greptile SummaryUpdates the Bun runner isolation test to tolerate concurrent file-heading emission while retaining per-file recursive discovery coverage.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The changed assertions continue verifying that every expected recursive fixture executes while no longer relying on Bun’s nondeterministic concurrent heading order. Important Files Changed
Reviews (1): Last reviewed commit: "test: allow concurrent Bun heading order" | Re-trigger Greptile |
Summary
Testing
bash tests/test_ci_self_hosted_guard.shcd web && bun test tests/web-test-runner-isolation.test.tscd web && bun run typecheckRepairs the Linux failure in PR 8941 gate run. The runner sorts argv before invoking Bun; Bun may report concurrently executed files in completion order.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Stabilizes the web test runner by allowing Bun’s concurrent execution and removing order-dependent assertions that caused Linux flakes. The shell guard still verifies sorted argv; integration tests now only assert that all discovered files ran.
expectHeadingsInOrder→expectHeadings); renamed test to “preserves recursive discovery”.Written for commit f151bd3. Summary will update on new commits.