stage 3c (stacked): final five domains — System/Project/Debug/Sidebar/Browser

[azooz2003-bit]

TLDR

The final five socket-command domains of stage 3c, stacked on PR #5816 so the diff reviews standalone: System, Project, Debug, Sidebar (v1), and Browser move from TerminalController into ControlCommandCoordinator. TerminalController.swift drops 18,033 → 10,748 lines (−7,285); the legacy v2 switch is now just system.ping/system.capabilities. Merges into the 3c branch, not main.

What moved

• System: system.identify/tree, auth.login (parity-verified: {"authenticated": true, "required": accessMode.requiresPasswordAuth}), session.restore_previous, settings.open, feedback.open, extension.sidebar.snapshot, workspace.action, surface.action/tab.action, drag_to_split/split_off.
• Project: project.* (8 methods), markdown.open, file.open.
• Debug: all 39 debug.* methods (both former #if DEBUG blocks).
• Sidebar v1: 44 v1 verbs via a new handleSidebarV1(command:args:) hook ahead of the v1 switch; raw-string responses preserved.
• Browser: all 89 main-actor browser.* methods + the panel v1 verbs. The V2BrowserPendingDialog responder-closure DTO is redesigned Sendable: ControlBrowserPendingDialog carries a dialogID; the WKWebView completion handlers stay app-side keyed by that id. Per-surface browser state moved to the package's ControlBrowserAutomationState; cleanupSurfaceState purges it faithfully.

Shared bodies kept app-side + relaxed to internal (v2Identify, v2WorkspaceAction, v2SurfaceSplitOff, v2FileOpen, 18 v1-debug impls, the JS pump, the worker-lane browser.download.wait cluster). Worker-lane methods untouched.

Two deliberate deltas, both documented in the commit: controlFeedbackOpen drops the deprecated .activateIgnoringOtherApps (documented no-op on macOS 14+, the project floor); one sequence id bridges Int64→Int (lossless on arm64).

Verification so far

Package swift build + 140/140 tests; tagged app build green; zero new warnings; both budgets pass; live socket sweep across every domain (system.tree, auth.login parity, browser.open_split → browser.get.title returns the real page title end-to-end, project validation errors, v1 set-status through the new hook, plus regression of the ten prior domains). The adversarial per-method review against the pre-deletion originals is running now; its findings land as follow-up commits here before this merges.

🤖 Generated with Claude Code

---

^{Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.}

---

Summary by cubic

Moves the final five socket-command domains — System, Project, Debug, Sidebar (v1), and Browser — from TerminalController to ControlCommandCoordinator, dedupes file.open to the shared v2FileOpen, and fixes legacy error precedence for browser.focus_mode.set and browser.zoom.set. This finishes stage 3c, keeps wire replies byte-identical, and shrinks TerminalController.swift by ~7.3k lines.

• Refactors

  • Added ControlSystemContext, ControlProjectContext, ControlDebugContext, ControlSidebarContext, ControlBrowserContext, ControlBrowserAutomationContext, and ControlBrowserPanelContext to ControlCommandContext.
  • Split browser into nav/tabs/state and DOM-automation; centralized state in ControlBrowserAutomationState. Redesigned V2BrowserPendingDialog to ControlBrowserPendingDialog with a dialogID.
  • Ported 44 Sidebar v1 and 8 Browser Panel v1 verbs behind handleSidebarV1/handleBrowserPanelV1 with raw string replies preserved.
  • Deduped file.open to forward to the shared v2FileOpen; removed the coordinator-specific reimplementation; behavior unchanged.
  • Small deltas: feedback.open drops .activateIgnoringOtherApps; one sequence id bridges Int64→Int (lossless on arm64). Corrected validation order for browser.focus_mode.set and browser.zoom.set to match legacy guards. Budgets updated; package builds and 140/140 tests pass.

• Migration

  • Route v1 commands through handleSidebarV1(command:args:) and handleBrowserPanelV1(command:args:) before the legacy v1 switch.
  • Own a single ControlBrowserAutomationState and purge it in surface cleanup; keep WKWebView completions keyed by dialogID.
  • No wire API changes; responses and error shapes remain the same.

^{Written for commit 42f9332. Summary will update on new commits.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
cmux	Canceled		Jun 11, 2026 11:39pm
cmux-staging	Ready	Preview, Comment	Jun 11, 2026 11:39pm

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1acd75ba-0147-4006-a7b8-1b54c24c9b9c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat-ctl-3c-final-domains

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}