CmuxControlSocket stage 3c: extract the RPC dispatch half of TerminalController into ControlCommandCoordinator (14 domains)

[azooz2003-bit]

TLDR

Stage 3c of the CmuxControlSocket refactor (continues 3b, merged in #5719). Extracts the RPC dispatch half of TerminalController into a @MainActor @Observable ControlCommandCoordinator in the package, behind per-domain read-only seam protocols under a ControlCommandContext umbrella. The package never imports the app target. Sources/TerminalController.swift goes from 22,073 to 14,774 lines.

What moved

14 command domains now dispatch in ControlCommandCoordinator.handle(_:) and return typed ControlCallResults: window, app-focus, feed, notification, workspace-group, pane, mobile-host, workspace, surface, system, project, debug, sidebar (v2 plus the v1 string commands), and the v1 browser-panel commands. processCommand/processV2Command delegate to the coordinator first and fall through to the legacy switch for everything else, so unmoved and future methods keep working unchanged.

Each domain has its own seam protocol file and its own app-conformance file (TerminalController+Control<Domain>Context.swift); ControlCommandContext is an empty umbrella inheriting all of them. The coordinator owns the kind:N ControlHandleRegistry; the app routes ensureRef/resolveRef/removeRef through it so refs stay consistent across moved and unmoved domains.

Genuinely shared or irreducibly app-coupled bodies stay app-side and are reached by forwarding, never duplicated: v2WorkspaceCreate (shared with the mobile RPC path), v2FileOpen, v2SurfaceMove, v2DebugTerminals, v2WorkspaceAction, v2Identify, the worker-lane methods (vm.*, auth.*, system.top/memory, browser.download.wait, remote PTY), and the browser JS pump.

The v2 browser.* domain is deliberately NOT in this PR

The browser domain was lifted and verified, then #5778 landed on main moving every JS-evaluating browser.* method onto a nonisolated socket-worker lane (a starvation-deadlock fix for unmounted webviews). That architecture cannot live behind the @MainActor coordinator seam, so the merge of main into this branch adopts main's browser implementation wholesale and reverts the coordinator's browser-v2 domain (package files, conformances, tests). The v1 browser-panel handlers stay in the coordinator (main did not touch them). Re-lifting browser against the worker-lane architecture is a follow-up.

Faithfulness and verification

Every moved method was adversarially reviewed against its pre-deletion original (git show of the pre-cutover tree), with byte-identical wire output as the bar: JSONValue payloads whose foundationObject equals the legacy [String: Any], every error code/message/data preserved, side-effect order preserved. Divergences found in review (NSNumber coercion for numeric params, clear_history wrong-target side effect, workspace select/close/rename precheck order, focus_mode/zoom error precedence, stale-selection workspace.current) were fixed and live-verified over the socket. Localized strings resolve app-side so Japanese is not dropped by the package bundle.

Live gates on the final tree: 90-command v2 socket sweep plus v1 sidebar/browser-panel round-trips on a tagged build, 135 package tests in 25 suites, full app build, file-length budget, CI.

Tests

Package tests drive every moved domain through fake seam conformances (per-domain test-stub defaults keep fakes small). Regression tests cover the NSNumber numeric-param coercion and the window.close not-found branch.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
cmux	Ready	Preview, Comment	Jun 12, 2026 3:07am
cmux-staging	Building	Preview, Comment	Jun 12, 2026 3:07am

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Adds ControlCommandCoordinator, domain context protocols/DTOs, typed param/ref helpers, full domain handlers (window/pane/feed/notification/workspace-group/mobile/app-focus), TerminalController conformances and V2 dispatch wiring, tests, and Xcode source registrations.

Changes

ControlCommandCoordinator & Integration

Layer / File(s)	Summary
Protocol contracts and DTOs Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandContext.swift, Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlWindowContext.swift, Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlRoutingSelectors.swift, Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlWindowSummary.swift, Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlDisplayInfo.swift, Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlNotificationSnapshot.swift, Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlNotificationStrings.swift	Defines the umbrella ControlCommandContext, domain protocols, and value/result DTOs used across the coordinator boundary.
Coordinator core and params Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator.swift, ControlCommandCoordinator+Params.swift	Adds ControlCommandCoordinator (handle registry owner), public ref APIs, routing-selector construction, JSON/ref wiring helpers, and extensive typed parameter parsing.
Window command handlers Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator+Window.swift	Implements window.* handlers: list/current/focus/create/close/displays/display with error shaping and display-not-found helper.
Pane command handlers Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator+Pane.swift	Implements pane.* handlers (list/focus/surfaces/create/resize/swap/break/join/last) mapping params to context calls and shaping results.
Workspace-group handlers Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator+WorkspaceGroup.swift	Implements workspace.group.* handlers and payload builder, with localized error-string plumbing.
Feed, app-focus, notification, mobile handlers Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator+Feed.swift, ControlCommandCoordinator+AppFocus.swift, ControlCommandCoordinator+Notification.swift, ControlCommandCoordinator+MobileHost.swift	Adds feed.*, app.focus override/simulate, full notification domain, and mobile-host dispatchers with payload helpers and localized messages.
TerminalController context implementations Sources/TerminalControllerControlCommandContext.swift, Sources/TerminalController+ControlAppFocusContext.swift, Sources/TerminalController+ControlFeedContext.swift, Sources/TerminalController+ControlNotificationContext.swift, Sources/TerminalController+ControlPaneContext.swift, Sources/TerminalController+ControlWorkspaceGroupContext.swift, Sources/TerminalController+ControlMobileHostContext.swift	TerminalController conforms to the domain protocols and implements behaviors (window/pane/notification/workspace-group/mobile/feed/app-focus) by delegating to AppDelegate/TabManager/Stores.
TerminalController dispatch migration & project wiring Sources/TerminalController.swift, cmux.xcodeproj/project.pbxproj	Wires coordinator into V2 RPC dispatch (short-circuiting legacy switch), routes handle-ref APIs through the coordinator, removes migrated legacy switch branches, adjusts routing precedence, and registers new source files in the Xcode project.
Tests & stubs Packages/CmuxControlSocket/Tests/CmuxControlSocketTests/ControlCommandCoordinatorWindowTests.swift, Packages/CmuxControlSocket/Tests/CmuxControlSocketTests/ControlCommandContextTestStubs.swift, Packages/CmuxControlSocket/Tests/CmuxControlSocketTests/ControlCommandCoordinatorParamsTests.swift	Adds window-domain tests with FakeControlCommandContext, param/coercion tests for parsing helpers, and test stubs for other domain seams.

Sequence Diagram

sequenceDiagram
  participant V2Client as V2 RPC Client
  participant TermController as TerminalController
  participant CmdCoord as ControlCommandCoordinator
  participant Handles as ControlHandleRegistry
  participant Context as ControlCommandContext
  participant App as AppDelegate/TabManager/Stores
  V2Client->>TermController: send ControlRequest
  TermController->>CmdCoord: handle(request)
  alt coordinator handles method
    CmdCoord->>CmdCoord: parse params, routingSelectors
    CmdCoord->>Handles: resolveRef / ensureRef
    CmdCoord->>Context: control*(...)
    Context->>App: query/mutate state
    App-->>Context: typed result
    Context-->>CmdCoord: typed result
    CmdCoord-->>TermController: ControlCallResult
    TermController-->>V2Client: encoded response
  else fallback
    CmdCoord-->>TermController: nil
    TermController->>TermController: legacy dispatch
  end

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

• manaflow-ai/cmux#5804: Overlaps at the window.displays / window.display RPC level; that PR wires CLI/controller handlers complementary to this coordinator.
• manaflow-ai/cmux#5541: Related to workspace-group localized error keys and group behavior used by this coordinator.
• manaflow-ai/cmux#5483: Shares the underlying wire DTOs and handle-registry primitives used by the coordinator.

Poem

🐰 A coordinator hopped onto the scene,
Quietly routing windows, sharp and keen.
Protocol seams stitched neat and small,
Tests clap paws — they checked them all.
Hooray, the RPCs now answer the call.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat-ctl-coordinator-3c-1

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@Packages/CmuxControlSocket/Tests/CmuxControlSocketTests/ControlCommandCoordinatorWindowTests.swift`:
- Around line 202-212: The test windowCloseOkAndNotFound currently only checks
the success path; add a second assertion for the failure/not-found path by
toggling context.closeResult to false, calling
coordinator.handle(request("window.close", ["window_id":
.string(windowID.uuidString)])) again and asserting the returned value is the
not_found response and that context.closedID was not set (or cleared). Make the
change inside the same test after the existing success assertions, referencing
windowCloseOkAndNotFound, coordinator.handle(...), context.closeResult and
context.closedID to locate the code to update.

In `@Sources/TerminalController.swift`:
- Around line 4004-4020: The current routing logic falls back to a default
tabManager when an explicit selector (routing.groupID, routing.workspaceID,
routing.surfaceID, routing.paneID) is present but fails to resolve; change the
control flow so each explicit selector is authoritative: for each of
routing.groupID, routing.workspaceID, routing.surfaceID, and routing.paneID,
first check if the selector is non-nil and then attempt resolution (use
v2LocateTabManager(forGroupId:), AppDelegate.shared?.tabManagerFor(tabId:),
AppDelegate.shared?.locateSurface(surfaceId:)? .tabManager,
v2LocatePane(paneId)? .tabManager respectively); if resolution succeeds return
the found tab manager, but if the selector was present and resolution fails
return nil (do not fall through to tabManager or currentScriptableMainWindow());
keep the existing window_id behavior on line 4000 unchanged.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: fa3331bd-cded-4e7c-8e88-d4dd737d30ad

📥 Commits

Reviewing files that changed from the base of the PR and between 3a9c696 and 00da345.

⛔ Files ignored due to path filters (1)

• .github/swift-file-length-budget.tsv is excluded by !**/*.tsv

📒 Files selected for processing (12)

• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandContext.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator+Window.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCurrentWindowResolution.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlDisplayInfo.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlMoveAllWindowsResult.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlRoutingSelectors.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlWindowSummary.swift
• Packages/CmuxControlSocket/Tests/CmuxControlSocketTests/ControlCommandCoordinatorWindowTests.swift
• Sources/TerminalController.swift
• Sources/TerminalControllerControlCommandContext.swift
• cmux.xcodeproj/project.pbxproj

[greptile-apps]

Greptile Summary

This PR extracts the window, pane, workspace-group, notification, app-focus, feed, and mobile-host RPC domains from TerminalController into a new @MainActor @Observable ControlCommandCoordinator in the CmuxControlSocket package, behind a ControlCommandContext seam that the app target conforms to. TerminalController shrinks from ~22 k to ~20 k lines; handle(_:) chains domain handlers in order and falls through to the legacy switch for domains not yet moved.

• Each domain handler is a byte-faithful lift of the former v2* bodies; payloads are built as typed JSONValue instead of [String: Any], with foundationObject round-tripping to identical wire bytes.
• Two localized-string seams (ControlWorkspaceGroupStrings, ControlNotificationStrings) bridge app-bundle localized error messages across the package boundary so String(localized:) resolves in the app target, not the package bundle.
• The coordinator owns the ControlHandleRegistry (previously TerminalController.v2Handles); TerminalController routes ensureRef/resolveRef/removeRef through the coordinator so ref state stays consistent across moved and legacy domains.

Confidence Score: 5/5

Safe to merge; the change is a well-scoped, byte-faithful lift of existing RPC domain logic into the package coordinator with no behavioral changes on any moved path.

The refactor preserves existing wire bytes and error shapes across all moved domains, actor isolation is correct (@mainactor throughout), no new blocking primitives or timing hacks were introduced, and the coordinator + seam pattern is clean and consistently applied. The one finding is a workspace-group string fallback returning empty strings instead of English defaults, which only affects a pre-wiring state that does not occur in production.

No files require special attention beyond the workspaceGroupStrings() fallback in ControlCommandCoordinator+WorkspaceGroup.swift.

Important Files Changed

Filename	Overview
Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator.swift	Core coordinator class: @MainActor @Observable dispatch hub wiring domain handlers. The handles field (previously flagged) lacks @ObservationIgnored; all other patterns look correct.
Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator+WorkspaceGroup.swift	Workspace-group domain lift: well-structured, byte-faithful. The workspaceGroupStrings() fallback silently uses empty strings when context is nil, unlike the notification domain which provides English defaults.
Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator+Pane.swift	Pane domain (nine methods): correct @MainActor pass-through via seam. pane.create intentionally uses raw UUID parsing for surface_id per legacy behavior as documented in ControlPaneCreateInputs.
Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator+Notification.swift	Notification domain lift: uses ControlNotificationStrings seam correctly; English-default fallback in notificationStrings computed var is the right pattern for pre-wiring safety.
Sources/TerminalControllerControlCommandContext.swift	Umbrella conformance wiring TerminalController to ControlCommandContext; window domain witnesses correctly remove the now-redundant v2MainSync hops.
Sources/TerminalController+ControlPaneContext.swift	Pane seam conformance (611 lines, at budget): provides all ControlPaneContext witnesses; passes app-coupled Bonsplit logic through while keeping the package boundary clean.
Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator+Params.swift	Typed parameter parsing twins of legacy v2* helpers: int() and double() correctly use NSNumber to match legacy as? NSNumber behavior (avoids Swift Int(Double) overflow/NaN trap).

Sequence Diagram

sequenceDiagram
    participant Socket as Socket Worker
    participant TC as TerminalController
    participant Coord as ControlCommandCoordinator
    participant Ctx as ControlCommandContext(seam)
    participant App as AppDelegate / TabManager

    Socket->>TC: processV2Command(request)
    TC->>Coord: handle(request)
    alt "window.* / pane.* / workspace.group.* / notification.* / app.focus / feed / mobile.*"
        Coord->>Ctx: controlXxx(routing:, ...)
        Ctx->>App: live state read/write
        App-->>Ctx: result
        Ctx-->>Coord: typed resolution enum
        Coord-->>TC: ControlCallResult
        TC-->>Socket: encoded response
    else legacy domains (not yet moved)
        Coord-->>TC: nil
        TC->>TC: legacy switch (unchanged)
        TC-->>Socket: encoded response
    end

Loading

_{Reviews (5): Last reviewed commit: "stage 3c: fix int/double param helpers t..." | Re-trigger Greptile}

[coderabbitai]

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator+Window.swift (1)

115-115: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick win

Simplify the nested Int conversion.

The Int64(Int($0)) pattern converts UInt32? -> Int -> Int64. Since displayID is effectively a UInt32, you can convert directly to Int64($0) without the intermediate Int cast.

♻️ Proposed simplification

-"display_id": display.displayID.map { JSONValue.int(Int64(Int($0))) } ?? .null,
+"display_id": display.displayID.map { JSONValue.int(Int64($0)) } ?? .null,

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator`+Window.swift
at line 115, The JSON construction uses a nested cast for display.displayID
("display_id": display.displayID.map { JSONValue.int(Int64(Int($0))) } ??
.null); simplify by removing the unnecessary intermediate Int cast and convert
the UInt32 (or optional UInt32) directly to Int64 (i.e., use Int64($0)) so the
mapping becomes JSONValue.int(Int64($0)) inside the display.displayID.map
closure.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlAppFocusContext.swift`:
- Line 1: The Foundation import in ControlAppFocusContext.swift is unused;
remove the line "internal import Foundation" from the file and ensure no other
Foundation symbols are referenced by the protocol signatures or comments; if the
comments reference AppKit types like NSApp or
NSApplication.didBecomeActiveNotification, either update the comments to avoid
implying Foundation or, if AppKit APIs are actually needed, replace the
Foundation import with the correct AppKit import.

---

Outside diff comments:
In
`@Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator`+Window.swift:
- Line 115: The JSON construction uses a nested cast for display.displayID
("display_id": display.displayID.map { JSONValue.int(Int64(Int($0))) } ??
.null); simplify by removing the unnecessary intermediate Int cast and convert
the UInt32 (or optional UInt32) directly to Int64 (i.e., use Int64($0)) so the
mapping becomes JSONValue.int(Int64($0)) inside the display.displayID.map
closure.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: c6eaa018-6d38-4ca9-ad8e-be7b2f6bec9c

📥 Commits

Reviewing files that changed from the base of the PR and between 2383068 and b02c28d.

⛔ Files ignored due to path filters (1)

• .github/swift-file-length-budget.tsv is excluded by !**/*.tsv

📒 Files selected for processing (22)

• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlAppFocusContext.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandContext.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator+AppFocus.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator+Feed.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator+Notification.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator+Window.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlFeedContext.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlNotificationContext.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlNotificationCreateResolution.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlNotificationDismissResolution.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlNotificationMarkReadResolution.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlNotificationOpenResolution.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlNotificationSnapshot.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlNotificationStrings.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlNotificationTargetedDeliveryResolution.swift
• Packages/CmuxControlSocket/Tests/CmuxControlSocketTests/ControlCommandContextTestStubs.swift
• Sources/TerminalController+ControlAppFocusContext.swift
• Sources/TerminalController+ControlFeedContext.swift
• Sources/TerminalController+ControlNotificationContext.swift
• Sources/TerminalController.swift
• cmux.xcodeproj/project.pbxproj

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlMobileHostContext.swift`:
- Line 1: ControlMobileHostContext.swift currently uses "internal import
Foundation" which is inconsistent with sibling seam protocol files (e.g.,
ControlPaneContext, ControlWindowContext) that use public visibility; update the
file to match the intended public seam visibility by changing the import
visibility to "public import Foundation" and ensure any protocol/type
declarations in this file (e.g., the ControlMobileHostContext protocol/type
declarations) have public access modifiers to match the other Control*Context
seam protocols—alternatively, if this file is intentionally internal, add a
concise comment explaining why it differs and update other files to the intended
internal visibility for consistency.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1b57e6a0-7224-4e10-b15f-3133f08acaa2

📥 Commits

Reviewing files that changed from the base of the PR and between b02c28d and 9bdae00.

⛔ Files ignored due to path filters (1)

• .github/swift-file-length-budget.tsv is excluded by !**/*.tsv

📒 Files selected for processing (36)

• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandContext.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator+MobileHost.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator+Pane.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator+WorkspaceGroup.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlCommandCoordinator.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlMobileHostContext.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlPaneBreakResolution.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlPaneContext.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlPaneCreateInputs.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlPaneCreateResolution.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlPaneFocusResolution.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlPaneGridSize.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlPaneJoinResolution.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlPaneLastResolution.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlPaneListSnapshot.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlPanePixelFrame.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlPaneResizeInputs.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlPaneResizeResolution.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlPaneSummary.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlPaneSurfaceSummary.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlPaneSurfacesSnapshot.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlPaneSwapResolution.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlWorkspaceGroupAddResolution.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlWorkspaceGroupContext.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlWorkspaceGroupCreateResolution.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlWorkspaceGroupFocusResolution.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlWorkspaceGroupListResolution.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlWorkspaceGroupNewWorkspaceResolution.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlWorkspaceGroupSnapshot.swift
• Packages/CmuxControlSocket/Sources/CmuxControlSocket/Coordinator/ControlWorkspaceGroupStrings.swift
• Packages/CmuxControlSocket/Tests/CmuxControlSocketTests/ControlCommandContextTestStubs.swift
• Sources/TerminalController+ControlMobileHostContext.swift
• Sources/TerminalController+ControlPaneContext.swift
• Sources/TerminalController+ControlWorkspaceGroupContext.swift
• Sources/TerminalController.swift
• cmux.xcodeproj/project.pbxproj