Skip to content

Restore file explorer remote root CI coverage #4891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lawrencecchen wants to merge 2 commits into from
Closed

Restore file explorer remote root CI coverage #4891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa09c59
Restore file explorer remote root CI coverage
lawrencecchen May 27, 2026
8a41296
Fix stale file explorer load cancellation
lawrencecchen May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,18 +275,11 @@ jobs:
set -euo pipefail
SOURCE_PACKAGES_DIR="$PWD/.ci-source-packages"
run_unit_tests() {
# These app-host tests create real SwiftUI/WebKit/Ghostty windows and
# intermittently crash inside XCTest's post-test memory checker or
# leave native display/WebKit work alive on GitHub macOS runners.
# When that happens, Swift's crash/backtrace handling or the stale
# app-host process keeps xcodebuild alive until the job-level timeout,
# hiding the actual unit test summary.
xcodebuild -project cmux.xcodeproj -scheme cmux-unit -configuration Debug \
-clonedSourcePackagesDirPath "$SOURCE_PACKAGES_DIR" \
-disableAutomaticPackageResolution \
-destination "platform=macOS" \
CMUX_SKIP_ZIG_BUILD=1 \
-skip-testing:cmuxTests/FileExplorerStoreTests/testRemoteWorkspaceRootRequestResolvesSSHHomeInsteadOfKeepingLocalPath \
test 2>&1 &
local xcodebuild_pid=$!
local timeout_seconds="${CMUX_UNIT_TEST_TIMEOUT_SECONDS:-900}"
Expand Down
1 change: 1 addition & 0 deletions Sources/FileExplorerStore.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -888,6 +888,7 @@ final class FileExplorerStore: ObservableObject {

@MainActor
private func loadChildren(for parentNode: FileExplorerNode?, at path: String, silent: Bool = false) async {
guard !Task.isCancelled else { return }
guard let provider else { return }

if !silent {
Expand Down
Loading