Repository navigation
Restore file explorer remote root CI coverage - #4891
Closed
lawrencecchen wants to merge 2 commits into
Closed
lawrencecchen wants to merge 2 commits into
lawrencecchen wants to merge 2 commits into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThis PR restores CI coverage for
Confidence Score: 5/5Safe to merge — a single-line cooperative cancellation guard and a CI skip-list removal, both with clear and correct intent. The Swift change is a standard, idiomatic cancellation check at a function entry point. It does not introduce new state, alter any data flow, or touch anything outside the already-established cancellation pattern in No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["loadChildren called"] --> B{"Task.isCancelled?\n(NEW guard)"}
B -- "yes" --> Z["return immediately\n(no state mutation)"]
B -- "no" --> C{"provider available?"}
C -- "no" --> Z
C -- "yes" --> D["Set loadingPaths, isRootLoading\nobjectWillChange.send()"]
D --> E["await provider.listDirectory()"]
E --> F{"try Task.checkCancellation()\n(pre-existing)"}
F -- "throws CancellationError" --> G{"catch: Task.isCancelled?\n(pre-existing)"}
G -- "yes" --> Z2["return\n(skip UI cleanup — cancelAllLoads handles it)"]
G -- "no" --> H["Update error state\nclean loadingPaths/loadTasks\nobjectWillChange.send()"]
F -- "ok" --> I["Update children/rootNodes\nclean loadingPaths/loadTasks\nobjectWillChange.send()"]
I --> J["Spawn child Tasks for\npreviously-expanded dirs"]
Reviews (3): Last reviewed commit: "Fix stale file explorer load cancellatio..." | Re-trigger Greptile |
📝 WalkthroughWalkthroughThe CI workflow ChangesCI Test Quarantine
FileExplorerStore runtime change
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (17 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
lawrencecchen
force-pushed
the
issue-4524-file-explorer-store
branch
from
May 28, 2026 00:35
40e534d to
8a41296
Compare
lawrencecchen
added
the
stale-revisit
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores CI coverage for
FileExplorerStoreTests/testRemoteWorkspaceRootRequestResolvesSSHHomeInsteadOfKeepingLocalPathby removing its targeted-skip-testingquarantine.This is part of #4524.
Testing:
git diff --check.github/workflows/ci.ymlwith Ruby YAML loaderNeed help on this PR? Tag
@codesmithwith what you need. Autofix is disabled.Note
Low Risk
Small behavioral guard plus CI re-enablement; main risk is renewed CI flakiness if the underlying app-host instability was not fully fixed.
Overview
Re-enables
FileExplorerStoreTests/testRemoteWorkspaceRootRequestResolvesSSHHomeInsteadOfKeepingLocalPathin the macOS unit-test job by dropping its-skip-testingquarantine and the related CI comments.Adds an early
Task.isCancelledcheck at the start ofFileExplorerStore.loadChildrenso cancelled directory loads do not touch loading state or trigger UI updates—supporting stable remote SSH home resolution when loads are superseded.Reviewed by Cursor Bugbot for commit 8a41296. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
Summary by cubic
Re-enabled CI for
FileExplorerStoreTests/testRemoteWorkspaceRootRequestResolvesSSHHomeInsteadOfKeepingLocalPathby removing its skip incmux-unit. Added an early cancellation check inFileExplorerStore.loadChildrento prevent stale updates and keep SSH home resolution stable.Task.isCancelledinFileExplorerStore.loadChildren.-skip-testingentry in.github/workflows/ci.yml.Written for commit 8a41296. Summary will update on new commits.
Review in cubic