Repository navigation
acpmux: build on macOS again (daemon enroll off Linux) - #36647
Conversation
… the Windows-only module) #36564 routed `daemon enroll` on every non-Linux build to `crate::platform::unsupported`, but `platform` compiles only when the target is not unix. A macOS build of acpmux (the app's bundled daemon) fails with E0433. The arm now returns its own error. Red: cmux-ci dev build job 4aed088bf06e589b164bc0f8 (tui-fetch, E0433 at crates/acpmux/src/cli/entry.rs:214). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
|
Subagent correctness review of 48439bf: no findings. The two DaemonEnroll arms (linux / not linux) are exclusive and exhaustive on every target; the variant is not cfg-gated; ffcb907 added no other platform:: use. Primary check: same reading. macOS compile evidence comes from the cmux-ci dev build of #36084 at abbfb1257716e6dd8b43b8c577e65bba07d91466, which contains this commit. |
|
Correction to the comment above: the integration head that contains this commit is abbfb12 (a typo gave abbfb1257716…). Its macOS dev build is cmux-ci job 84cb501061b6a88b32042f66; job 352bd4e43d7f826f13eabe6b failed only on the mistyped SHA. |
|
MERGE QUEUE: merged to fix the tip compile red (STATUS 14750, culprit #36564). Fleet compile-check f1fe6d301544ce6c76d6f2af at 48439bf, recipe 2: CmuxNext pass, app pass, macOS cmux-tui cargo check pass. Linux clippy (changed cmux-tui packages) pass. Every other crate::platform:: use in acpmux sits under #[cfg(not(unix))]; this arm was the only one reached from macOS. |
…32448 turns spare adoption on for every existing chat) #32448 landed the adoption, the cover order and the adopted-page trace surface this branch had for subagent panes only; theirs are kept, and the subagent-only gate (adopts(subagentPane:keptTail:), takeConnectedSpare's reveal and session, Surface.shownPage, AgentSubagentPanes.isReveal) goes. This branch keeps the tail in the adopt event, the subagent reveal before the switch, the reveal on the tab before its first show, the trace's first-pane takeover (#36060) and the bench fixes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-cb01117327fc358e9ba1
entry.rs takes the base (it landed #36647, rustfmt'd); updater/tests.rs keeps the branch's two systemd restart tests and the base's linux gate on the short_hex test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A macOS build of acpmux fails on
feat-cmux-nextsince #36564:The
daemon enrollarm for non-Linux builds callscrate::platform::unsupported, butmod platformis#[cfg(not(unix))](Windows only). On macOS the arm now returns its own error,daemon enroll runs only on Linux.Red: cmux-ci dev build job
4aed088bf06e589b164bc0f8(step tui-fetch) for #36084. That integration PR takes this commit and its dev build is the macOS check.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes macOS builds of
acpmuxfailing after the recentdaemon enrollrouting change.daemon enrollpreviously returnedcrate::platform::unsupported, but that module only compiles for Windows, so macOS builds hit a compile error.daemon enroll runs only on Linuxerror instead.Written for commit 48439bf. Summary will update on new commits.