Skip to content

acpmux: build on macOS again (daemon enroll off Linux) - #36647

Merged
lawrencecchen merged 1 commit into
feat-cmux-nextfrom
acpmux-macos-daemon-enroll
Nov 5, 2026
Merged

lawrencecchen merged 1 commit into
feat-cmux-nextfrom
acpmux-macos-daemon-enroll

Conversation

@austinywang

@austinywang austinywang commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

A macOS build of acpmux fails on feat-cmux-next since #36564:

error[E0433]: cannot find `platform` in `crate`
   --> crates/acpmux/src/cli/entry.rs:214:58

The daemon enroll arm for non-Linux builds calls crate::platform::unsupported, but mod platform is #[cfg(not(unix))] (Windows only). On macOS the arm now returns its own error, daemon enroll runs only on Linux.

Red: cmux-ci dev build job 4aed088bf06e589b164bc0f8 (step tui-fetch) for #36084. That integration PR takes this commit and its dev build is the macOS check.

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes macOS builds of acpmux failing after the recent daemon enroll routing change.

  • On non-Linux builds, daemon enroll previously returned crate::platform::unsupported, but that module only compiles for Windows, so macOS builds hit a compile error.
  • The arm now returns its own daemon enroll runs only on Linux error instead.

Written for commit 48439bf. Summary will update on new commits.

View guided diff Turn on auto-fix

… the Windows-only module)

#36564 routed `daemon enroll` on every
non-Linux build to `crate::platform::unsupported`, but `platform` compiles
only when the target is not unix. A macOS build of acpmux (the app's bundled
daemon) fails with E0433. The arm now returns its own error.

Red: cmux-ci dev build job 4aed088bf06e589b164bc0f8 (tui-fetch, E0433 at
crates/acpmux/src/cli/entry.rs:214).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 48439bf: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr36647 -f ref=acpmux-macos-daemon-enroll -f platform=macos -f backend_mode=local

Shipped in:

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 5, 2026
@austinywang

Copy link
Copy Markdown
Contributor Author

Subagent correctness review of 48439bf: no findings. The two DaemonEnroll arms (linux / not linux) are exclusive and exhaustive on every target; the variant is not cfg-gated; ffcb907 added no other platform:: use. Primary check: same reading. macOS compile evidence comes from the cmux-ci dev build of #36084 at abbfb1257716e6dd8b43b8c577e65bba07d91466, which contains this commit.

@austinywang

Copy link
Copy Markdown
Contributor Author

Correction to the comment above: the integration head that contains this commit is abbfb12 (a typo gave abbfb1257716…). Its macOS dev build is cmux-ci job 84cb501061b6a88b32042f66; job 352bd4e43d7f826f13eabe6b failed only on the mistyped SHA.

@austinywang austinywang added the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Nov 5, 2026
@austinywang

Copy link
Copy Markdown
Contributor Author

macOS compile evidence: cmux-ci dev build job 84cb501061b6a88b32042f66 at abbfb12 (contains 48439bf) succeeded, including acpmux for the Mac target; job 4aed088bf06e589b164bc0f8 at 3e9d593 (without it) failed with E0433. Labelled ready-to-land.

@lawrencecchen

Copy link
Copy Markdown
Contributor

MERGE QUEUE: merged to fix the tip compile red (STATUS 14750, culprit #36564). Fleet compile-check f1fe6d301544ce6c76d6f2af at 48439bf, recipe 2: CmuxNext pass, app pass, macOS cmux-tui cargo check pass. Linux clippy (changed cmux-tui packages) pass. Every other crate::platform:: use in acpmux sits under #[cfg(not(unix))]; this arm was the only one reached from macOS.

@lawrencecchen
lawrencecchen merged commit 4ed02ae into feat-cmux-next Nov 5, 2026
245 of 254 checks passed
@lawrencecchen
lawrencecchen deleted the acpmux-macos-daemon-enroll branch November 5, 2026 15:02
teamleaderleo added a commit that referenced this pull request Nov 5, 2026
…32448 turns spare adoption on for every existing chat)

#32448 landed the adoption, the cover order and the adopted-page trace surface this branch had for
subagent panes only; theirs are kept, and the subagent-only gate (adopts(subagentPane:keptTail:),
takeConnectedSpare's reveal and session, Surface.shownPage, AgentSubagentPanes.isReveal) goes. This
branch keeps the tail in the adopt event, the subagent reveal before the switch, the reveal on the tab
before its first show, the trace's first-pane takeover (#36060) and the bench fixes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-cb01117327fc358e9ba1
austinywang added a commit that referenced this pull request Nov 6, 2026
entry.rs takes the base (it landed #36647, rustfmt'd); updater/tests.rs keeps the branch's two systemd restart tests and the base's linux gate on the short_hex test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch was previously deployed

3 inactive deployments
ci-routing-agent — 48439bf6 Deployed Nov 5, 2026 by github-actions[bot] via cmux-next macOS placement #73302
artifacts — 48439bf6 Deployed Nov 5, 2026 by austinywang via publish tree-addressed cmux-tui #116553
sentry-dsyms — 48439bf6 Deployed Nov 5, 2026 by austinywang via upload cmux-tui dSYMs to Sentry #116553
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants