Skip to content

ghostty-next: pin 850bb9849 (fork PR #84): a reflow preview frame re-wraps off the terminal lock - #36577

Merged
lawrencecchen merged 4 commits into
feat-cmux-nextfrom
fix/t-rewrap-ghostty-next-pin
Nov 5, 2026
Merged

lawrencecchen merged 4 commits into
feat-cmux-nextfrom
fix/t-rewrap-ghostty-next-pin

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

cmux-ad m18 (T-REWRAP). GhosttyNextKit and the ghostty-next gitlink move together from 383b27d73 (fork main, the upstream sync) to 850bb9849 (fork main + fork PR #84):

No C API change: the app keeps ghostty_surface_set_size each frame with ghostty_surface_set_reflow_preview(true). No change in the present path.

The release: xcframework-850bb98497044f6632310c303a68974b6289af4b-apple-v6 (run 42047067774), zip sha256 f8b0c65707292cce8fa34fa195b529206a45b6f2b53b187c5b401339e233006f. The release's SHA256SUMS, the GitHub asset digest and the manifest commit agree. The changed fork files are not in the libghostty-vt link graph, so vt-link-graph.json changes only its commit.

This branch was first opened on the release line (510ca45ff, fork #83); feat moved to fork main (#35478) during its checks, so it was re-pinned to the main port. The branch now differs from feat only in the 5 pin files.

Testing

  • Fork: reflow preview: tests (6). Reds: run 42018811302 ("a frame whose only change is the grid copies nothing under the terminal lock", expected 1, found 7) and run 42024684069 (stale cursor, expected x 1, found 2). On main (Zig 0.17): tests + bench 42040022802 (84/84; 1 copy for 800 frames), PR build 42040024043 (224/224, lib-vt 481/481).
  • Fork reviews: independent SHIP at 79d62f7c5 (Reduce terminal input latency via portal hosting + selected-only workspace mounting #83, after one BLOCK fixed), delta SHIP at f9048ee65 (Release v0.49.0 #84).
  • Here: check_ghostty_vt_notices.py --check-link-graph and package_notices.py check-data pass; prepush-gate.py passes.
  • Fleet, exact head 469d944007c: Mac DEV build 26cfebb8ed2e47e8598139e8 (aws-m4pro-4, tag t-rewrap-pin-v4); launch smoke PASS on macOS 14.8.7 and 15.7.7 (os-matrix step d4c5cd6146f51695570c508c, 0 crashes, 0 hangs, 0 faults). Its split screenshot shows the left terminal's command line re-wrapped at the narrower pane.

Observed / Not run

  • Observed: everything above.
  • Not run: films and the STRESS gate (owned by T-KEYS and T-DRAGS); the display resize suites at this head. The earlier Linux-pool build failed only in the import-set infra red (STATUS 14391), and an earlier Mac build only in the acpmux base red fixed by acpmux: build on macOS again (daemon enroll off Linux) #36647.

No capture: the change is the cost and the lock time of each resize frame; what a frame shows does not change.

Changelog

none

…wraps off the terminal lock

GhosttyNextKit and the ghostty-next gitlink move together from 12ec155e1
to 510ca45ff on release/cmux-9ce9b7d0-e2 (fork PR #83, cmux-ad m18
T-REWRAP). Release xcframework-510ca45ff8fc1fb03c600dfedae7c6f098402cd8-apple-v6
(run 42028591194), zip sha256 0efea1c3...eacfcf (the release's SHA256SUMS
and the GitHub asset digest agree; manifest commit 510ca45ff).

No C API change. During a key resize or a divider drag, each frame's
re-wrap reads a kept copy of the terminal with no terminal lock held; the
live terminal is copied under the lock only when it changed. At 12ec155e1
every preview frame copied it under the lock (0.43-0.55 ms p50 at
200x60). The changed fork files (src/renderer/ReflowPreview.zig,
src/renderer.zig, src/benchmark) are not in the libghostty-vt link graph,
so vt-link-graph.json changes only its commit.
…p-ghostty-next-pin

# Conflicts:
#	Packages/Shared/CmuxGhosttyKit/Package.swift
#	cmux-tui/dist/notices/package-notices.json
#	ghostty-next
#	scripts/cmux-next/notices/vt-link-graph.json
… reflow preview frame re-wraps off the terminal lock

GhosttyNextKit and the ghostty-next gitlink move together from 383b27d73
to 850bb9849 on fork main. Release
xcframework-850bb98497044f6632310c303a68974b6289af4b-apple-v6 (run
42047067774), zip sha256 f8b0c657...3006f (the release's SHA256SUMS, the
GitHub asset digest and the manifest commit agree).

No C API change. During a key resize or a divider drag, each frame's
re-wrap reads a kept copy of the terminal with no terminal lock held; the
live terminal is copied under the lock only when it changed. Before, every
preview frame copied it under the lock (0.43-0.55 ms p50 at 200x60). The
changed fork files are not in the libghostty-vt link graph, so
vt-link-graph.json changes only its commit. docs/ghostty-fork.md: this
branch's earlier release-line edit of the host-present section is
reverted to feat's text.
@cursor

cursor Bot commented Nov 5, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 1b80352: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr36577 -f ref=fix/t-rewrap-ghostty-next-pin -f platform=macos -f backend_mode=local

Shipped in:

@lawrencecchen lawrencecchen changed the title ghostty-next: pin 510ca45ff (fork PR #83): a reflow preview frame re-wraps off the terminal lock ghostty-next: pin 850bb9849 (fork PR #84): a reflow preview frame re-wraps off the terminal lock Nov 5, 2026
@lawrencecchen
lawrencecchen merged commit 2276b30 into feat-cmux-next Nov 5, 2026
296 of 306 checks passed
@lawrencecchen
lawrencecchen deleted the fix/t-rewrap-ghostty-next-pin branch November 5, 2026 22:36
lawrencecchen added a commit that referenced this pull request Nov 5, 2026

This branch was previously deployed

3 inactive deployments
ci-routing-agent — 469d9440 Deployed Nov 5, 2026 by github-actions[bot] via cmux-next macOS placement #73461
artifacts — 469d9440 Deployed Nov 5, 2026 by lawrencecchen via publish tree-addressed cmux-tui #116682
sentry-dsyms — 469d9440 Deployed Nov 5, 2026 by lawrencecchen via upload cmux-tui dSYMs to Sentry #116682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant