Skip to content

cmux NEXT: delete the side sessions and lost prompt replay debug switches - #36333

Merged
teamleaderleo merged 4 commits into
feat-cmux-nextfrom
lane/nx-flag-rot-side-sessions
Nov 5, 2026
Merged

teamleaderleo merged 4 commits into
feat-cmux-nextfrom
lane/nx-flag-rot-side-sessions

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Debug Settings loses two switches that have been on by default and never needed turning off: Side sessions (/btw) (agentPane.debug.sideSessions) and Send again a prompt a dropped connection lost (agentPane.debug.lostPromptReplay). Nothing changes for anyone on the defaults: /btw, /side and the palette's Ask a Side Question… are always offered in an agent chat (the Quick Composer still has no /btw, as before), and a prompt acpmux never took because its connection dropped always goes again on the next connection.

Leo, 2026-11-05: "i meant can you do all of htem" (the ranked list whose move 10 is "Flip or delete Debug/Labs flags after 7 days (flips need Leo's OK)").

Leo, 2026-11-05 08:34Z: "rulebook cut and any flag flip only merge after you OK them. i ok them i know most are super stale/superseded/obsolete/can be condensed and consolidated"

What's removed

Side sessions:

  • The Tunable and its descriptor entry; AgentPaneHeaderState.sideSessions and the sideSessions field it sent the page.
  • ActionContext.sideSessions (bit 23, the highest bit, so no other bit moves), its keyNames and RegistryControlBridge.contextNames entries, and ActionRegistry.publishSideSessions. agentPane.sideQuestion now requires only .agentPaneFocused.
  • Page side: aside/sideSessions.ts and the header state's sideSessions. The composer's opensSideSessions is now just !quick, so the Quick Composer's "Side questions are disabled" refusal stays.
  • Tests that only covered the off path: header-state-side-sessions.test.ts, the three "Side sessions off" browser tests in agent-pane-btw-side-session.test.ts (and the helpers only they used), and AgentPaneSideSessionsHeaderTests (replaced by one test that a focused chat offers Ask a Side Question…).

Lost-prompt replay:

  • The Tunable and its descriptor entry. With it on, the transport always called ended(byDaemon: false), so the byDaemon parameter and the journal branch that dropped the page's prompts on a daemon close (reached only with the switch off) are gone. AgentPanePromptJournal.connectionEnded(owner:) now just releases the connection's holds, as it did by default.
  • The off case of aPromptTheDaemonDroppedWithItsConnectionGoesAgainOnTheNextOne.

schemas/defaults/cmux-next.json drops the four lines for these two keys. plans/cmux-next/swift-logic-classes.tsv drops the deleted file's row.

Takes back #25441: on purpose. This deletes the Side sessions (/btw) gate #25441 wired in (the ActionContext.sideSessions bit and its publishing). Ask a Side Question… stays in the palette, now gated only by agent-pane focus, since side sessions are on by default and the gate goes with Leo's OK above.
Takes back #27091: on purpose. It deletes only the /btw browser tests that covered the gate's off state, which can no longer happen.

Changelog

Removed: the Debug Settings toggles "Side sessions (/btw)" and "Send again a prompt a dropped connection lost"; both behaviours stay on.

Observed / Not run

Observed:

  • python3 scripts/cmux-next/prepush-gate.py: no new violations.
  • webviews: bun run check passes; scripts/web-lint.sh passes.
  • bun test test/cmux-command-dispatch.test.ts test/composer-return-sends.test.tsx src/agent-session/acpmux/cmuxCommands.test.ts: 34 pass.
  • Compile check of CmuxNext at c1be714: passed (job a31d26dfea8489695540339e).
  • CMUX_BROWSER_TESTS=1 bun test test/agent-pane-btw-side-session.test.ts test/cmux-command-dispatch.test.ts at c1be714 on CI (run 41999232584): 15 pass, including the ten real-Chromium /btw tests.

Not run:

  • The CmuxNextAgentPane Swift suites touched here (AgentPaneUnsentPromptTests, AgentPaneSendPickedFolderPromptTests, AgentPaneSideQuestionAvailabilityTests, AgentPageCommandTests) were not run; the compile check covers only the sources.
  • python3 scripts/ci/defaults_guard.py check-fresh still reports base drift from cmux NEXT: Live Web Reload on by default in every build, and live in Chromium too #36173 (webDev.override), which this PR leaves alone.

Agent session: agent session

🤖 Generated with Claude Code

…ches

/btw, /side and Ask a Side Question… stay always on, and a prompt a
dropped connection lost always goes again on the next connection, as
both did by default. Removes agentPane.debug.sideSessions (its header
state field, the ActionContext.sideSessions bit 23 the palette action
required, publishSideSessions) and agentPane.debug.lostPromptReplay
(the journal's byDaemon branch only that switch reached), with the
tests that only pinned the off paths.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-e9467c26845236490067
@github-actions

github-actions Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 5c5b8c7: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr36333 -f ref=lane/nx-flag-rot-side-sessions -f platform=macos -f backend_mode=local

Gallery before/after for 5c5b8c7: 16 states rendered, 0 images differ, 3747 more touched states not rendered. Images are in the run's artifact, not on this public PR; the independent review of this head reads them on its own, so the PR needs no hand-made screenshots of these states.

gh run download 42048773737 -R manaflow-ai/cmux -n gallery-advisory-36333-5c5b8c729e94748135f210aefe58858350f52967 (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.chat-width/standard Apple System Colors Light unchanged 0% own App.tsx
agent-pane.chat-width/standard Apple System Colors unchanged 0% own App.tsx
agent-pane.chat-width/wide Apple System Colors Light unchanged 0% own App.tsx
agent-pane.chat-width/wide Apple System Colors unchanged 0% own App.tsx
agent-pane.chat-width/wide-blocks Apple System Colors Light unchanged 0% own App.tsx
agent-pane.chat-width/wide-blocks Apple System Colors unchanged 0% own App.tsx
agent-pane.composer-edge/short-edge Apple System Colors Light unchanged 0% own App.tsx
agent-pane.composer-edge/short-edge Apple System Colors unchanged 0% own App.tsx
agent-pane.composer-edge/wide-edge Apple System Colors Light unchanged 0% own App.tsx
agent-pane.composer-edge/wide-edge Apple System Colors unchanged 0% own App.tsx
agent-pane.composer-edge/no-edge Apple System Colors Light unchanged 0% own App.tsx
agent-pane.composer-edge/no-edge Apple System Colors unchanged 0% own App.tsx
agent-pane.composer-floats/scrolled-to-end Apple System Colors Light unchanged 0% own App.tsx
agent-pane.composer-floats/scrolled-to-end Apple System Colors unchanged 0% own App.tsx
agent-pane.composer-floats/composer-grown Apple System Colors Light unchanged 0% own App.tsx
agent-pane.composer-floats/composer-grown Apple System Colors unchanged 0% own App.tsx
agent-pane.composer-rest-gap/gap-40 Apple System Colors Light unchanged 0% own App.tsx
agent-pane.composer-rest-gap/gap-40 Apple System Colors unchanged 0% own App.tsx
agent-pane.composer-rest-gap/gap-56 Apple System Colors Light unchanged 0% own App.tsx
agent-pane.composer-rest-gap/gap-56 Apple System Colors unchanged 0% own App.tsx
agent-pane.composer-rest-gap/gap-72 Apple System Colors Light unchanged 0% own App.tsx
agent-pane.composer-rest-gap/gap-72 Apple System Colors unchanged 0% own App.tsx
agent-pane.continuation-spacing/shipped Apple System Colors Light unchanged 0% own App.tsx
agent-pane.continuation-spacing/shipped Apple System Colors unchanged 0% own App.tsx
agent-pane.continuation-spacing/two-thirds Apple System Colors Light unchanged 0% own App.tsx
agent-pane.continuation-spacing/two-thirds Apple System Colors unchanged 0% own App.tsx
agent-pane.continuation-spacing/half-tucked Apple System Colors Light unchanged 0% own App.tsx
agent-pane.continuation-spacing/half-tucked Apple System Colors unchanged 0% own App.tsx
agent-pane.continuation-spacing/before Apple System Colors Light unchanged 0% own App.tsx
agent-pane.continuation-spacing/before Apple System Colors unchanged 0% own App.tsx
agent-pane.copy-controls/output Apple System Colors Light unchanged 0% own App.tsx
agent-pane.copy-controls/output Apple System Colors unchanged 0% own App.tsx

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

Default changes

This pull request changes 4 defaults at 5c5b8c729e94 (what everyone gets without configuring anything):

  • tunable-source.CmuxNextAgentPane/AgentPaneTunables.swift:lostPromptReplay: "2c31be0b94d7b46601841d2c4a2c2003756e25be45010520737622cca68c9e74" -> (none)
  • tunable-source.CmuxNextAgentPane/AgentPaneTunables.swift:sideSessions: "8c0422ae2a0f7308ab48c20b3f71adbe1bbb64db6def7ede0aa7638286980155" -> (none)
  • tunable.agentPane.debug.lostPromptReplay: true -> (none)
  • tunable.agentPane.debug.sideSessions: true -> (none)

Signed off on this commit by review (codex, router-review).

Merge receipt: merged as d32c886dd9e6 with these defaults changed, signed off by review (codex, router-review).

Regenerate the snapshot with python3 scripts/ci/defaults_guard.py snapshot.

Shipped in:

@teamleaderleo teamleaderleo added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 5, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex, router-review): SHIP at c1be714

Reviewer: codex gpt-6.1-sol xhigh, fast tier.

Follow-ups: 1. They land as checklist items in this PR's one follow-up tracking issue in this repo (Follow-ups: #N ..., label follow-up; add to an open one before filing, never one issue per finding), linking this receipt; the lane that opened the PR fixes them forward.

SHIP at c1be714

Visual verdict: no images; Leo tries the build

  • [P2] [follow-up] [category:ux] [finding:F1] [outcome:pending] No after screenshot is available for the changed side-question UI around webviews/src/agent-session/acpmux/App.tsx:9902; provide one for visual verification.

Follow-ups:

  • F1: Provide an after screenshot for visual verification.

cmux-bot[bot]
cmux-bot Bot previously approved these changes Nov 5, 2026

@cmux-bot cmux-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmux-bot approves c1be714: an independent review passed this exact head (router-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 5, 2026 10:30 Inactive
@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 5, 2026 10:30 Inactive
@cmux-bot
cmux-bot Bot dismissed their stale review November 5, 2026 10:33

A newer verdict blocks c257119 (no independent SHIP at the head).

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex, router-review): SHIP at af7f3dc

Reviewer: codex gpt-6-astra high, fast tier.

Follow-ups: 1. They land as checklist items in this PR's one follow-up tracking issue in this repo (Follow-ups: #N ..., label follow-up; add to an open one before filing, never one issue per finding), linking this receipt; the lane that opened the PR fixes them forward.

SHIP at af7f3dc
Visual verdict: no images; Leo tries the build

  • [P2] [follow-up] [category:ux] [finding:F1] [outcome:pending] No after screenshots are available (README.txt); provide them when the gallery lane is available for visual verification.

Follow-ups:

  • F1: provide after screenshots for the changed agent-pane UI.

@cmux-bot cmux-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmux-bot approves af7f3dc: an independent review passed this exact head (router-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

…g-rot-side-sessions

# Conflicts:
#	Packages/macOS/CmuxNext/Sources/CmuxNextAgentPane/AgentPaneTunables.swift
#	scripts/debug-labs-keys.json
#	webviews/src/agent-session/acpmux/App.tsx
@cursor

cursor Bot commented Nov 5, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex, router-review): SHIP at 5c5b8c7

Reviewer: codex gpt-6.1-sol xhigh, fast tier.

Follow-ups: 2. They land as checklist items in this PR's one follow-up tracking issue in this repo (Follow-ups: #N ..., label follow-up; add to an open one before filing, never one issue per finding), linking this receipt; the lane that opened the PR fixes them forward.

SHIP at 5c5b8c7

Visual verdict: no images; Leo tries the build

  • [P2] [follow-up] [category:docs] [finding:F1] [outcome:pending] Comments still describe daemon-closed prompts as dropped and /btw as having a kill switch (AgentPanePromptJournal.swift:17, App.tsx:9727); update them to reflect the new always-replay behavior.

  • [P2] [follow-up] [category:ux] [finding:F2] [outcome:pending] No after screenshots or gallery artifact were supplied for this UI-gating change; add visual evidence when available.

Follow-ups:

  • F1: update stale replay and kill-switch comments.
  • F2: provide UI capture when available.

@cmux-bot cmux-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmux-bot approves 5c5b8c7: an independent review passed this exact head (router-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

@teamleaderleo
teamleaderleo merged commit d32c886 into feat-cmux-next Nov 5, 2026
232 of 245 checks passed
@teamleaderleo
teamleaderleo deleted the lane/nx-flag-rot-side-sessions branch November 5, 2026 16:03
teamleaderleo added a commit that referenced this pull request Nov 5, 2026
The base removed the journal's size and entry caps (#33145) and the
byDaemon close (#32389, #36333): record drops its too-large branch and
trim, and the two write-race tests use a forget on another thread.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-a57dc6a4e0ad73610b3a

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 5c5b8c72 Deployed Nov 5, 2026 by teamleaderleo via wait for same-key tree publisher #116607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant