Repository navigation
cmux NEXT: delete the side sessions and lost prompt replay debug switches - #36333
Conversation
…ches /btw, /side and Ask a Side Question… stay always on, and a prompt a dropped connection lost always goes again on the next connection, as both did by default. Removes agentPane.debug.sideSessions (its header state field, the ActionContext.sideSessions bit 23 the palette action required, publishSideSessions) and agentPane.debug.lostPromptReplay (the journal's byDaemon branch only that switch reached), with the tests that only pinned the off paths. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-e9467c26845236490067
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Default changesThis pull request changes 4 defaults at
Signed off on this commit by Merge receipt: merged as Regenerate the snapshot with Shipped in:
|
|
Review (codex, router-review): SHIP at c1be714 Reviewer: codex gpt-6.1-sol xhigh, fast tier. Follow-ups: 1. They land as checklist items in this PR's one follow-up tracking issue in this repo ( SHIP at c1be714 Visual verdict: no images; Leo tries the build
Follow-ups:
|
A newer verdict blocks c257119 (no independent SHIP at the head).
…tReplay rows Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-e9467c26845236490067
|
Review (codex, router-review): SHIP at af7f3dc Reviewer: codex gpt-6-astra high, fast tier. Follow-ups: 1. They land as checklist items in this PR's one follow-up tracking issue in this repo ( SHIP at af7f3dc
Follow-ups:
|
…g-rot-side-sessions # Conflicts: # Packages/macOS/CmuxNext/Sources/CmuxNextAgentPane/AgentPaneTunables.swift # scripts/debug-labs-keys.json # webviews/src/agent-session/acpmux/App.tsx
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (codex, router-review): SHIP at 5c5b8c7 Reviewer: codex gpt-6.1-sol xhigh, fast tier. Follow-ups: 2. They land as checklist items in this PR's one follow-up tracking issue in this repo ( SHIP at 5c5b8c7 Visual verdict: no images; Leo tries the build
Follow-ups:
|
The base removed the journal's size and entry caps (#33145) and the byDaemon close (#32389, #36333): record drops its too-large branch and trim, and the two write-race tests use a forget on another thread. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-a57dc6a4e0ad73610b3a
Debug Settings loses two switches that have been on by default and never needed turning off: Side sessions (/btw) (
agentPane.debug.sideSessions) and Send again a prompt a dropped connection lost (agentPane.debug.lostPromptReplay). Nothing changes for anyone on the defaults:/btw,/sideand the palette's Ask a Side Question… are always offered in an agent chat (the Quick Composer still has no/btw, as before), and a prompt acpmux never took because its connection dropped always goes again on the next connection.Leo, 2026-11-05: "i meant can you do all of htem" (the ranked list whose move 10 is "Flip or delete Debug/Labs flags after 7 days (flips need Leo's OK)").
Leo, 2026-11-05 08:34Z: "rulebook cut and any flag flip only merge after you OK them. i ok them i know most are super stale/superseded/obsolete/can be condensed and consolidated"
What's removed
Side sessions:
AgentPaneHeaderState.sideSessionsand thesideSessionsfield it sent the page.ActionContext.sideSessions(bit 23, the highest bit, so no other bit moves), itskeyNamesandRegistryControlBridge.contextNamesentries, andActionRegistry.publishSideSessions.agentPane.sideQuestionnow requires only.agentPaneFocused.aside/sideSessions.tsand the header state'ssideSessions. The composer'sopensSideSessionsis now just!quick, so the Quick Composer's "Side questions are disabled" refusal stays.header-state-side-sessions.test.ts, the three "Side sessions off" browser tests inagent-pane-btw-side-session.test.ts(and the helpers only they used), andAgentPaneSideSessionsHeaderTests(replaced by one test that a focused chat offers Ask a Side Question…).Lost-prompt replay:
ended(byDaemon: false), so thebyDaemonparameter and the journal branch that dropped the page's prompts on a daemon close (reached only with the switch off) are gone.AgentPanePromptJournal.connectionEnded(owner:)now just releases the connection's holds, as it did by default.aPromptTheDaemonDroppedWithItsConnectionGoesAgainOnTheNextOne.schemas/defaults/cmux-next.jsondrops the four lines for these two keys.plans/cmux-next/swift-logic-classes.tsvdrops the deleted file's row.Takes back #25441: on purpose. This deletes the Side sessions (/btw) gate #25441 wired in (the
ActionContext.sideSessionsbit and its publishing). Ask a Side Question… stays in the palette, now gated only by agent-pane focus, since side sessions are on by default and the gate goes with Leo's OK above.Takes back #27091: on purpose. It deletes only the
/btwbrowser tests that covered the gate's off state, which can no longer happen.Changelog
Removed: the Debug Settings toggles "Side sessions (/btw)" and "Send again a prompt a dropped connection lost"; both behaviours stay on.
Observed / Not run
Observed:
python3 scripts/cmux-next/prepush-gate.py: no new violations.webviews:bun run checkpasses;scripts/web-lint.shpasses.bun test test/cmux-command-dispatch.test.ts test/composer-return-sends.test.tsx src/agent-session/acpmux/cmuxCommands.test.ts: 34 pass.CMUX_BROWSER_TESTS=1 bun test test/agent-pane-btw-side-session.test.ts test/cmux-command-dispatch.test.tsat c1be714 on CI (run 41999232584): 15 pass, including the ten real-Chromium /btw tests.Not run:
python3 scripts/ci/defaults_guard.py check-freshstill reports base drift from cmux NEXT: Live Web Reload on by default in every build, and live in Chromium too #36173 (webDev.override), which this PR leaves alone.Agent session: agent session
🤖 Generated with Claude Code