Repository navigation
NEXT: remove draft and unsent prompt size caps - #33145
Conversation
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-8436bc3dafead47b3ea8
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Stale: these images are of Gallery before/after for
States
Pick other states with a Passes: CI passes on CI passes on Written by web and size checks: green Shipped in:
|
|
Found 1 test failure on Blacksmith runners: Failure
|
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-8436bc3dafead47b3ea8
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-8436bc3dafead47b3ea8
Co-authored-by: Codex <199175422+chatgpt-codex-connector[bot]@users.noreply.github.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-8436bc3dafead47b3ea8
|
For the lane, this is the gallery health result from run 41609678735, which its host couldn't read. Shards 0 and 1 (jobs 125828512636 and 125828512702) give the same final line:
So the only red these two shards name is the Settings font picker's menu-fit, and it isn't red on base. Check whether this PR touches the picker's menu sizing, for example a removed max-height or length cap on that list. If it does, fix it here. If not, rerun those two shards once to rule out a flake before calling it a base red. |
|
Review (claude opus-5.5 subagent, medium): SHIP at 124183c Visual verdict: no UI in this diff. The Composer.tsx change removes the over-limit merge path, and the last gallery capture (a8fb438, whose webview code matches this head) rendered 16 states with 0 images differing. What I checked: the full diff from c39fe21. Every draft cap is gone end to end, and no other layer on the same path refuses or truncates the text. That covers acpmux None of the reds at this head belong to this PR:
Follow-ups:
|
The send-path cap guard (#33145) now covers backend/apps/api/src and flags the App Store registry limits: MAX_FILES and MAX_DECODED_BYTES for one app bundle, MAX_SUBMIT_BODY and MAX_DECIDE_BODY for the submit and review bodies. These bound app packages a reviewer reads, not a message, prompt or attachment send, so they get safe: entries. tests/test_send_path_caps.py passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The base removed the journal's size and entry caps (#33145) and the byDaemon close (#32389, #36333): record drops its too-large branch and trim, and the two write-race tests use a forget on another thread. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-a57dc6a4e0ad73610b3a
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
This is the first draft-path change in the limits audit.
This PR removes user-facing draft and unsent-prompt size/count caps across the draft path:
cmux-tui/crates/acpmux/src/hub/mod.rs:1965: removes the 1,000,000-character durable composer draft refusal.cmux-tui/crates/acpmux/src/hub/composers.rs:138: removes the 100,000-character surface draft refusal and 16-surface eviction; every surface draft remains available.cmux-tui/crates/cmux-tui-core/src/conversation_drafts.rs:53: removes the 16 KiB delta and 64 KiB fresh-text refusal; draft publication remains rate-limited. The matching 64 KiB catalog field restriction atcmux-tui/spec/resource-operations-v2.json:18563is also removed, with SDK catalog descriptors regenerated.Packages/macOS/CmuxNext/Sources/CmuxNextAgentPane/AgentPanePromptJournal.swift:119: removes the 8 MiB / 64-entry journal cap so restart recovery keeps large prompts and bursts.Packages/macOS/CmuxNext/Sources/CmuxNextAgentPane/AgentUnsentDrafts.swift:96: removes the 1,000,000-character unsent-draft cap.webviews/src/agent-session/acpmux/composerDraft.ts:50: removesMAX_DRAFT_CHARS; large saved and typed drafts merge and write whole.The existing surface-id validation, in-memory turn retention, and live draft-event rate limit remain operational bounds. Journal replay retains its existing 24-hour age policy.
Remaining work: draft values still travel inline through the existing 31–32 MiB RPC envelope, journal and draft-map writes still encode whole documents, and per-surface drafts remain memory-only. This PR removes the listed caps; it does not yet fulfill arbitrary-size blob-backed persistence. That remaining work is tracked in #33167 (owned by this PR's author).
Validation at
124183c144e951f2bd870ac8d5b70f77d7a7e6ec:CmuxNext: passed (receipt4b343a88f04f07a175e6a86e).960d3eb56b495b6b8d3d25256d2bf6b682fb10c0reproduced all remaining named gallery failures:changes-git-actions#include-newand#keyboardlayout shift (0.0570 versus 0.02985 baseline), andviewer-empty.path-picker#rtlmenu-label alignment (surface-007, 1.1 px). This run intentionally tested the base; its failure is attribution evidence, not a passing head test.🤖 Generated with Codex
Agent session: agent session