Repository navigation
cmux-next: pin CCmuxAppFFI to cmux-app-ffi-b24aac2c507d072ac3b5cf35fb3c3b93bd039acf - #35853
Merged
Merged
Conversation
manaflow-cmux-ffi-release
Bot
temporarily deployed
to
ci-routing-agent
November 4, 2026 19:59
Inactive
manaflow-cmux-ffi-release
Bot
temporarily deployed
to
ci-routing-agent
November 4, 2026 19:59
Inactive
manaflow-cmux-ffi-release
Bot
temporarily deployed
to
ci-routing-agent
November 4, 2026 19:59
Inactive
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
manaflow-cmux-ffi-release
Bot
temporarily deployed
to
ci-routing-agent
November 4, 2026 20:00
Inactive
manaflow-cmux-ffi-release
Bot
temporarily deployed
to
ci-routing-agent
November 4, 2026 20:00
Inactive
Contributor
|
Review (independent review subagent): SHIP at acccfaa What I checked (read-only; nothing was built or run locally):
Checks on this head:
|
lawrencecchen
added a commit
that referenced
this pull request
Nov 4, 2026
…he app's one input router (cmux_input_*) (#35875) * cmux-next: pin CCmuxAppFFI to cmux-app-ffi-b24aac2c507d072ac3b5cf35fb3c3b93bd039acf * R-INPUT S2b step B: every window's focus machine keeps its focus in the app's one input router (cmux_input_*) Step B of the FFI two-step (step A #35641, re-pin #35853): FocusMachine calls the input handle (`cmux_input_focus_*`, one window key per machine) instead of a per-window `cmux_focus_*` handle. The router is made once at the composition root (AppServices.focusInput, FocusInput in CmuxNextFocus) and given to each window's FocusCoordinator through WindowState. Pure refactor: the same requests and the same reply bytes (step A's corpus test), so every focus rule is unchanged. - FocusInput owns the CmuxInput handle (memory: the Mac's physical memory, which bounds the key lanes). Each machine opens a window under a key no other machine of that router had, and closes it when freed, so a window id the app reuses (a restored closed window) never meets the state of the machine it replaces, whichever is freed first. - A machine made with no input (tests, the journal replay) gets a router of its own. - FocusMachine's Close Tab aim calls move to FocusMachine+CloseAim.swift (A12 follow-up); the file shrinks from 467 to 458 lines. - FocusResponderClassifier.describe moves to the package as FocusEvent.Responder.debugName (CmuxNextApp: -10 lines). Tests: FocusInputSharedRouterTests: a machine in the shared router reduces exactly as a machine alone (state and effects after every event) while another window acts between its events; a new machine never meets a freed machine's focus; every request goes through the input handle (the close-focus policy, the Close Tab aim, the history, the remembered panes, the checkpoint; a checkpoint that does not decode is refused and leaves the state as it was: review notes of #35641). * FocusInput: the memory default is read in the init (a default argument may not name an internal import) * test(focus): the input-handle request test follows PaneCloseAim's documented order (the focus moves, then the frame shows) and compares each answer with a machine alone --------- Co-authored-by: manaflow-cmux-ffi-release[bot] <339941766+manaflow-cmux-ffi-release[bot]@users.noreply.github.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins CCmuxAppFFI to cmux-app-ffi-b24aac2c507d072ac3b5cf35fb3c3b93bd039acf (checksum
5aa92a5b76b173dce2a254ab9e437c0b086d3b4d07fd9754ab3d72b0f14b9481), published by run https://github.com/manaflow-ai/cmux/actions/runs/41899051904, which checked it with check-app-ffi-pin.sh --verify-release. A newer publish updates this branch.Changelog
none
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Updates the pinned
CCmuxAppFFIbinary target inCmuxNext/Package.swiftto the newercmux-app-ffi-b24aac2c507d072ac3b5cf35fb3c3b93bd039acfrelease, refreshing the download URL and checksum. No changelog entries; the newer publish supersedes this pin.Written for commit acccfaa. Summary will update on new commits.