Skip to content

ci: the backend secret-route guard covers the Cloud journey jobs; the production journey names its runner - #35717

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
lane/journey-prod-fixed-runner
Nov 4, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
lane/journey-prod-fixed-runner

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Two jobs that hold the production Cloud journey's secrets now stay on routes no variable can move.

#30761 and #32457 stay as they are: the other credentialed backend jobs keep their pool reads.

Observed / Not run

  • python3 tests/test_ci_runner_pool_reconcile.py SecretRouteBoundary: fails on base (journey-preview, journey-staging and journey-production missing), passes at this head.
  • At this head, these pass for cloud-journey-prod.yml: tests/test_ci_runner_set.py, test_ci_blacksmith_linux_failover.py, test_ci_no_single_size_pins.py and test_ci_fork_runner_routing.py. On base, the last three flag it, as does test_ci_upload_artifact_retention.py (retention-days 14, unchanged here). The remaining fork-routing, failover-size and guard-wiring failures are in other files and also fail on base.
  • Not run: the full fast-guard suite (CI runs it).

Agent session: agent session

🤖 Generated with Claude Code

journey-preview, journey-staging and journey-production (#35103) read secrets
and the cmux-next-cloud-journey environment, so they belong in
BACKEND_SECRET_JOBS; without them the guard's credentialed-set check fails and
their routes go unchecked. Their routes already have the bounded pool-read
shape. cloud-journey-prod.yml's job holds the production account, so it names
blacksmith-4vcpu-ubuntu-2404 literally, as on main (#35303).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-8b9c8964a6aea0b7e2bd
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 33e2ad7: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr35717 -f ref=lane/journey-prod-fixed-runner -f platform=macos -f backend_mode=local

Shipped in:

The feat-cmux-next push run https://github.com/manaflow-ai/cmux/actions/runs/41888017760 at dba5f44 failed: cmux-next checks (god files, concurrency, crash safety, l10n).
Those jobs last passed at 2955a17. This pull request is one of 5 merged since: #35756, #35717, #35759, #35521, #35641.
If the failure is in your change, fix forward on feat-cmux-next. Pull requests run only the tiers their paths reach (docs/ci/cmux-next-tiers.md); label a batch PR full-ci to run them all before merging.

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 4, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex, router-review): SHIP at 0947100

Reviewer: codex gpt-6-astra high, fast tier.

SHIP at 0947100

Visual verdict: no images; Leo tries the build

Focused route, runner-set, YAML, and policy checks pass.

Follow-ups: none

@cmux-bot cmux-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmux-bot approves 0947100: an independent review passed this exact head (router-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

…size

feat-cmux-next's runner guards refuse a literal single-size label (#32457) and
one with no overflow failover (#26439), and the old linux_2 route was reachable
outside manaflow-ai. The job now takes the owner fork branch, then the overflow
pool linux_16 or linux_8, the same pools backend.yml's credentialed jobs end in.
It no longer reads vars.LINUX_RUNNER, so that variable cannot move it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-8b9c8964a6aea0b7e2bd
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex, router-review): SHIP at 33e2ad7

Reviewer: codex gpt-6.1-sol xhigh, fast tier.

SHIP at 33e2ad7

Visual verdict: unchanged by this diff

Targeted routing and failover tests pass.

Follow-ups: none

@blacksmith-sh

blacksmith-sh Bot commented Nov 4, 2026

Copy link
Copy Markdown

Found 1 test failure on Blacksmith runners:

Failure

Test View Logs
test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt
epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)/
test_every_listed_hook_is_one_glaeda_released_with_the_check (main.SigningHooksInSt
epWithGlaedaTests.test_every_listed_hook_is_one_glaeda_released_with_the_check)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@cmux-bot cmux-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmux-bot approves 33e2ad7: an independent review passed this exact head (router-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

@teamleaderleo teamleaderleo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (gpt-6.1-sol): SHIP at 33e2ad7

Review (codex, router-review): SHIP at 33e2ad7

Reviewer: codex gpt-6.1-sol xhigh, fast tier (router-review job 29fd0a25c3384124ff5775d1a41bfd5f; comment #35717 (comment)).

Visual verdict: unchanged by this diff

Targeted routing and failover tests pass.

Follow-ups: none

@teamleaderleo
teamleaderleo merged commit fb231bd into feat-cmux-next Nov 4, 2026
186 of 189 checks passed
@teamleaderleo
teamleaderleo deleted the lane/journey-prod-fixed-runner branch November 4, 2026 18:24
teamleaderleo added a commit that referenced this pull request Nov 4, 2026
Each push that touches .github/, tests/ or scripts/ci/ judges the guard
profile at its tip, and 14 steps were red there. This clears nine (fork routing and the Blacksmith failover also need #35717):

- full clones: commandRules.ts runs no git; it lists `git clone`'s --depth
  as a flag to skip when it names a shown command (#35137).
- send-path caps: the dependency-cache timing record bound (#35237) and the
  local replica's file size bound (larger files read from the machine)
  refuse nothing a person sends; listed as safe.
- fleet rule lints: a sample machine name in a colour test fixture, and a
  plan table row naming SecItemCopyMatching in prose; listed as safe.
- pinned Xcode: drop the exemption for nightly.yml's launch-smoke-nightly,
  which no longer exists.
- macOS job class: nightly.yml's republish-nightly-next (#35588) only
  downloads and re-uploads a verified build: portable-checks.
- label events: the production cmux-vm jobs are gated first on
  github.ref == refs/heads/feat-cmux-next, which a pull_request event never
  has (its ref is refs/pull/N/merge); the guard now reads that, for
  pull_request only and only when no top-level || follows.
- fork routing: tail-production and sweep-orphans-production take the fork
  pull-request branch before vars.LINUX_RUNNER, like their siblings.
- supply chain: the jobs that mint the cmux-bot token (swift-test,
  generated-files, push-attribution, #35123) run in ci-routing-agent off
  pull requests, as macos-placement and compile-status do; tail-production
  reads its Cloudflare secrets in cmux-vm-production.
- upload retention: the production journey's step table keeps 3 days.


Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 33e2ad73 Deployed Nov 4, 2026 by teamleaderleo via cmux-tui tree preflight #112631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant