Skip to content

base red: background task tests expect the Bash call's description (from #34845) #35548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmux-bot merged 1 commit into from
Nov 4, 2026
Merged

base red: background task tests expect the Bash call's description (from #34845) #35548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions cmux-tui/crates/acpmux/tests/hub_integration/background_task.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,11 @@ async fn a_claude_background_shell_reports_how_it_ended() {
ends(&hub, &id),
vec![
json!({"sessionUpdate": "background_task_update", "taskId": "b1", "toolCallId": "toolu_bg1",
"command": "npm run dev", "state": "stopped", "reason": "Stopped by the agent"}),
"command": "npm run dev", "description": "Run npm run dev", "state": "stopped",
"reason": "Stopped by the agent"}),
json!({"sessionUpdate": "background_task_update", "taskId": "b2", "toolCallId": "toolu_bg2",
"command": "cargo test", "state": "completed", "summary": "Tests passed"}),
"command": "cargo test", "description": "Run cargo test", "state": "completed",
"summary": "Tests passed"}),
]
);
hub.shutdown_all().await;
Expand Down Expand Up @@ -104,7 +106,8 @@ async fn a_shell_moved_to_the_background_reports_how_it_ended() {
c.request(method::SESSION_PROMPT, prompt).await.unwrap();
let want = vec![json!({"sessionUpdate": "background_task_update", "taskId": "m1",
"toolCallId": "toolu_mv", "command": "npm run build",
"state": "completed", "summary": "Build finished"})];
"description": "Build", "state": "completed",
"summary": "Build finished"})];
assert_eq!(ends(&hub, &id), want);
hub.shutdown_all().await;
let _ = std::fs::remove_dir_all(&root);
Expand Down
8 changes: 4 additions & 4 deletions cmux-tui/crates/acpmux/tests/hub_integration/processes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,11 @@ async fn process_list_shows_how_each_shell_ended() {
list,
vec![
with(json!({"id": format!("{id}/b1"), "toolCallId": "toolu_bg1", "taskId": "b1",
"command": "npm run dev", "state": "killed", "reason": "agent",
"detail": "Stopped by the agent"})),
"command": "npm run dev", "description": "Run npm run dev", "state": "killed",
"reason": "agent", "detail": "Stopped by the agent"})),
with(json!({"id": format!("{id}/b2"), "toolCallId": "toolu_bg2", "taskId": "b2",
"command": "cargo test", "state": "exited", "reason": null,
"detail": "Tests passed"})),
"command": "cargo test", "description": "Run cargo test", "state": "exited",
"reason": null, "detail": "Tests passed"})),
]
);
let moved = chat(&mut c, "bg-moved").await;
Expand Down
Loading