Repository navigation
base red: background task tests expect the Bash call's description (from #34845) - #35548
Merged
cmux-bot[bot] merged 1 commit intoNov 4, 2026
Merged
Conversation
…Bash call's description #34845 sends a background shell's `description` (Claude's Bash `description`) in its `background_task_update` and keeps it on the process row (docs/background-processes.md), so a client that never loaded the call still names it. The hub_integration background_task and processes tests still expected the rows without it and went red on feat; they now expect the fake's descriptions ("Run npm run dev", "Run cargo test", "Build").
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
Contributor
Author
|
Review (independent review subagent, Claude): SHIP at 64b075b Read the diff, the culprit change and the covered code at origin/feat-cmux-next: the fix is at the root cause per the culprit's stated intent and keeps the test's purpose (no skip, retry, longer wait or loosened assert). No build or test was run by the reviewer; the fleet results are in the description. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Base red on
feat-cmux-next(fleet full cmux-tui test run on Linux, base b657cec jobdd03fbf83bb438cb229fcabd, tip 78ee0e1 job3dc68e186d0f4b66de9f6179):acpmux::hub_integration fork_through::background_task::a_claude_background_shell_reports_how_it_endedacpmux::hub_integration fork_through::background_task::a_shell_moved_to_the_background_reports_how_it_endedacpmux::hub_integration fork_through::processes::process_list_shows_how_each_shell_endedAll three fail with one extra field:
"description": "Run npm run dev"(and "Run cargo test", "Build"). #34845 intends this: a background shell'sbackground_task_updateand its process row now carry the Bash call'sdescription(docs/background-processes.md), so a client that never loaded the call still names it. The tests were not updated. They now expect the stand-in's descriptions. Test-only change.Testing
Focused command:
cmux-ci run --class light --script scripts/ci/cmux-tui-rust-check.sh --os linux --arg test --ref SHA.3dc68e186d0f4b66de9f6179): the three tests fail.2d38678b15bcd3b5d083b4e3): the three pass; the rest of the red list is the other base reds of this batch.fork_through::background_task(job9e6e02995944d0971595ae6c): 6 of 6 pass.allmode at the head (job0fb467b16ab97a4d78bdb370): clippy pass; fmt red only onacpmux/src/claude_stdio/inbound.rs:287, which is red the same way at the tip (job74f9ed3184f1aaecf528b4c3) and not in this diff.python3 scripts/cmux-next/prepush-gate.py: no new violations.Observed / Not run
Changelog
none
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Updates the
hub_integrationbackground task and process tests to expect the newdescriptionfield that #34845 added to background task updates and process rows.Written for commit 64b075b. Summary will update on new commits.