Skip to content

base red: background task tests expect the Bash call's description (from #34845) - #35548

Merged
cmux-bot[bot] merged 1 commit into
feat-cmux-nextfrom
fix/acpmux-bg-task-tests-description
Nov 4, 2026
Merged

cmux-bot[bot] merged 1 commit into
feat-cmux-nextfrom
fix/acpmux-bg-task-tests-description

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Base red on feat-cmux-next (fleet full cmux-tui test run on Linux, base b657cec job dd03fbf83bb438cb229fcabd, tip 78ee0e1 job 3dc68e186d0f4b66de9f6179):

  • acpmux::hub_integration fork_through::background_task::a_claude_background_shell_reports_how_it_ended
  • acpmux::hub_integration fork_through::background_task::a_shell_moved_to_the_background_reports_how_it_ended
  • acpmux::hub_integration fork_through::processes::process_list_shows_how_each_shell_ended

All three fail with one extra field: "description": "Run npm run dev" (and "Run cargo test", "Build"). #34845 intends this: a background shell's background_task_update and its process row now carry the Bash call's description (docs/background-processes.md), so a client that never loaded the call still names it. The tests were not updated. They now expect the stand-in's descriptions. Test-only change.

Testing

Focused command: cmux-ci run --class light --script scripts/ci/cmux-tui-rust-check.sh --os linux --arg test --ref SHA.

  • Base (tip, job 3dc68e186d0f4b66de9f6179): the three tests fail.
  • Head 64b075b (job 2d38678b15bcd3b5d083b4e3): the three pass; the rest of the red list is the other base reds of this batch.
  • macOS head, filter fork_through::background_task (job 9e6e02995944d0971595ae6c): 6 of 6 pass.
  • Linux all mode at the head (job 0fb467b16ab97a4d78bdb370): clippy pass; fmt red only on acpmux/src/claude_stdio/inbound.rs:287, which is red the same way at the tip (job 74f9ed3184f1aaecf528b4c3) and not in this diff.
  • python3 scripts/cmux-next/prepush-gate.py: no new violations.

Observed / Not run

  • Observed: the results above.
  • Not run: the processes test alone on macOS (the background_task filter ran there).

Changelog

none


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Updates the hub_integration background task and process tests to expect the new description field that #34845 added to background task updates and process rows.

  • Test-only change; the assertions now include the Bash call's description so a client that never loaded the call still names it.

Written for commit 64b075b. Summary will update on new commits.

View guided diff Turn on auto-fix

…Bash call's description

#34845 sends a background shell's `description` (Claude's Bash `description`) in its
`background_task_update` and keeps it on the process row (docs/background-processes.md), so a
client that never loaded the call still names it. The hub_integration background_task and
processes tests still expected the rows without it and went red on feat; they now expect the
fake's descriptions ("Run npm run dev", "Run cargo test", "Build").
@lawrencecchen lawrencecchen added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 64b075b: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr35548 -f ref=fix/acpmux-bg-task-tests-description -f platform=macos -f backend_mode=local

Shipped in:

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Review (independent review subagent, Claude): SHIP at 64b075b

Read the diff, the culprit change and the covered code at origin/feat-cmux-next: the fix is at the root cause per the culprit's stated intent and keeps the test's purpose (no skip, retry, longer wait or loosened assert). No build or test was run by the reviewer; the fleet results are in the description.

@lawrencecchen lawrencecchen added the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Nov 4, 2026
@cmux-bot
cmux-bot Bot merged commit ebe1bc7 into feat-cmux-next Nov 4, 2026
228 of 245 checks passed
@cmux-bot
cmux-bot Bot deleted the fix/acpmux-bg-task-tests-description branch November 4, 2026 15:46

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 64b075b7 Deployed Nov 4, 2026 by lawrencecchen via cmux-tui tree preflight #112095
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant