Skip to content

Agent pane: remove the recap card from the bottom composer area - #34653

Merged
teamleaderleo merged 6 commits into
feat-cmux-nextfrom
lane/composer-recap-removal
Nov 5, 2026
Merged

teamleaderleo merged 6 commits into
feat-cmux-nextfrom
lane/composer-recap-removal

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Leo, 2026-11-04: "we have this removed in next build yet? this should NOT be in the bottom composer area..."

Leo-ask: ask-6cce056e2b ask-a6c65fbf4b
Leo-Ask-Trace: ask-6cce056e2b,ask-a6c65fbf4b

Takes back #32669: Leo asked for the recap card out of the bottom composer area; this removes the card's place on the composer card's edges (its gallery variant and edge check) that #32669 added.
Takes back #33269: only its lines in recap.ts, the recap card's own reading; the next-step card #33269 added stays and draws the same ask under the answer.
Takes back #34360: only its wrap-up guard in recap.ts, which existed to hide the recap card; with the card gone the file goes, and the wrap-up next-step box from #34360 stays.

What changes

A removal. The recap card (RecapCard.tsx, from #21665, put on the composer card's edges by #32669) drew the last turn's closing question and its Yes / Not now above the composer when the agent.sessionStatus Debug toggle was on. The transcript's next-step card (NextStepCard.tsx, #33269) already draws a tagged ask under the answer, so the composer card is gone:

  • RecapCard.tsx, its reading recap.ts, its gallery entry and the bottom stack's recap variant, its styles, and its four strings (recap.label, recap.yesAction, recap.dismiss, recap.sendFailed). recap.yes and recap.notNow stay; the next-step card uses them.
  • The composer's onShellChange prop, which only told the card to drop its key hint.
  • Tests: recap-card.test.ts, agent-pane-recap-card.test.ts, the recap edge check in agent-pane-bottom-stack-edges.test.ts and one recapFrom case.
  • Merged feat-cmux-next: recap.ts stays deleted (Agent pane: agents end a turn with a wrap_up next-step box (recap, question, answer buttons) #34360 had edited it); agent-pane-wrap-up-card.test.tsx drops its two recapFrom checks. addressThread in App.tsx, whose only caller was the card, goes too, as does an unused summary import in the bottom-stack gallery, and the design-token baseline shrinks by the card's styles.

Kept: ⌘↩ on an empty prompt still answers a waiting next-step card; the live plan card behind the same toggle; the "While you were away" session recap row in the transcript (#33162).

Spec: design/composer.md (nothing above the composer card that the transcript already draws).

Risk: low; deletes UI and adds only the lines that keep the tree compiling.

Changelog

Removed: the recap card above the agent pane's composer.

Agent session: agent session

🤖 Generated with Claude Code

Leo, 2026-11-04: "we have this removed in next build yet? this should NOT be
in the bottom composer area..."

The recap card (RecapCard.tsx, behind the agent.sessionStatus Debug toggle)
drew a turn's closing question and its yes above the composer. The transcript's
next-step card (NextStepCard.tsx) already draws a tagged ask under the answer,
so the card, its reading (recap.ts), styles, strings, gallery entry and variant
and tests go. ⌘↩ on an empty prompt still answers a waiting next-step card. The
live plan card behind the same toggle and the session recap row are untouched.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-e19c091b5676fc54dd16
@teamleaderleo teamleaderleo added the leo-named-fix An obvious fix to something Leo named: lands on push, review runs in parallel label Nov 4, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent claude-opus-5-5 medium): SHIP at 04ebc10

Visual verdict: the recap card above the composer is gone; no other UI changes.
Checked: no reference to the deleted modules, classes, props or strings remains (webviews, scripts, .github, Swift, Rust); ⌘↩ still answers a waiting next-step card; the plan card and the session recap row are untouched; Localizable.xcstrings parses.

Follow-ups:

  • [follow-up] scripts/gallery-matrix/invariant-baseline.json and shift-baseline.json still list agent-pane.recap-card#* rows (inert).
  • [follow-up] recap.yes / recap.notNow translator comments still cite RecapCard.tsx.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 69e4c03: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr34653 -f ref=lane/composer-recap-removal -f platform=macos -f backend_mode=local

Gallery before/after for 69e4c03: 16 states rendered, 4 images differ, 2397 more touched states not rendered. Images are in the run's artifact, not on this public PR; the independent review of this head reads them on its own, so the PR needs no hand-made screenshots of these states.

gh run download 41922728848 -R manaflow-ai/cmux -n gallery-advisory-34653-69e4c0327f7b95ce24fb567398f4f49b36c66b83 (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.background-activity/duration-columns Apple System Colors Light unchanged 0% own summary.css
agent-pane.background-activity/duration-columns Apple System Colors unchanged 0% own summary.css
agent-pane.background-activity/pinned-live-tail-light Apple System Colors Light unchanged 0% own summary.css
agent-pane.background-activity/pinned-live-tail-light Apple System Colors unchanged 0% own summary.css
agent-pane.background-activity/pinned-live-tail-dark Apple System Colors Light unchanged 0% own summary.css
agent-pane.background-activity/pinned-live-tail-dark Apple System Colors unchanged 0% own summary.css
agent-pane.background-activity/after-latest-message-light Apple System Colors Light unchanged 0% own summary.css
agent-pane.background-activity/after-latest-message-light Apple System Colors unchanged 0% own summary.css
agent-pane.background-activity/after-latest-message-dark Apple System Colors Light unchanged 0% own summary.css
agent-pane.background-activity/after-latest-message-dark Apple System Colors unchanged 0% own summary.css
agent-pane.background-activity/compact-pill-light Apple System Colors Light unchanged 0% own summary.css
agent-pane.background-activity/compact-pill-light Apple System Colors unchanged 0% own summary.css
agent-pane.background-activity/compact-pill-dark Apple System Colors Light unchanged 0% own summary.css
agent-pane.background-activity/compact-pill-dark Apple System Colors unchanged 0% own summary.css
agent-pane.background-activity/side-panel-light Apple System Colors Light unchanged 0% own summary.css
agent-pane.background-activity/side-panel-light Apple System Colors unchanged 0% own summary.css
agent-pane.bottom-stack-styles/recap Apple System Colors Light removed 0% own bottomStackStyles.gallery.ts
agent-pane.bottom-stack-styles/recap Apple System Colors removed 0% own bottomStackStyles.gallery.ts
agent-pane.bottom-stack-styles/collapsed Apple System Colors Light unchanged 0% own bottomStackStyles.gallery.ts
agent-pane.bottom-stack-styles/collapsed Apple System Colors unchanged 0% own bottomStackStyles.gallery.ts
agent-pane.bottom-stack-styles/no-tray Apple System Colors Light unchanged 0% own bottomStackStyles.gallery.ts
agent-pane.bottom-stack-styles/no-tray Apple System Colors unchanged 0% own bottomStackStyles.gallery.ts
agent-pane.bottom-stack-styles/expanded Apple System Colors Light changed 0% own bottomStackStyles.gallery.ts
agent-pane.bottom-stack-styles/expanded Apple System Colors changed 0% own bottomStackStyles.gallery.ts
agent-pane.bottom-stack-styles/cards Apple System Colors Light unchanged 0% own bottomStackStyles.gallery.ts
agent-pane.bottom-stack-styles/cards Apple System Colors unchanged 0% own bottomStackStyles.gallery.ts
agent-pane.chat-width/standard Apple System Colors Light unchanged 0% own App.tsx
agent-pane.chat-width/standard Apple System Colors unchanged 0% own App.tsx
agent-pane.chat-width/wide Apple System Colors Light unchanged 0% own App.tsx
agent-pane.chat-width/wide Apple System Colors unchanged 0% own App.tsx
agent-pane.chat-width/wide-blocks Apple System Colors Light unchanged 0% own App.tsx
agent-pane.chat-width/wide-blocks Apple System Colors unchanged 0% own App.tsx

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

Passes: CI passes on 69e4c0327f.

CI passes on 69e4c0327f (run 41922729096 attempt 1).

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

web and size checks: green

Shipped in:

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 4, 2026
@blacksmith-sh

blacksmith-sh Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Found 4 test failures on Blacksmith runners:

Failures

Test View Logs
---/--- View Logs
test/composer-one-row-layout.test.ts/composer-one-row-layout.test View Logs
test/composer-one-row-layout.test.ts/composer-one-row-layout.test View Logs
test/composer-one-row-layout.test.ts/composer-one-row-layout.test View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 4, 2026 03:59 Inactive
@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 4, 2026 04:04 Inactive
@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 4, 2026 06:33 Inactive
@cmux-bot
cmux-bot Bot temporarily deployed to ci-routing-agent November 4, 2026 06:47 Inactive
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Awareness note from an agent lane that does not own this PR; it is not a review or a request to take the PR over.


This PR is CONFLICTING with feat-cmux-next. Resolution (checked locally on another lane, not pushed since the owning session is live):

  1. Merge origin/feat-cmux-next: one conflict, recap.ts (modify/delete from Agent pane: agents end a turn with a wrap_up next-step box (recap, question, answer buttons) #34360). Keep it deleted (git rm).
  2. Agent pane: agents end a turn with a wrap_up next-step box (recap, question, answer buttons) #34360 added webviews/test/agent-pane-wrap-up-card.test.tsx, which imports recapFrom from ../recap. Drop that import, delete the test "a code-mode wrap-up also sends the recap card aside", and in "goes before a tagged ask in the prose, and the recap card steps aside" drop the last three lines (the asking recapFrom check) and the ", and the recap card steps aside" from its name.
  3. Optional (your reviewer's follow-ups): drop the "agent-pane.recap-card#*" rows in scripts/gallery-matrix/invariant-baseline.json and shift-baseline.json; point the recap.yes / recap.notNow translator comments at NextStepCard.tsx.
    After that, grep finds no remaining RecapCard/recapFrom/onShellChange refs. Leo's SLA on this ask (first said 02:22Z) is long past; please land it now.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high, sweep, via the review router; full diff from merge base 291f606 to this head): SHIP at 9846002

No P1/P2 findings.

@teamleaderleo

teamleaderleo commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · took over from an earlier session · session

teamleaderleo and others added 2 commits November 4, 2026 21:41
Keeps recap.ts deleted (modified on base by #34360) and drops the
RecapCard import from App.tsx; agent-pane-wrap-up-card.test.tsx no
longer checks the removed recapFrom.

Leo-Ask-Trace: ask-6cce056e2b,ask-a6c65fbf4b

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-b1ae110ae64e97a617f4
…left

Leo-Ask-Trace: ask-6cce056e2b,ask-a6c65fbf4b

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-b1ae110ae64e97a617f4
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex, router-review): SHIP at 5a66919

Reviewer: codex gpt-6-astra high, fast tier.

SHIP at 5a66919
Visual verdict: no images; Leo tries the build

Checked for dangling imports, references, localization keys, and composer key-handling regressions.

Follow-ups: none

…removal left unused

Leo-Ask-Trace: ask-6cce056e2b,ask-a6c65fbf4b

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-b1ae110ae64e97a617f4
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex, router-review): SHIP at 69e4c03

Reviewer: codex gpt-6.1-sol xhigh, fast tier.

SHIP at 69e4c03

Visual verdict: no images; Leo tries the build

No correctness findings.

Follow-ups: none

@cmux-bot cmux-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmux-bot approves 69e4c03: an independent review passed this exact head (router-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

health (2) / next-autoland / verdict red at 69e4c03: agent-pane.composer-context#started-browse-error-tray ("waitFor did not hold"). Not this PR's red: the PR's own diff (three-dot) touches nothing in the folder chooser, and replaying that entry (both variants, both themes) at this exact head on a CI box rendered it 3 runs of 3 with 0 broken: https://github.com/manaflow-ai/cmux/actions/runs/41927498409 (tested_sha 69e4c03). Reading it as a runner-load flake; merging on the SHIP at this head.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owner hand-off: SHIP at 69e4c03, risk evidence green, merge freeze clear, no red of its own (health flake replayed green above). The broker's land tool fails with ModuleNotFoundError from this lane VM, so this is labelled ready-to-land at that head for the lander. Leo-ask: ask-6cce056e2b ask-a6c65fbf4b

@teamleaderleo
teamleaderleo merged commit 0234436 into feat-cmux-next Nov 5, 2026
230 of 234 checks passed
@teamleaderleo
teamleaderleo deleted the lane/composer-recap-removal branch November 5, 2026 11:07

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 69e4c032 Deployed Nov 4, 2026 by teamleaderleo via cmux-tui tree preflight #113248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

leo-named-fix An obvious fix to something Leo named: lands on push, review runs in parallel risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant