Skip to content

Agent pane: the recap card and the host's line on the composer card's edges (carries #28587) - #32669

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
lane/bottom-stack-recap-hostline-edges
Nov 3, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
lane/bottom-stack-recap-hostline-edges

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Carries the part of #28587 that base doesn't cover yet. Leo, 2026-10-30, on the agent pane's bottom stack:

"the stupid right indent misalignemnt"

#28587's goal: every part over the composer shares the composer box's left and right edges at every width (including the narrow outset and --cv-inset-end) and the box's radius token. Base has since done this for the running tray (#28533, #29264, #29885, #31424: --acpmux-tray-outset, the radius token, the joined glass) and removed the PR chips (#29614), so #28587's branch no longer merges. What it still carried of its own was the recap card and the host's line; this PR ports only those onto base's design.

What changed

  • bottomStack.css: .acpmux-dock defines --acpmux-stack-outset, the composer's 8px narrow outset (same 297.5px clamp the tray uses), for the other parts on the card's edges. The percentage resolves at the part using it.
  • Recap card (summary.css): right edge takes --cv-inset-end (it used --cv-inset on both sides, so it stood inside the column while the computer use preview pulls the column's end in), both edges take the narrow outset, and the card takes --acpmux-composer-radius (fallback 11px, as the tray) instead of a fixed 12px.
  • Host's line (styles.css): the same edges.
  • Vertical spacing is unchanged: the recap's 6px and the host line's 8px under them stay. Joining the recap to the composer as one glass, as the tray does, is a separate design step.
  • Test: agent-pane.bottom-stack-styles gains a recap variant (sessionStatus on, a turn ending on a question); test/agent-pane-bottom-stack-edges.test.ts checks the recap card's left/right against the composer card to 1px at 1100, 420 and 320px (320 puts the composer under its narrow outset).

Spec: design/running-tray.md (bottom stack); no settled design changes.

🤖 Generated with Claude Code

Agent session: agent session


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Aligns the recap card and the host's line with the composer card's left and right edges at every width in the agent pane's bottom stack, completing the part of #28587 that base's bottom stack work hadn't carried over.

  • Adds --acpmux-stack-outset on .acpmux-dock (the composer's 8px narrow outset) so both parts follow the composer's edges the same way the running tray does.
  • The recap card now takes --cv-inset-end on the right edge instead of --cv-inset on both sides, and its corner uses --acpmux-composer-radius (11px fallback) instead of a fixed 12px.
  • Vertical spacing is unchanged: the recap's 6px and the host line's 8px padding stay.
  • Adds a recap gallery variant and a test checking the recap card's edges against the composer's to 1px at 1100, 420, and 320px widths.

Written for commit afe0ad8. Summary will update on new commits.

View guided diff Turn on auto-fix

… edges

The recap card and the host's line now take --cv-inset-end on the right and
the composer's 8px narrow outset, as the running tray already does, and the
recap card takes the composer's radius token. Carries the still-needed part
of #28587 onto base's bottom stack.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-627034dbf10a04318c5c
@cursor

cursor Bot commented Nov 2, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review afe0ad8: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr32669 -f ref=lane/bottom-stack-recap-hostline-edges -f platform=macos -f backend_mode=local

Gallery before/after for afe0ad8: 16 states rendered, 4 images differ, 2005 more touched states not rendered. Images are in the run's artifact, not on this public PR; the independent review of this head reads them on its own, so the PR needs no hand-made screenshots of these states.

gh run download 41548799909 -R manaflow-ai/cmux -n gallery-advisory-32669-afe0ad8549a7f6aa87c69e1e386c46bafb5dc044 (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.access-offer/turn-no-credits Apple System Colors Light unchanged 0% own styles.css
agent-pane.access-offer/turn-no-credits Apple System Colors unchanged 0% own styles.css
agent-pane.access-offer/turn-low-credits Apple System Colors Light unchanged 0% own styles.css
agent-pane.access-offer/turn-low-credits Apple System Colors unchanged 0% own styles.css
agent-pane.access-offer/turn-no-offer Apple System Colors Light unchanged 0% own styles.css
agent-pane.access-offer/turn-no-offer Apple System Colors unchanged 0% own styles.css
agent-pane.activity-line-looks/none Apple System Colors Light unchanged 0% own styles.css
agent-pane.activity-line-looks/none Apple System Colors unchanged 0% own styles.css
agent-pane.activity-line-looks/spinner Apple System Colors changed 0.08% own styles.css
agent-pane.activity-line-looks/spinner Apple System Colors Light changed 0.0701% own styles.css
agent-pane.activity-line-looks/kind Apple System Colors Light changed 0.0403% own styles.css
agent-pane.activity-line-looks/kind Apple System Colors changed 0.0347% own styles.css
agent-pane.activity-line-looks/aligned Apple System Colors Light unchanged 0% own styles.css
agent-pane.activity-line-looks/aligned Apple System Colors unchanged 0% own styles.css
agent-pane.add-project-panel/environment Apple System Colors Light unchanged 0% own styles.css
agent-pane.add-project-panel/environment Apple System Colors unchanged 0% own styles.css
agent-pane.add-project-panel/sources Apple System Colors Light unchanged 0% own styles.css
agent-pane.add-project-panel/sources Apple System Colors unchanged 0% own styles.css
agent-pane.add-project-panel/directory Apple System Colors Light unchanged 0% own styles.css
agent-pane.add-project-panel/directory Apple System Colors unchanged 0% own styles.css
agent-pane.add-project-panel/keyboard Apple System Colors Light unchanged 0% own styles.css
agent-pane.add-project-panel/keyboard Apple System Colors unchanged 0% own styles.css
agent-pane.add-project-panel/browse-error Apple System Colors Light unchanged 0% own styles.css
agent-pane.add-project-panel/browse-error Apple System Colors unchanged 0% own styles.css
agent-pane.all-chats-list/page-failed Apple System Colors Light unchanged 0% own styles.css
agent-pane.all-chats-list/page-failed Apple System Colors unchanged 0% own styles.css
agent-pane.all-chats-list/page-recovered Apple System Colors Light unchanged 0% own styles.css
agent-pane.all-chats-list/page-recovered Apple System Colors unchanged 0% own styles.css
agent-pane.all-chats-list/long-values Apple System Colors Light unchanged 0% own styles.css
agent-pane.all-chats-list/long-values Apple System Colors unchanged 0% own styles.css
agent-pane.all-chats-list/leads Apple System Colors Light unchanged 0% own styles.css
agent-pane.all-chats-list/leads Apple System Colors unchanged 0% own styles.css

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

Unclear: web / react-apps-check failed: no known signature; failed step: Check webview test shards. CI was cancelled before it finished.

CI stopped on afe0ad8549 (run 41548799990 attempt 1): 1 unknown.

Job Verdict Why
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Not re-run automatically: web / react-apps-check is not a machine failure.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules
red: web / react-apps-check; a job it gathers ended without a verdict (web / react-apps-check (2): cancelled); do not merge until green; see lane-rules

Shipped in:

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 2, 2026
…t keeps base's baseline

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-627034dbf10a04318c5c
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high, sweep, via the review router; full diff from merge base e467c24 to this head): SHIP at afe0ad8

No P1/P2 findings.

@teamleaderleo
teamleaderleo merged commit 336509d into feat-cmux-next Nov 3, 2026
184 of 189 checks passed
@teamleaderleo
teamleaderleo deleted the lane/bottom-stack-recap-hostline-edges branch November 3, 2026 00:46

This branch was previously deployed

1 inactive deployment
ci-routing-agent — afe0ad85 Deployed Nov 2, 2026 by teamleaderleo via cmux-tui tree preflight #103024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant