Repository navigation
base red: cmux-tui automation clippy and Windows workflow help - #34476
Merged
lawrencecchen merged 1 commit intoNov 4, 2026
Merged
Conversation
feat-cmux-next fails clippy -D warnings in cli/automation.rs (type_complexity) and cli/automation/teleport.rs (manual_is_multiple_of), and the Windows cargo check on cli.rs, whose workflow help arm names a #[cfg(unix)] module. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
Contributor
|
Review (independent subagent): SHIP at 0ef69d1 I read the diff and the full changed functions at the head. I did not compile or run tests on my machine. Windows fix (
Clippy fixes
Not a blocker (follow-up only)
CI on the head
|
austinywang
temporarily deployed
to
sentry-dsyms
November 4, 2026 01:26 — with
GitHub Actions
Inactive
austinywang
added a commit
that referenced
this pull request
Nov 4, 2026
Picks up #34476 (Windows workflow help and automation clippy). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears three base reds on
feat-cmux-nextthat fail every PR touching cmux-tui. Found while landing #25768.clippy (changed cmux-tui packages):cli/automation.rsOut::capturedtripsclippy::type_complexity. The fix names the captured resultCapturedResult.cli/automation/teleport.rsevery_as_crontripsmanual_is_multiple_of. The fix usesseconds.is_multiple_of(60).cargo check (x86_64-pc-windows-gnu):cli.rshelp's"workflow"arm namesworkflow::HELP, butmod workflowis#[cfg(unix)]. The arm now carries the same cfg, so on Windowshelp workflowfalls back to the root help, like other unix-only scopes.Verified on rbx:
cargo fmt --all --check,cargo clippy -p cmux-tui --all-targets --locked -- -D warnings, and the CI commandcargo check --locked --target x86_64-pc-windows-gnu -p cmux-tui-core -p cmux-tui -p acpmuxall pass. Example base failures: https://github.com/manaflow-ai/cmux/actions/runs/41749457187/job/126310631936 and https://github.com/manaflow-ai/cmux/actions/runs/41749457206/job/126310631777.Changelog: none (CI-only).
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Clears three base CI failures on
feat-cmux-nextthat currently fail every PR touchingcmux-tui.CapturedResultincli/automation.rsand usingseconds.is_multiple_of(60)inteleport.rs.#[cfg(unix)]to the"workflow"help arm incli.rs, so on Windowshelp workflownow falls back to root help like other unix-only scopes.Written for commit 0ef69d1. Summary will update on new commits.