Skip to content

base red: cmux-tui automation clippy and Windows workflow help - #34476

Merged
lawrencecchen merged 1 commit into
feat-cmux-nextfrom
fix/cmux-tui-automation-windows-base-reds
Nov 4, 2026
Merged

lawrencecchen merged 1 commit into
feat-cmux-nextfrom
fix/cmux-tui-automation-windows-base-reds

Conversation

@austinywang

@austinywang austinywang commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Clears three base reds on feat-cmux-next that fail every PR touching cmux-tui. Found while landing #25768.

  • clippy (changed cmux-tui packages): cli/automation.rs Out::captured trips clippy::type_complexity. The fix names the captured result CapturedResult. cli/automation/teleport.rs every_as_cron trips manual_is_multiple_of. The fix uses seconds.is_multiple_of(60).
  • cargo check (x86_64-pc-windows-gnu): cli.rs help's "workflow" arm names workflow::HELP, but mod workflow is #[cfg(unix)]. The arm now carries the same cfg, so on Windows help workflow falls back to the root help, like other unix-only scopes.

Verified on rbx: cargo fmt --all --check, cargo clippy -p cmux-tui --all-targets --locked -- -D warnings, and the CI command cargo check --locked --target x86_64-pc-windows-gnu -p cmux-tui-core -p cmux-tui -p acpmux all pass. Example base failures: https://github.com/manaflow-ai/cmux/actions/runs/41749457187/job/126310631936 and https://github.com/manaflow-ai/cmux/actions/runs/41749457206/job/126310631777.

Changelog: none (CI-only).

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Clears three base CI failures on feat-cmux-next that currently fail every PR touching cmux-tui.

  • Fixes two clippy warnings by naming the captured result type as CapturedResult in cli/automation.rs and using seconds.is_multiple_of(60) in teleport.rs.
  • Adds the existing #[cfg(unix)] to the "workflow" help arm in cli.rs, so on Windows help workflow now falls back to root help like other unix-only scopes.

Written for commit 0ef69d1. Summary will update on new commits.

View guided diff Turn on auto-fix

feat-cmux-next fails clippy -D warnings in cli/automation.rs (type_complexity)
and cli/automation/teleport.rs (manual_is_multiple_of), and the Windows cargo
check on cli.rs, whose workflow help arm names a #[cfg(unix)] module.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 0ef69d1: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr34476 -f ref=fix/cmux-tui-automation-windows-base-reds -f platform=macos -f backend_mode=local

Shipped in:

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 4, 2026
@lawrencecchen

Copy link
Copy Markdown
Contributor

Review (independent subagent): SHIP at 0ef69d1

I read the diff and the full changed functions at the head. I did not compile or run tests on my machine.

Windows fix (cli.rs, scope_help_for)

  • The new #[cfg(unix)] on the "workflow" arm agrees with #[cfg(unix)] mod workflow; (line 133).
  • On Unix the match is the same as before. help workflow still shows workflow::HELP.
  • On Windows, help workflow goes to the _ arm and shows the root help. The workflow commands do not run on Windows, so this is correct.
  • I searched all workflow:: uses in cmux-tui/crates/cmux-tui/src that are not test code. The only uses outside cli/workflow/ are cli.rs:516 (in the #[cfg(unix)] dispatch chain), cli/mcp.rs and cli/mcp/code_mode.rs (mod mcp is #[cfg(unix)], line 109). No use is left without a guard.

Clippy fixes

  • type CapturedResult = Result<Value, (Value, bool)> is the same type as the old inline type. Behavior does not change.
  • every_as_cron: !seconds.is_multiple_of(60) is the same as seconds % 60 != 0. The divisor is the constant 60, so the zero-divisor case of is_multiple_of cannot occur. Also, seconds == 0 returns first, as before. u64::is_multiple_of is stable since Rust 1.87. The workspace rust-version is 1.91 and the toolchain is 1.95.0. Other crates in cmux-tui already use it.

Not a blocker (follow-up only)

  • The test help_workflow_shows_the_workflow_usage_not_the_root_help in cli/tests.rs (line 531) has no #[cfg(unix)]. On a Windows cargo test run it will fail, because scope_help_for("workflow") now gives the root help. The Windows CI step is cargo check and it does not run tests, so this PR is not affected. cmux-tui: compile the workflow help arm on Unix only #34469 adds this gate. It can follow as a small separate change if a Windows test lane needs it.

CI on the head

  • cargo check (x86_64-pc-windows-gnu): pass.
  • clippy (changed cmux-tui packages): pass. rustfmt: pass.
  • No check failed. Some checks are still pending (cross builds, cmux-next fast tier (cargo), autofix repairs, nightly guard). The PR does not cause a red.

@lawrencecchen lawrencecchen added the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Nov 4, 2026
@lawrencecchen
lawrencecchen merged commit d6362a1 into feat-cmux-next Nov 4, 2026
216 of 228 checks passed
@lawrencecchen
lawrencecchen deleted the fix/cmux-tui-automation-windows-base-reds branch November 4, 2026 01:41
austinywang added a commit that referenced this pull request Nov 4, 2026
Picks up #34476 (Windows workflow help and automation clippy).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch was previously deployed

3 inactive deployments
ci-routing-agent — 0ef69d1d Deployed Nov 4, 2026 by github-actions[bot] via cmux-next macOS placement #67948
artifacts — 0ef69d1d Deployed Nov 4, 2026 by austinywang via publish tree-addressed cmux-tui #108424
sentry-dsyms — 0ef69d1d Deployed Nov 4, 2026 by austinywang via upload cmux-tui dSYMs to Sentry #108424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants