Repository navigation
cmux-tui: compile the workflow help arm on Unix only - #34469
austinywang wants to merge 3 commits into
Conversation
720a7d0 added a \"workflow\" scope help arm that names workflow::HELP on every target, but mod workflow is #[cfg(unix)], so cargo check for x86_64-pc-windows-gnu fails with E0433. Gate the arm like the module; Windows falls through to the root help. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
|
The workflow help arm is Unix-only, so on Windows scope_help_for returns the root help and this test would fail. Found in review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
#34476 carries the same Windows fix and two clippy fixes and is ready-to-land; this PR becomes a duplicate when it lands. The cli/tests.rs cfg gate for the Unix-only test can follow as a small separate change if a Windows test lane needs it. |
clippy -D warnings on cmux-tui (run for any PR that changes the package) fails on base code: a manual is_multiple_of in teleport.rs and the captured answer type in automation.rs. Use is_multiple_of and name the type Captured. No behavior change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Superseded by #34476, which landed the same Windows workflow help gate and both automation clippy fixes on feat-cmux-next. One leftover for the owner: |
720a7d02f6added a"workflow"arm to the scope help match that namesworkflow::HELPon every target, butmod workflowis#[cfg(unix)].cargo check --target x86_64-pc-windows-gnu -p cmux-tuinow fails with E0433, so thecmux-tui Windows checkis red on every PR merged against currentfeat-cmux-next, for example https://github.com/manaflow-ai/cmux/actions/runs/41749887731/job/126312073998 on #26713.This gates the arm with
#[cfg(unix)]like the module. On Windows,cmux help workflowfalls through to the root help, which matches how theworkflowcommand is dispatched (Unix only).Observed / Not run
crates/cmux-tui/src/cli.rs:1206in the linked Windows job.cmux-tui Windows checkis the verification.Changelog
none
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the Windows compile error in
cmux-tuiby gating the"workflow"scope help arm with#[cfg(unix)], matching themod workflowmodule it references, and runs the related help test on Unix only. Also clears two clippy lints that fail-D warningson the package. No behavior changes.cmux help workflowfalls through to the root help, matching how theworkflowcommand is dispatched.is_multiple_ofinteleport.rsand names the captured answer typeCapturedinautomation.rs.Written for commit 0fd25bb. Summary will update on new commits.