Skip to content

cmux-tui: compile the workflow help arm on Unix only - #34469

Closed
austinywang wants to merge 3 commits into
feat-cmux-nextfrom
fix-windows-workflow-help
Closed

austinywang wants to merge 3 commits into
feat-cmux-nextfrom
fix-windows-workflow-help

Conversation

@austinywang

@austinywang austinywang commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

720a7d02f6 added a "workflow" arm to the scope help match that names workflow::HELP on every target, but mod workflow is #[cfg(unix)]. cargo check --target x86_64-pc-windows-gnu -p cmux-tui now fails with E0433, so the cmux-tui Windows check is red on every PR merged against current feat-cmux-next, for example https://github.com/manaflow-ai/cmux/actions/runs/41749887731/job/126312073998 on #26713.

This gates the arm with #[cfg(unix)] like the module. On Windows, cmux help workflow falls through to the root help, which matches how the workflow command is dispatched (Unix only).

Observed / Not run

  • Observed: the E0433 at crates/cmux-tui/src/cli.rs:1206 in the linked Windows job.
  • Not run locally: the Windows cargo check. This PR's own cmux-tui Windows check is the verification.

Changelog

none

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the Windows compile error in cmux-tui by gating the "workflow" scope help arm with #[cfg(unix)], matching the mod workflow module it references, and runs the related help test on Unix only. Also clears two clippy lints that fail -D warnings on the package. No behavior changes.

  • On Windows, cmux help workflow falls through to the root help, matching how the workflow command is dispatched.
  • Replaces a manual remainder check with is_multiple_of in teleport.rs and names the captured answer type Captured in automation.rs.

Written for commit 0fd25bb. Summary will update on new commits.

View guided diff Turn on auto-fix

720a7d0 added a \"workflow\" scope help arm that names workflow::HELP
on every target, but mod workflow is #[cfg(unix)], so cargo check for
x86_64-pc-windows-gnu fails with E0433. Gate the arm like the module;
Windows falls through to the root help.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@austinywang austinywang added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 0fd25bb: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr34469 -f ref=fix-windows-workflow-help -f platform=macos -f backend_mode=local

@github-actions github-actions Bot added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Nov 4, 2026
The workflow help arm is Unix-only, so on Windows scope_help_for
returns the root help and this test would fail. Found in review.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@lawrencecchen

Copy link
Copy Markdown
Contributor

#34476 carries the same Windows fix and two clippy fixes and is ready-to-land; this PR becomes a duplicate when it lands. The cli/tests.rs cfg gate for the Unix-only test can follow as a small separate change if a Windows test lane needs it.

clippy -D warnings on cmux-tui (run for any PR that changes the
package) fails on base code: a manual is_multiple_of in teleport.rs
and the captured answer type in automation.rs. Use is_multiple_of and
name the type Captured. No behavior change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cursor

cursor Bot commented Nov 4, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@austinywang

Copy link
Copy Markdown
Contributor Author

Superseded by #34476, which landed the same Windows workflow help gate and both automation clippy fixes on feat-cmux-next. One leftover for the owner: help_workflow_shows_the_workflow_usage_not_the_root_help in cmux-tui/crates/cmux-tui/src/cli/tests.rs is not #[cfg(unix)], so it would fail if the cmux-tui tests ever run on Windows (CI only runs cargo check there today).

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 0fd25bb5 Deployed Nov 4, 2026 by austinywang via cmux-tui tree preflight #108533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants