Skip to content

swift-logic table: rows for 38 false counts since 2b3d7cd2a848 (36 PLATFORM, 2 MIXED) #34217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmux-bot merged 2 commits into from
Nov 3, 2026
Merged

swift-logic table: rows for 38 false counts since 2b3d7cd2a848 (36 PLATFORM, 2 MIXED) #34217

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83e1ea0
swift-logic table: 38 PLATFORM rows for false counts in 2b3d7cd2a848.…
lawrencecchen Nov 3, 2026
697418f
swift-logic table: the Release favicon rule counts as logic (review F…
lawrencecchen Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions plans/cmux-next/swift-logic-classes.tsv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11935,3 +11935,41 @@ CmuxNextUpdater extension UpdaterStrings 0 PLATFORM 0 0 Packages/macOS/CmuxNext/
CmuxNextDiff enum DiffTabChange 0 LOGIC 100 0 Packages/macOS/CmuxNext/Sources/CmuxNextDiff/DiffTabReuse.swift the diff tab reuse rule (was enum DiffTabReuse in CmuxNextApp, LOGIC: DiffTabReuse: rule for what an open does to a reused tab); split into DiffTabChange and an extension of DiffOpenSource
CmuxNextDiff extension DiffOpenSource 0 LOGIC 100 0 Packages/macOS/CmuxNext/Sources/CmuxNextDiff/DiffTabReuse.swift the diff tab reuse rule (was enum DiffTabReuse in CmuxNextApp, LOGIC: DiffTabReuse: rule for what an open does to a reused tab); split into DiffTabChange and an extension of DiffOpenSource
CmuxNextFocusUI extension NSWindow 0 LOGIC 100 0 Packages/macOS/CmuxNext/Sources/CmuxNextFocusUI/TypedTextInput.swift #31865: textInputHasKeyboard is the rule which input has the person's keyboard (the app active and the window owns key, then an editable text view or field, then marked text outside a terminal, then the page): key routing, for cmux-focus-core's rules; the view-shaped default (an NSWindow extension) counted it 0
CmuxNextSidebar enum SidebarStatesPlaygroundAppearance 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Views/StatesPlayground/SidebarStatesPlaygroundAppearance.swift DEV and NIGHTLY playground (Debug menu > Sidebar States Playground, bd6f7a50ad37): draws the real sidebar rows from a fixture to show every row state at every density; demo variants, not product state
CmuxNextSidebar struct SidebarStatesPlaygroundBar 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Views/StatesPlayground/SidebarStatesPlaygroundBar.swift DEV and NIGHTLY playground (Debug menu > Sidebar States Playground, bd6f7a50ad37): draws the real sidebar rows from a fixture to show every row state at every density; demo variants, not product state
CmuxNextSidebar struct SidebarStatesPlaygroundCell 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Views/StatesPlayground/SidebarStatesPlaygroundCell.swift DEV and NIGHTLY playground (Debug menu > Sidebar States Playground, bd6f7a50ad37): draws the real sidebar rows from a fixture to show every row state at every density; demo variants, not product state
CmuxNextSidebar struct SidebarStatesPlaygroundColumn 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Views/StatesPlayground/SidebarStatesPlaygroundColumn.swift DEV and NIGHTLY playground (Debug menu > Sidebar States Playground, bd6f7a50ad37): draws the real sidebar rows from a fixture to show every row state at every density; demo variants, not product state
CmuxNextSidebar struct SidebarStatesPlaygroundFavicons 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Views/StatesPlayground/SidebarStatesPlaygroundFavicons.swift DEV and NIGHTLY playground (Debug menu > Sidebar States Playground, bd6f7a50ad37): draws the real sidebar rows from a fixture to show every row state at every density; demo variants, not product state
CmuxNextSidebar struct SidebarStatesPlaygroundFixture 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Views/StatesPlayground/SidebarStatesPlaygroundFixture.swift DEV and NIGHTLY playground (Debug menu > Sidebar States Playground, bd6f7a50ad37): draws the real sidebar rows from a fixture to show every row state at every density; demo variants, not product state
CmuxNextSidebar struct SidebarStatesPlaygroundMark 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Views/StatesPlayground/SidebarStatesPlaygroundMark.swift DEV and NIGHTLY playground (Debug menu > Sidebar States Playground, bd6f7a50ad37): draws the real sidebar rows from a fixture to show every row state at every density; demo variants, not product state
CmuxNextSidebar struct SidebarStatesPlaygroundPixels 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Views/StatesPlayground/SidebarStatesPlaygroundPixels.swift DEV and NIGHTLY playground (Debug menu > Sidebar States Playground, bd6f7a50ad37): draws the real sidebar rows from a fixture to show every row state at every density; demo variants, not product state
CmuxNextSidebar struct SidebarStatesPlaygroundRenderer 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Views/StatesPlayground/SidebarStatesPlaygroundRenderer.swift DEV and NIGHTLY playground (Debug menu > Sidebar States Playground, bd6f7a50ad37): draws the real sidebar rows from a fixture to show every row state at every density; demo variants, not product state
CmuxNextSidebar enum SidebarStatesPlaygroundState 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Views/StatesPlayground/SidebarStatesPlaygroundState.swift DEV and NIGHTLY playground (Debug menu > Sidebar States Playground, bd6f7a50ad37): draws the real sidebar rows from a fixture to show every row state at every density; demo variants, not product state
CmuxNextSidebar struct SidebarStatesPlaygroundThemes 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Views/StatesPlayground/SidebarStatesPlaygroundThemes.swift DEV and NIGHTLY playground (Debug menu > Sidebar States Playground, bd6f7a50ad37): draws the real sidebar rows from a fixture to show every row state at every density; demo variants, not product state
CmuxNextSidebar class SidebarStatesPlaygroundWindow 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Views/StatesPlayground/SidebarStatesPlaygroundWindow.swift DEV and NIGHTLY playground (Debug menu > Sidebar States Playground, bd6f7a50ad37): draws the real sidebar rows from a fixture to show every row state at every density; demo variants, not product state
CmuxNextSidebar extension Strings 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Views/StatesPlayground/Strings+StatesPlayground.swift localized strings of the DEV and NIGHTLY Sidebar States Playground
CmuxNextHomeEngine class ChiefTeleportPlayground 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextHomeEngine/ChiefTeleport/ChiefTeleportPlayground.swift DEBUG-only fixture or debug tooling (#if DEBUG, Debug > Chief Teleport Playground, 894d34f2effa), not product state
CmuxNextDesign enum WindowFrameCapture 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextDesign/Windows/WindowFrame+ScreenCaptureKit.swift #34118: #if DEBUG || CMUX_BENCH_HOOKS (line 1): the ScreenCaptureKit recording of the debug.new_tab frame strip for benches; debug tooling, not product state
CmuxNextDesign class FrameStripRecording 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextDesign/Windows/WindowFrame+ScreenCaptureKit.swift #34118: #if DEBUG || CMUX_BENCH_HOOKS (line 1): the ScreenCaptureKit recording of the debug.new_tab frame strip for benches; debug tooling, not product state
CmuxNextDesign class FrameSignal 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextDesign/Windows/WindowFrame+ScreenCaptureKit.swift #34118: #if DEBUG || CMUX_BENCH_HOOKS (line 1): the ScreenCaptureKit recording of the debug.new_tab frame strip for benches; debug tooling, not product state
CmuxNextDesign class ScreenFrameStream 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextDesign/Windows/WindowFrame+ScreenCaptureKit.swift #34118: #if DEBUG || CMUX_BENCH_HOOKS (line 1): the ScreenCaptureKit recording of the debug.new_tab frame strip for benches; debug tooling, not product state
CmuxNextDesign extension NativePopupContent 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextDesign/Overlay/NativePopupContent+Rail.swift #32827: AppKit view extension of the PLATFORM view NativePopupContent: builds and lays out the rail tabs in the placement the page picks (the page chooses the placement, the tabs and the checked one; this only lays them out)
CmuxNextDesign extension NativePopupContent 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextDesign/Overlay/NativePopupContent+Keys.swift #32827 moved the popup's key handling (handleKey, enabledRows) out of the PLATFORM class NativePopupContent (NativePopupContent.swift) into this extension: AppKit key codes move the highlight among the rows and rail tabs and send the popup's events to the page
CmuxNextSidebar class SidebarFaviconRenditions 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Views/SidebarFaviconRenditions.swift 0806940812eb: the Release favicon drawing path, after SidebarFaviconStyle (counted as logic) picks the treatment: the per-view bitmap cache keyed by image identity and the CoreGraphics resample, template, invert and plate drawing (like IconRasters); groundLuminance calls SidebarFaviconInk's rule
CmuxNextSidebar struct SidebarFaviconInk 0 MIXED 85 0 Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Logic/SidebarFaviconInk.swift 0806940812eb: the Release favicon rule: sidebar.faviconStyle's default .adaptive (Release and RC always draw the default) draws a monochrome favicon under 3:1 on the sidebar ground in the label colour: the monochrome test and its thresholds (lines 15-26, 39-57) and a hand copy of the WCAG luminance and contrast rule (lines 60-70; Rust cmux-theme-tokens rgb.rs Rgb::relative_luminance and Rgb::contrast, Swift ThemeRGB; this copy linearizes at 0.03928, the owners at 0.04045) are logic; only the CoreGraphics bitmap read (lines 30-38) is platform
CmuxNextSidebar enum SidebarFaviconStyle 0 MIXED 40 0 Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Logic/SidebarFaviconStyle.swift 0806940812eb: the Release favicon rule: sidebar.faviconStyle's default .adaptive (Release and RC always draw the default) draws a monochrome favicon under 3:1 on the sidebar ground in the label colour: treatment(for:ground:) and its constants (lines 43-63; minimumContrast 3.0 repeats the design token minimumMarkContrast, Rust MINIMUM_MARK_CONTRAST) and the .adaptive case are logic; the other cases, their titles and the tunable descriptor (lines 9-41) are Debug tooling
CmuxNextSidebar enum SidebarFaviconTreatment 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Logic/SidebarFaviconTreatment.swift 0806940812eb: the Release favicon drawing path, after SidebarFaviconStyle (counted as logic) picks the treatment: the treatment value
CmuxNextSidebar struct SidebarFaviconDrawing 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Views/SidebarFaviconDrawing.swift 0806940812eb: the Release favicon drawing path, after SidebarFaviconStyle (counted as logic) picks the treatment: the drawn image value
CmuxNextCloudTunnel class LiveTunnelManager 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextCloudTunnel/LiveTunnelManager.swift 010ffb95c155: NetworkExtension wrapper: saves, loads, starts, stops and removes the NETunnelProviderManager and streams the NEVPNConnection status; OS API calls only (the tunnel rules are in CloudTunnelController)
CmuxNextHomeEngine class ChiefTeleportMenuBuilder 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextHomeEngine/ChiefTeleport/ChiefTeleportMenuBuilder.swift 894d34f2effa: AppKit: turns ChiefTeleportMenu's rows into the NSMenu the location chip pops up and sends a pick to the model's onMove or onRollback; the rows and their states come from ChiefTeleportMenu
CmuxNextSidebar struct SidebarRevealFlash 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextSidebar/Views/SidebarRevealFlash.swift Core Animation: the highlight layer Reveal Workspace in Sidebar draws over the revealed row (a Motion-gated blink, or a steady hold with animations off); no state
CmuxNextDesign struct AllThemesPlaygroundEntry 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextDesign/Themes/Playground/AllThemesPlaygroundEntry.swift DEV and NIGHTLY playground (Debug menu > All Themes Playground, c0230efd5012): every bundled theme with its contrast samples; demo variants, not product state
CmuxNextDesign class AllThemesPlaygroundModel 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextDesign/Themes/Playground/AllThemesPlaygroundModel.swift DEV and NIGHTLY playground (Debug menu > All Themes Playground, c0230efd5012): every bundled theme with its contrast samples; demo variants, not product state
CmuxNextDesign struct AllThemesPlaygroundStrings 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextDesign/Themes/Playground/AllThemesPlaygroundStrings.swift localized strings of the DEV and NIGHTLY All Themes Playground
CmuxNextDesign class AllThemesPlaygroundWindow 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextDesign/Themes/Playground/AllThemesPlaygroundWindow.swift DEV and NIGHTLY playground (Debug menu > All Themes Playground, c0230efd5012): every bundled theme with its contrast samples; demo variants, not product state
CmuxNextDesign enum ThemeElement 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextDesign/Themes/ThemeElement.swift 936966cd93e1: WCAG contrast check of the Palette colors the chrome draws with, read only by the DEV and NIGHTLY All Themes Playground and EveryThemeElementContrastTests (no other caller): design tooling, not product state
CmuxNextDesign struct ThemeElementAudit 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextDesign/Themes/ThemeElementAudit.swift 936966cd93e1: WCAG contrast check of the Palette colors the chrome draws with, read only by the DEV and NIGHTLY All Themes Playground and EveryThemeElementContrastTests (no other caller): design tooling, not product state
CmuxNextDesign struct AuditColors 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextDesign/Themes/ThemeElementAudit.swift 936966cd93e1: WCAG contrast check of the Palette colors the chrome draws with, read only by the DEV and NIGHTLY All Themes Playground and EveryThemeElementContrastTests (no other caller): design tooling, not product state
CmuxNextDesign struct Resolved 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextDesign/Themes/ThemeElementAudit.swift 936966cd93e1: WCAG contrast check of the Palette colors the chrome draws with, read only by the DEV and NIGHTLY All Themes Playground and EveryThemeElementContrastTests (no other caller): design tooling, not product state
CmuxNextDesign enum ThemeElementGround 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextDesign/Themes/ThemeElementGround.swift 936966cd93e1: WCAG contrast check of the Palette colors the chrome draws with, read only by the DEV and NIGHTLY All Themes Playground and EveryThemeElementContrastTests (no other caller): design tooling, not product state
CmuxNextDesign struct ThemeElementSample 0 PLATFORM 0 0 Packages/macOS/CmuxNext/Sources/CmuxNextDesign/Themes/ThemeElementSample.swift 936966cd93e1: WCAG contrast check of the Palette colors the chrome draws with, read only by the DEV and NIGHTLY All Themes Playground and EveryThemeElementContrastTests (no other caller): design tooling, not product state
Loading