[lawrencecchen]

Summary

The tip watcher's swift_logic_lines row is red (green reference 415,218 at 25c69ee; it stays the reference). After #33986 fixed the false counts up to 2b3d7cd, the count rose again. Both ends counted with the tip's table: 428,194 at 2b3d7cd and 434,349 at a25b4d9 (+6,155 of code; the lead's +2,563 is the net after #33986's -3,592).

A per-declaration diff of that range finds 38 declarations that the default rule counts in full (no row). 36 hold no product state and no product rule and get a PLATFORM row with a reason; the review found that 2 of them hold the Release favicon rule, so they get MIXED rows (below):

• DEV and NIGHTLY Debug playgrounds (isDebugOnly actions in SettingsActionCatalog): Sidebar States Playground (12 declarations and its strings, bd6f7a5) and All Themes Playground (4, c0230ef).
• #if DEBUG: ChiefTeleportPlayground (894d34f).
• #if DEBUG || CMUX_BENCH_HOOKS: the four frame-strip recording types of WindowFrame+ScreenCaptureKit.swift (chat-open click frames: ScreenCaptureKit when the step has no Screen Recording grant, so the chat page is in them #34118).
• The theme contrast audit (ThemeElement, ThemeElementAudit, AuditColors, Resolved, ThemeElementGround, ThemeElementSample; 936966c): only the All Themes Playground and EveryThemeElementContrastTests read it.
• AppKit and Core Animation: the two NativePopupContent extensions of feat(popup): the native popup draws the picker's four harness placements #32827 (the rail layout, and the key handling that feat(popup): the native popup draws the picker's four harness placements #32827 moved out of the PLATFORM class NativePopupContent), ChiefTeleportMenuBuilder (NSMenu), SidebarRevealFlash (a highlight layer).
• The Release favicon path of 0806940: SidebarFaviconInk MIXED 85/0 and SidebarFaviconStyle MIXED 40/0 (the .adaptive default is the Release rule, and SidebarFaviconInk hand-copies the WCAG luminance and contrast rule of cmux-theme-tokens and ThemeRGB; this copy uses 0.03928, the owners 0.04045); the bitmap cache and the two drawing values stay PLATFORM.
• OS API: LiveTunnelManager (the NETunnelProviderManager wrapper).

Every real rise stays counted, for example CloudTunnelController, GitHubAppLease, CloudStartRuns, CloudCodexBroker, ImportHistoryPageProvider, ChiefTeleportRunner, MemoryImportFlow and the Swift wg-quick parser (CloudTunnelConfiguration, CloudTunnelCIDR). REWRITE R-SWIFT-MIRRORS names the wave and the target date that move each one to Rust (its DESIGN.md section 11 and STATUS).

Testing

• python3 -I scripts/cmux-next/swift-logic-lines.py --rev a25b4d999200 --json, with the base table and then with --table of this PR: swift_logic_lines 434,349 -> 432,321 (-2,028); mirror_lines 71,741 (no change).
• The same at the PR base bc91cc5: 434,349 -> 432,321; table_rows_invalid 0; table_rows_missing 11 (the same 11 as the base).
• At 2b3d7cd with this table: 428,194 (none of the 38 declarations exists there), so the range's code rise is +4,127 after this PR.
• python3 -I scripts/cmux-next/tests/test_swift_logic_lines.py: 16 tests OK.
• prepush-gate.py: no new violations.
• Review: FIX at 83e1ea0 (comment): two favicon rows hid the Release favicon rule and its hand copy of the WCAG rule. Repaired in 697418f with the review's shares.

Observed / Not run

• Observed: the counts above.
• Not run: no build; this changes one data file that only the report script reads.

Changelog

none

Proof

No capture: a data file for a report script, no app change.

---

^{Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.}

[cursor]

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 697418f: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr34217 -f ref=rewrite/swift-logic-false-counts-2 -f platform=macos -f backend_mode=local

Shipped in:

• cmux NEXT nightly 1.0.0-nightly.4173568006501 (cb6b71feab)
• cmux NEXT nightly 1.0.0-nightly.4173689456801 (4c71330ed9)
• cmux NEXT nightly 1.0.0-nightly.4173805520001 (cf0fddef88)

[lawrencecchen]

Review (claude-review-34217): FIX at 83e1ea0

36 of the 38 rows are correct. Two favicon rows hide the Release favicon rule, which also copies the shared contrast rule by hand.

Blocking: SidebarFaviconInk and SidebarFaviconStyle (swift-logic-classes.tsv:11959-11960)

The rule ships in every build. sidebar.faviconStyle is a Debug tunable, but Release and RC always draw its default (TunableStore.swift:5-14). That default is .adaptive (SidebarFaviconStyle.swift:12-14, 38-41). SidebarFaviconRenditions is "the one path every sidebar surface draws a page favicon through" (SidebarFaviconRenditions.swift:4-6, 50-52). Its callers are SidebarItemRowView.swift:70, SidebarIconView.swift:16 and WorkspaceTabHoverCardRow.swift:21. So treatment(for:ground:) (SidebarFaviconStyle.swift:43-63) is product behaviour for every user: a monochrome favicon under 3:1 on its ground draws as a template in the label colour. The title of 0806940 says this: "fix(sidebar): low-contrast monochrome favicons draw in the label colour". The reasons say "no product rule" and "(the Debug tunable: each case is a pixel treatment, not an app behaviour)". Neither is true for .adaptive.

It copies a rule that is already owned somewhere else. layer-ownership.md §1 item 4 says such a rule lives once and is never hand-copied.

• SidebarFaviconInk.relativeLuminance and contrast(onGround:) (SidebarFaviconInk.swift:60-70) repeat Rust Rgb::relative_luminance and Rgb::contrast (cmux-tui/crates/cmux-theme-tokens/src/rgb.rs:55-67). Swift already has the same rule in ThemeRGB.relativeLuminance and contrast(with:) (Packages/Shared/CmuxTheme/Sources/CmuxTheme/ThemeRGB.swift:82-96).
• SidebarFaviconStyle.minimumContrast = 3.0 (SidebarFaviconStyle.swift:44) repeats theme.constants.minimumMarkContrast (plans/cmux-next/spec-proposals/visuals/design-tokens.json:100). Rust has it as MINIMUM_MARK_CONTRAST (tokens.rs:208) and Swift as ThemeTokens.minimumMarkContrast.
• The copy has already drifted. It linearizes at 0.03928 (SidebarFaviconInk.swift:68); Rust and ThemeRGB use 0.04045.
• The monochrome test is a rule with thresholds, not a platform call: chroma 0.18, 6 % coloured share, 0.12 spread, 85 % one ink (SidebarFaviconInk.swift:15-26, 39-57).

The table counts this kind of code elsewhere. GhosttyThemeColors+Contrast.swift is LOGIC "Theme contrast math" (tsv:11405-11406). This PR also leaves the same-day 3:1 mark rule counted: StatusDotHue and ThemeTokens+StatusDotHue.swift from c0230ef. That rule even uses the shared ThemeTokens.minimumMarkContrast.

Classes to use:

• SidebarFaviconInk: MIXED 85/0. Only the CoreGraphics bitmap read (SidebarFaviconInk.swift:30-38, 9 of 63 lines) is platform.
• SidebarFaviconStyle: MIXED 40/0. The rule, its two constants (SidebarFaviconStyle.swift:43-63) and the .adaptive case are logic. The variant titles and the tunable descriptor (26-41) are Debug tooling.
• Both reasons: say that the .adaptive default is the Release favicon rule and that it copies the WCAG rule and minimumMarkContrast.

With these two shares the head counts swift_logic_lines 432,321 (-2,028), not 432,245. Mirror stays 71,741, invalid 0 and missing 11. I ran the counter with an edited copy of the table.

Non-blocking

• The other three favicon rows (SidebarFaviconRenditions, SidebarFaviconTreatment, SidebarFaviconDrawing) can stay PLATFORM. They are a bitmap cache and drawing values, like IconRasters (tsv:11898). Their reason should not say "Debug ... treatment", because this is the Release favicon path. Also, SidebarFaviconRenditions.groundLuminance (SidebarFaviconRenditions.swift:71-74) calls the copied formula.
• PR body: two claims need the change above: "38 declarations ... hold no product state and no product rule" and "Image drawing: the five favicon types". I did not check the "REWRITE R-SWIFT-MIRRORS ... DESIGN.md section 11 and STATUS" reference, because it is not in this repository. The only path that names it is handoff/rewrites/R-SWIFT-MIRRORS/DESIGN.md, in cmux-tui/crates/cmux-view-rows/src/lib.rs:6, and there is no handoff/ folder at the head.

Checked and correct (the other 36 rows)

• Keys: All 38 rows have 9 fields, module = the folder after Sources/, ordinal 0 and PLATFORM 0/0. Each one matches exactly one declaration that is unlisted at the base. The --sites unlisted diff from base to head removes these 38 and nothing else, and their spans add up to 2,104.
• Sidebar States Playground (13 rows): debug.sidebarStatesPlayground is isDebugOnly (SettingsActionCatalog.swift:528-532). ActionRegistry.swift:395 and DevTools.swift make it DEV and NIGHTLY only. Only SidebarStatesPlaygroundAction.swift:20-26 binds it; all other callers are tests. The rows are fixture data, drawing and pixel measure, the same class as the Tab Bar Playground rows (tsv:11918).
• All Themes Playground (4 rows): debug.allThemesPlayground is isDebugOnly (SettingsActionCatalog.swift:517-521). Only HomeDebugActions.swift:33 binds it. AllThemesPlaygroundModel holds a sorted, searched and filtered list, but only inside this DEV/NIGHTLY tool, like McpConnectPlaygroundModel (tsv:11907). "Demo variants" is not an exact reason for it, but the class is correct.
• Theme audit (6 rows): The only callers are the playground and EveryThemeElementContrastTests (git grep). The audit uses the shared ThemeRGB.contrast(with:) and ThemeTokens.minimum*Contrast, so it copies no rule.
• ChiefTeleportPlayground: The whole file is in #if DEBUG (lines 1-156), and the binding is in #if DEBUG too (HomeDebugActions.swift:37-53).
• WindowFrame+ScreenCaptureKit (4 rows): #if DEBUG || CMUX_BENCH_HOOKS covers lines 1-269.
• NativePopupContent+Keys and +Rail: 6f7f953 (feat(popup): the native popup draws the picker's four harness placements #32827) moved handleKey and enabledRows out of the PLATFORM class in NativePopupContent.swift. The rest is AppKit layout and key routing.
• ChiefTeleportMenuBuilder, LiveTunnelManager, SidebarRevealFlash: ChiefTeleportMenuBuilder makes an NSMenu from the counted ChiefTeleportMenu rows. LiveTunnelManager only calls NETunnelProviderManager and NEVPNConnection. SidebarRevealFlash is a Motion-gated CALayer.
• Hashes: Each cited hash is the commit that added its files (git log --diff-filter=A).

Counts I ran

All with python3 -I scripts/cmux-next/swift-logic-lines.py --json:

• bc91cc5: 434,349 logic, 71,741 mirror.
• 83e1ea0: 432,245 logic, 71,741 mirror. table_rows go from 11,936 to 11,974, invalid stays 0, and the same 11 rows are missing (the --missing diff is empty).
• a25b4d9: 434,349 with its own table, 432,245 with this PR's --table.
• 2b3d7cd: 428,194 with either table. Missing goes from 5 to 43 because none of the 38 declarations exist there.
• 25c69ee: 415,218.
• python3 -I scripts/cmux-next/tests/test_swift_logic_lines.py: 16 tests OK.

Not run: prepush-gate.py. No build, because this PR only changes a data file.

[lawrencecchen]

Review (claude-review-34217): SHIP at 697418f

The repair fixes my FIX at 83e1ea0 (comment 6614795877).

Delta (git diff 83e1ea0d0cc 697418f040a)

One commit changes one file: the 5 favicon rows. No other row changed.

• SidebarFaviconInk is now MIXED 85/0 and SidebarFaviconStyle is MIXED 40/0. Both shapes are valid. The keys and shares are the ones I proposed.
• The new reasons are true, and the line ranges they name match the code:
  • SidebarFaviconInk.swift:15-26 and 39-57 are the thresholds and the monochrome test.
  • SidebarFaviconInk.swift:60-70 is the WCAG copy, and 30-38 is the bitmap read.
  • SidebarFaviconStyle.swift:43-63 is the rule and its constants.
• The 0.03928 vs 0.04045 claim and the minimumMarkContrast / MINIMUM_MARK_CONTRAST claim match rgb.rs:55-67, ThemeRGB.swift:82-96, tokens.rs:208 and design-tokens.json:100.
• SidebarFaviconRenditions, SidebarFaviconTreatment and SidebarFaviconDrawing stay PLATFORM. Their reasons now say they are the Release drawing path. It is true that groundLuminance calls the copy (SidebarFaviconRenditions.swift:71-74).

Counts I ran

All with python3 -I scripts/cmux-next/swift-logic-lines.py --json:

• 697418f: swift_logic_lines 432,321 and mirror_lines 71,741. table_rows 11,974, invalid 0, and the same 11 missing rows as the base.
  • --sites: SidebarFaviconInk 54 of 63 lines (MIXED 85%), SidebarFaviconStyle 22 of 56 lines (MIXED 40%).
• bc91cc5: 434,349, so the PR lowers the count by 2,028.
• a25b4d9 with this table: 432,321.
• 2b3d7cd with this table: 428,194 (missing 43), so the range rises by 4,127.
• python3 -I scripts/cmux-next/tests/test_swift_logic_lines.py: 16 tests OK.

The PR body's summary, its favicon item and its Testing numbers are correct.

Non-blocking

• The PR title still says "38 PLATFORM rows", but there are now 36 PLATFORM rows and 2 MIXED rows. The squash commit takes the title, so change the title before it lands. A title edit does not change the head.
• I still did not check the "REWRITE R-SWIFT-MIRRORS ... DESIGN.md section 11 and STATUS" reference, because that file is not in this repository.

Not run: prepush-gate.py. No build.

[blacksmith-sh]

Found 2 test failures on Blacksmith runners:

Failures

Test	View Logs
test_every_compile_job_names_its_warm_sources (main.ThisTree.test_every_compile_job _names_its_warm_sources)/ test_every_compile_job_names_its_warm_sources (main.ThisTree.test_every_compile_job _names_its_warm_sources)	View Logs
test_the_attestation_reserves_budget_and_its_retry_shares_the_ledger (main.Workflow Tests.test_the_attestation_reserves_budget_and_its_retry_shares_the_ledger)/ test_the_attestation_reserves_budget_and_its_retry_shares_the_ledger (main.Workflow Tests.test_the_attestation_reserves_budget_and_its_retry_shares_the_ledger)	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}

[lawrencecchen]

Non-green checks on head 697418f, classified (this PR changes only plans/cmux-next/swift-logic-classes.tsv):

• nightly-guards / workflow-guard-tests / release-notary: base finding. Its failing tests are workflow tests (test_the_attestation_reserves_budget_and_its_retry_shares_the_ledger, test_every_compile_job_names_its_warm_sources), which read no file of this PR. The same job is red on unrelated open PRs cmux-tui: a workspace commit journals only the workspaces it changes (#32408) #34226, cmux-tui: server-stats write_path counts the registry's WAL frame bytes (#32408, R-DURABILITY S-WS PR 1) #34225, base red: Cloud Tunnel extension observes the path with NWPathMonitor (defaultPath is not in the macOS 26.5 SDK) #34204 and gallery: split pair ready again (composer focus ping-pong); New Tab address row holds while a port is typed #34203 (run 41714175859, job 126190054303).
• nightly-guards / Guard status: wrapper of the guard above.

No check is red because of this PR.

[lawrencecchen]

Two more non-green checks on head 697418f, classified:

• plan (backend-migrations): infrastructure. The job was cancelled at its 10-minute limit in the step "Changed files and head migrations" (20:49:22Z to 20:56:17Z, "The operation was canceled", orphan git-remote-https processes at shutdown). This PR changes no file under backend/. Rerun on the same SHA (run 41715007527, attempt 2).
• backend migrations applied: wrapper of plan ("migration plan cancelled").