[lawrencecchen]

Fixes the +1 part of the arch-ratchet red: [app_lines] CmuxNextApp Swift lines: +1 at 41f05ff (judged over 6500d46). Culprit: #33155 (a848b28), the only commit in that range that adds an App line.

Takes back #33155: no code changes; a comment line joins a code line.

Cause

#33155 added AgentPaneTailCache.shared.resume() in CloudService's sign-in observer: +1 CmuxNextApp line.

Fix

The comment line under it ("Sign-out revoked the WireGuard peer and parked the hub.") now rides on the line it describes, await self.hub?.resume(), as #33019 did. The code is the same.

Red at the base, green at the head

Command: python3 scripts/cmux-next/arch-ratchet.py --base PARENT --head COMMIT

• Red at a848b28 over its parent: +1 (CmuxNextApp +1).
• This head over the current tip: app_lines -1 (CmuxNextApp -1), no count rises.

The tip is red again for a larger reason: e8fc118 (#33567) adds +74 App lines. That needs moves to packages and gets its own PR.

Changelog

none

Observed / Not run

Observed: the ratchet runs above; prepush-gate.py passed. Not run: no build (a comment move only).

---

^{Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.}

---

Summary by cubic

Fixes the arch-ratchet red for CmuxNextApp App lines by merging a comment onto the code line it describes.

The +1 App line came from #33155, which added AgentPaneTailCache.shared.resume() and a comment on a separate line. This PR keeps the code identical and moves the comment onto the await self.hub?.resume() line, matching the pattern from #33019. Net result: app_lines -1, no other counts rise.

^{Written for commit 5ae962c. Summary will update on new commits.}

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 5ae962c: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr33610 -f ref=base-red/app-lines-33155 -f platform=macos -f backend_mode=local

Shipped in:

• cmux NEXT nightly 1.0.0-nightly.4162918426201 (6a1595932a)
• cmux NEXT nightly 1.0.0-nightly.4163036887701 (4a7a84507f)
• cmux NEXT nightly 1.0.0-nightly.4163148939801 (96eb1b98d7)

[lawrencecchen]

Review (independent subagent): SHIP at 5ae962c

What I checked:

1. Code unchanged. git diff -w --word-diff e8fc11865f8...5ae962c090a shows only one change in CloudService.swift: the comment line // Sign-out revoked the WireGuard peer and parked the hub. moved to a trailing comment on await self.hub?.resume(). The tokens, their order and the indentation of that statement are the same. AgentPaneTailCache.shared.resume() (from perf: read persisted remote tails before the web connection #33155) and the lines after it are not changed.
2. The comment still describes the correct line. It explains why the hub must resume on sign-in (sign-out parked it), and it is now on await self.hub?.resume(), the statement it was written for. It is not on the tail-cache line above it, where the first commit 0503228 had put it. The head commit corrects that.
3. Line length. The new line is 106 characters. scripts/cmux-next/lint/swiftformat.conf only enables trailingSpace,consecutiveBlankLines,duplicateImports,semicolons,linebreakAtEndOfFile, and scripts/cmux-next/lint/swiftlint.yml uses only_rules with no line_length. Neither config has a width limit, and the same file already has lines of 160 to 241 characters.
4. Ratchet.
   • arch-ratchet.py --base e8fc11865f8 --head HEAD (the PR's merge-base): app_lines -1 (CmuxNextApp -1), no count rises.
   • --base origin/feat-cmux-next (8f4516ba653) --head HEAD: app_lines -1, no count rises.
   • --base a848b28fded~1 --head a848b28fded: +1 (CmuxNextApp +1), which confirms the culprit.
   • --base a848b28fded --head HEAD gives +56. That comes from later commits on the base (for example Cloud legacy link: bound and log every start step, show the failing step with Retry #33567), not from this PR.
5. Other checks.
   • prepush-gate.py --base e8fc11865f8 --head HEAD: no new violations.
   • The tip moved after the merge-base (5 commits), but none of those commits touches CloudService.swift, so there is no conflict.
   • The description has Takes back #33155: ... for the one-week take-back hold, and the PR has the risk:normal label.
   • Not run: no Swift build. The change only moves a comment.

[blacksmith-sh]

Found 1 test failure on Blacksmith runners:

Failure

Test	View Logs
test_every_compile_job_names_its_warm_sources (main.ThisTree.test_every_compile_job _names_its_warm_sources)/ test_every_compile_job_names_its_warm_sources (main.ThisTree.test_every_compile_job _names_its_warm_sources)	View Logs

^{Need help on this PR? Tag @codesmith-bot with what you need.}