Repository navigation
base red: arch app_lines +1 from #32973 (a comment line joins the comment above) - #33019
Merged
Merged
Conversation
…ck comment above (no code change)
lawrencecchen
temporarily deployed
to
ci-routing-agent
November 3, 2026 04:32 — with
GitHub Actions
Inactive
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on b4978e2 to compare; do not merge until green; see lane-rules Shipped in:
|
lawrencecchen
temporarily deployed
to
ci-routing-agent
November 3, 2026 04:32 — with
GitHub Actions
Inactive
Contributor
Author
|
Review (independent-subagent): SHIP at b2252da
|
|
Found 6 test failures on Blacksmith runners: Failures
|
lawrencecchen
added a commit
that referenced
this pull request
Nov 3, 2026
…he hub's line) (#33610) * base red: arch app_lines +1 from #33155 (the tail cache's resume joins the comment line) #33155 (a848b28) added one CmuxNextApp line in CloudService's sign-in observer: AgentPaneTailCache.shared.resume(). Its comment line below now sits on that call's line, as #33019 did; the code is the same. CmuxNextApp -1. * base red: the hub's comment rides on the hub's line (review of the +1 join)
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Summary
Tip arch-ratchet red since 5de3c47 (STATUS 8261):
[app_lines] CmuxNextApp Swift lines: +1. #32973 added one comment line inCmuxNextApp/Handlers/TabCloseGuard.swift. app_lines counts physical lines, comments too, so the rise is that line.This PR joins that comment to the rollback comment above it, in one line. No code changes.
Verification
python3 scripts/cmux-next/arch-ratchet.py --base 357d9514b914 --head HEAD(the last green arch tip): no architecture count rises.python3 scripts/cmux-next/prepush-gate.py: no new violations; app_lines -1.Observed / Not run
Changelog
none
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the
app_linesarch-ratchet red by merging a comment line into the preceding comment, reducing the line count inTabCloseGuard.swift. No code changes.Written for commit b2252da. Summary will update on new commits.