Skip to content

base red: arch app_lines +1 from #32973 (a comment line joins the comment above) - #33019

Merged
lawrencecchen merged 1 commit into
feat-cmux-nextfrom
fix/base-red-arch-32973
Nov 3, 2026
Merged

lawrencecchen merged 1 commit into
feat-cmux-nextfrom
fix/base-red-arch-32973

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Tip arch-ratchet red since 5de3c47 (STATUS 8261): [app_lines] CmuxNextApp Swift lines: +1. #32973 added one comment line in CmuxNextApp/Handlers/TabCloseGuard.swift. app_lines counts physical lines, comments too, so the rise is that line.

This PR joins that comment to the rollback comment above it, in one line. No code changes.

Verification

  • python3 scripts/cmux-next/arch-ratchet.py --base 357d9514b914 --head HEAD (the last green arch tip): no architecture count rises.
  • python3 scripts/cmux-next/prepush-gate.py: no new violations; app_lines -1.

Observed / Not run

  • Observed: the two commands above, on this VM (Python only).
  • Not run: no compile; the change is a comment only.

Changelog

none


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the app_lines arch-ratchet red by merging a comment line into the preceding comment, reducing the line count in TabCloseGuard.swift. No code changes.

Written for commit b2252da. Summary will update on new commits.

View guided diff Turn on auto-fix

@lawrencecchen lawrencecchen added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review b2252da: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr33019 -f ref=fix/base-red-arch-32973 -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on b4978e2 to compare; do not merge until green; see lane-rules

Shipped in:

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Review (independent-subagent): SHIP at b2252da

  • Diff (vs 5de3c47): only TabCloseGuard.swift, 1 line added, 2 removed. All three are // comment lines. No code changes.
  • Meaning: the joined comment keeps both statements. The rolled-back emptied pane comes back with its focus, and any tab that comes back shows a pane that a later close hid (perf(next): closing the last tab of a split pane removes the pane at once, not after the program read #32898). Together with the first clause, this still covers "whichever close hid it". Small loss, not blocking: the words "its last other tab" and "review of" are gone. The withdrawPaneClose guard in the code still shows the condition.
  • python3 scripts/cmux-next/arch-ratchet.py --base 357d9514b914 --head b2252dacc4a6: "no architecture count rises". On the same base, the parent 5de3c47 gives [app_lines] CmuxNextApp +1 and the push is refused. This PR clears that red.
  • Line length: the new line 44 is 191 chars. The longest line in the file is 226 chars, at the base and at the head.
  • Not run: Swift compile and tests. Only comments changed, so neither is needed.

@lawrencecchen lawrencecchen added the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Nov 3, 2026
@github-actions github-actions Bot added risk:normal Risk tier (docs/ci/risk-tiers.md) and removed risk:low Risk tier (docs/ci/risk-tiers.md) labels Nov 3, 2026
@blacksmith-sh

blacksmith-sh Bot commented Nov 3, 2026

Copy link
Copy Markdown

Found 6 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp3xwet2zh/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpvze857pt/summary-missing.json (live):/summary-missing.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@lawrencecchen
lawrencecchen merged commit e5e182c into feat-cmux-next Nov 3, 2026
213 of 234 checks passed
@lawrencecchen
lawrencecchen deleted the fix/base-red-arch-32973 branch November 3, 2026 04:48
lawrencecchen added a commit that referenced this pull request Nov 3, 2026
…he hub's line) (#33610)

* base red: arch app_lines +1 from #33155 (the tail cache's resume joins the comment line)

#33155 (a848b28) added one CmuxNextApp line in CloudService's sign-in
observer: AgentPaneTailCache.shared.resume(). Its comment line below now sits
on that call's line, as #33019 did; the code is the same. CmuxNextApp -1.

* base red: the hub's comment rides on the hub's line (review of the +1 join)

This branch was previously deployed

1 inactive deployment
ci-routing-agent — b2252dac Deployed Nov 3, 2026 by lawrencecchen via wait for same-key tree publisher #103951
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant