Skip to content

Update Bonsplit selected tab separator - #3351

Merged
lawrencecchen merged 2 commits into
mainfrom
task-fix-bonsplit-selected-tab-left-border
Apr 30, 2026
Merged

lawrencecchen merged 2 commits into
mainfrom
task-fix-bonsplit-selected-tab-left-border

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Apr 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary\n- update Bonsplit to include the selected-tab left separator trim from https://github.com/manaflow-ai/bonsplit/pull/112\n- keeps the selected tab's left separator pinned to the top while leaving a one-point gap at the bottom corner\n\n## Tests\n- cd vendor/bonsplit && swift test\n- ./scripts/reload.sh --tag tabedge


Summary by cubic

Updates vendored bonsplit to include the selected-tab left separator trim for cleaner tab edges. Keeps the selected tab’s left separator pinned to the top with a 1pt gap at the bottom corner.

Written for commit a56f8bc. Summary will update on new commits. Review in cubic

Summary by CodeRabbit

  • Chores
    • Updated vendor dependency to the latest version.

@vercel

vercel Bot commented Apr 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cmux Ready Ready Preview, Comment Apr 30, 2026 11:00am
cmux-staging Building Building Preview, Comment Apr 30, 2026 11:00am

@coderabbitai

coderabbitai Bot commented Apr 30, 2026 •

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

This pull request updates the Git submodule pointer for vendor/bonsplit from commit hash 84e5bd57... to 1babedfe.... No source code, logic, or configuration changes are introduced; only the vendored dependency reference is advanced.

Changes

Cohort / File(s) Summary
Submodule Reference Update
vendor/bonsplit
Git submodule commit hash updated to pull in upstream changes from the bonsplit dependency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 A hop, a skip, a submodule's leap,
Bonsplit's pointer marches deep,
From one hash home to another we bound,
Keeping vendors fresh and sound! 🌱

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating Bonsplit and specifically addressing the selected tab separator, which is the core focus of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description adequately covers the summary of changes and testing approach, addressing key template sections.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch task-fix-bonsplit-selected-tab-left-border

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR bumps the vendor/bonsplit submodule pointer to pick up the selected-tab left-separator trim from bonsplit PR #112, which keeps the left separator pinned to the top with a one-point gap at the bottom corner.

  • The new submodule commit (1babedfe) is sourced from an open PR branch in the bonsplit repo. Per the project's submodule safety policy, it must land on origin/main of that repo before the parent pointer is updated, otherwise the commit is orphaned when the feature branch is deleted.

Confidence Score: 3/5

Hold until bonsplit PR #112 is confirmed merged to origin/main — the submodule commit could otherwise be orphaned.

Single P1: the submodule commit may not yet be reachable from bonsplit's main branch, violating the explicit submodule safety policy in CLAUDE.md. If the commit is already on main the change is otherwise trivial and safe.

vendor/bonsplit — verify new commit is on origin/main of the bonsplit remote before merging.

Important Files Changed

Filename Overview
vendor/bonsplit Submodule pointer bumped from 84e5bd5 to 1babedf; need to confirm the new commit is on bonsplit's origin/main to avoid orphaning.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[bonsplit PR #112] -->|merge to main?| B{Commit on origin/main?}
    B -- Yes --> C[Update vendor/bonsplit pointer in cmux]
    B -- No --> D[Orphaned commit — branch deletion loses it]
    C --> E[PR safe to merge]
    D --> F[Do NOT merge — push to bonsplit main first]
Loading

Reviews (1): Last reviewed commit: "Update Bonsplit selected tab separator" | Re-trigger Greptile

Comment thread vendor/bonsplit
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@lawrencecchen
lawrencecchen merged commit 7ec13e1 into main Apr 30, 2026
21 checks passed
@lawrencecchen
lawrencecchen deleted the task-fix-bonsplit-selected-tab-left-border branch April 30, 2026 11:09

This branch was successfully deployed

1 active deployment
Preview – cmux — a56f8bcf Deployed Apr 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant