Repository navigation
Update Bonsplit selected tab separator - #3351
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThis pull request updates the Git submodule pointer for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR bumps the
Confidence Score: 3/5Hold until bonsplit PR #112 is confirmed merged to origin/main — the submodule commit could otherwise be orphaned. Single P1: the submodule commit may not yet be reachable from bonsplit's main branch, violating the explicit submodule safety policy in CLAUDE.md. If the commit is already on main the change is otherwise trivial and safe. vendor/bonsplit — verify new commit is on origin/main of the bonsplit remote before merging. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[bonsplit PR #112] -->|merge to main?| B{Commit on origin/main?}
B -- Yes --> C[Update vendor/bonsplit pointer in cmux]
B -- No --> D[Orphaned commit — branch deletion loses it]
C --> E[PR safe to merge]
D --> F[Do NOT merge — push to bonsplit main first]
Reviews (1): Last reviewed commit: "Update Bonsplit selected tab separator" | Re-trigger Greptile |
…ected-tab-left-border
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Summary\n- update Bonsplit to include the selected-tab left separator trim from https://github.com/manaflow-ai/bonsplit/pull/112\n- keeps the selected tab's left separator pinned to the top while leaving a one-point gap at the bottom corner\n\n## Tests\n- cd vendor/bonsplit && swift test\n- ./scripts/reload.sh --tag tabedge
Summary by cubic
Updates vendored
bonsplitto include the selected-tab left separator trim for cleaner tab edges. Keeps the selected tab’s left separator pinned to the top with a 1pt gap at the bottom corner.Written for commit a56f8bc. Summary will update on new commits. Review in cubic
Summary by CodeRabbit