Skip to content

Fix split transparency regression - #1568

Merged
lawrencecchen merged 2 commits into
mainfrom
task-split-transparency-disappears
Mar 17, 2026
Merged

lawrencecchen merged 2 commits into
mainfrom
task-split-transparency-disappears

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Mar 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Testing

  • ./scripts/setup.sh
  • ./scripts/reload.sh --tag task-split-transparency-disappears
  • not run tests locally (repo policy)

Issues

  • Related: plain-text task "transparency disappears when i make a split (ie cmd+d)"

Summary by cubic

Fixes a regression where split transparency disappeared after Cmd+D by updating vendor/bonsplit to include the upstream fix and regression test, keeping split-only wrapper containers clear.

Written for commit 975a850. Summary will update on new commits.

Summary by CodeRabbit

  • Chores
    • Updated an internal submodule/dependency reference to a newer commit to keep the project in sync; no functional, public API, or behavior changes were introduced.

@vercel

vercel Bot commented Mar 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
cmux Ready Ready Preview, Comment Mar 17, 2026 3:59am

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@coderabbitai

coderabbitai Bot commented Mar 17, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 106e855c-1295-40cf-98d4-aa31bf649a39

📥 Commits

Reviewing files that changed from the base of the PR and between 08854f1 and 975a850.

📒 Files selected for processing (1)
  • vendor/bonsplit
🚧 Files skipped from review as they are similar to previous changes (1)
  • vendor/bonsplit

📝 Walkthrough

Walkthrough

Updated the vendor/bonsplit submodule reference from commit 73c1ef2df9a6c8a2837212ecce900794d0f21826 to 02fa188ccd244b1e6efc037e4ed631e966144795. No local logic, control flow, or public API changed.

Changes

Cohort / File(s) Summary
Submodule Update
vendor/bonsplit
Bumped tracked submodule commit pointer from 73c1ef2df9a6c8a2837212ecce900794d0f21826 to 02fa188ccd244b1e6efc037e4ed631e966144795. (Lines: +1 / -1)

Possibly Related PRs

Poem

🐇 I hopped through hashes, light and spry,
A tiny change beneath the sky,
One pointer turned, no code undone,
A silent swap—my little run,
Cheers to tidy trees and quiet fun! 🌱

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly matches the main change: fixing a split transparency regression by updating the vendor/bonsplit submodule.
Description check ✅ Passed The description covers the Summary and Testing sections adequately. However, the Demo Video and Checklist sections are missing, and some checklist items are incomplete.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch task-split-transparency-disappears
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@lawrencecchen
lawrencecchen merged commit eb95cb3 into main Mar 17, 2026
9 of 12 checks passed
bn-l pushed a commit to bn-l/cmux that referenced this pull request Apr 3, 2026
…parency-disappears

Fix split transparency regression

This branch was successfully deployed

1 active deployment
Preview — 975a8509 Deployed Mar 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant