Repository navigation
Test: an approved live ask's Approved mark is checked once its call ran - #33439
Conversation
The live and resync cases of agent-pane-permission-receipt checked the Approved mark while the call still ran, when the live line draws it; they now finish the call first. Fixes the red #33408 left. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Yours to fix: CI failed on
Failures:
Matched log linesNot re-run automatically: Written by red: web / Web status; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules Shipped in:
|
…29938's live line (#33614) * base red: the spacing table finds the live line across its lead span (#33241) #33241 draws the live line's verb in its own span ("Sending" | " message to …"), so no single text node holds "Sending message to" and step-to-live / live-to-step measured nothing. The test now finds the live line by its row's text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8 * base red: the codex live line test reads the live line's column class (#33157) #33157 gives the live line `cv-worked--live` (its words on the status rows' text column), so its quiet box renders "cv-worked cv-worked--live is-quiet". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8 * base red: the working-counts tray lists its subagents newest first (#33364) #33364 orders the open running tray newest first: Tester (spawned after Reviewer) now leads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8 * base red: the live permission tests move the turn past the approved call (#33408, #33439) In a running turn with nothing after it, the latest finished call is lifted onto the live line (turns.ts liftedStep, #29938), so its row and its Approved mark are not drawn. #33439 pushed only the call's completion; the tests now push the reply's first words after it, the state the passing resync test already reaches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This fixes the red that #33408 left on base. In
agent-pane-permission-receipt.test.ts, three cases (answered live, the mode switch while the card is open, and resync) checked for the new "Approved" mark while the approved call was still running. During that time the live line draws the call, not its row. Each case now finishes the call (tool_call_updatecompleted) and then checks the mark. No product code changes.Leo, on the original row: "but what's going on with these?"
Test:
bun test test/agent-pane-permission-receipt.test.tswithCMUX_BROWSER_TESTS=1passes on the fleet.🤖 Generated with Claude Code
Agent session: agent session
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the failing tests that #33408 left on the base branch. In
agent-pane-permission-receipt.test.ts, three cases (answered live, mode switch while the card is open, and resync) checked for the "Approved" mark while the approved call was still running, when the live line draws the call rather than its row. Each case now finishes the call with a completedtool_call_updatebefore checking the mark. No product code changes.Written for commit 98d7743. Summary will update on new commits.