Skip to content

Running tray: the open list is newest first, the folded bar names the newest one - #33364

Merged
teamleaderleo merged 2 commits into
feat-cmux-nextfrom
lane/tray-newest-first
Nov 3, 2026
Merged

teamleaderleo merged 2 commits into
feat-cmux-nextfrom
lane/tray-newest-first

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 3, 2026 •

Copy link
Copy Markdown
Collaborator

Leo, 2026-11-03: "ok this previews one of the latest but it doesn't show in latest it shows in oldest order"

His nightly showed the folded running bar naming the newest items ("Context around the ask and memory search · glaeda-gh wait … +6 more"), while the open list showed the oldest at the top (the 15m 45s command first, the newest at the bottom).

  • Open list, newest first. trayItems (subagents/runningTray.ts) now orders what runs newest first, the same order the folded bar names, so the top row is what just started. A nested subagent stays under its parent, and the subtree moves with the parent's start time. Items with no start time (started chats) go last, in their list order. Finished cards are unchanged; they were already ordered by most recent end.
  • Folded bar, one name. trayFoldHead.experiment.ts's default arm is now one: one newest name that fits instead of two that are both cut, as in his screenshot. The two and counts arms remain in the gallery (agent-pane.subagent-tray-names).

Design spec: design/running-tray.md (the folded header names what runs).

Tests: test/subagent-tray-names.test.tsx (a new order test, plus the folded bar's one name and +N), and subagent-tray.test.tsx and agent-pane-subagents-fixture.test.ts updated for the new order. Locally, test/agent-pane-workflow-progress.test.tsx fails 2 tests ("1 failed") with or without this change.

Agent session: agent session

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the running subagents tray from showing the oldest item at the top of the open list when the folded bar named the newest one, so both views now agree.

  • The open list orders running items newest first; nested subagents stay under their parent, and parent subtrees move by the parent's start time.
  • Started chats without a start time go last, in their existing list order.
  • The folded bar's default now shows one newest name that fits instead of two cut-off ones; the two and counts alternatives remain available behind the experiment.
  • Finished cards are unchanged; they already listed most recently ended first.

Written for commit 0058443. Summary will update on new commits.

View guided diff Turn on auto-fix

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 3, 2026
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent opus-5.5): SHIP at 44feca2

Checked newestFirst's nesting (a subtree moves with its parent), its stable order with no-start items last, every trayItems caller (counts, keys and arrivals don't depend on order), and the default arm. The only change after the review is a comment.
Visual verdict: no images; the order and folded label are covered by tests.
Follow-ups: started chats have no start time in itemStart, so they sort last.

@teamleaderleo teamleaderleo added the leo-named-fix An obvious fix to something Leo named: lands on push, review runs in parallel label Nov 3, 2026
teamleaderleo and others added 2 commits November 3, 2026 08:31
… newest one

Leo, 2026-11-03: "ok this previews one of the latest but it doesn't show in latest it shows in
oldest order". The folded bar named the newest items, but the open list put the oldest on top.
trayItems now orders the open tray newest first, the same order the folded bar names; a nested
subagent stays under its parent, and the subtree moves with the parent's start. The folded bar's
default arm is now "one": one newest name that fits instead of two that are both cut.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-f0cbd725ab08829f1ad0
@teamleaderleo
teamleaderleo force-pushed the lane/tray-newest-first branch from 44feca2 to 0058443 Compare November 3, 2026 08:32
@cursor

cursor Bot commented Nov 3, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 0058443: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr33364 -f ref=lane/tray-newest-first -f platform=macos -f backend_mode=local

Gallery before/after for 0058443: 16 states rendered, 26 images differ, 476 more touched states not rendered. Images are in the run's artifact, not on this public PR; the independent review of this head reads them on its own, so the PR needs no hand-made screenshots of these states.

gh run download 41604052484 -R manaflow-ai/cmux -n gallery-advisory-33364-005844339f2dd983bead801c2613937252f98df0 (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.subagent-row-anatomy/done-one Apple System Colors Light unchanged 0% own SubagentTray.tsx
agent-pane.subagent-row-anatomy/done-one Apple System Colors unchanged 0% own SubagentTray.tsx
agent-pane.subagent-row-anatomy/done-task-label Apple System Colors Light unchanged 0% own SubagentTray.tsx
agent-pane.subagent-row-anatomy/done-task-label Apple System Colors unchanged 0% own SubagentTray.tsx
agent-pane.subagent-row-anatomy/running-one Apple System Colors Light changed 0.017% own SubagentTray.tsx
agent-pane.subagent-row-anatomy/running-one Apple System Colors changed 0.0129% own SubagentTray.tsx
agent-pane.subagent-row-anatomy/long-name Apple System Colors Light changed 2.99% own SubagentTray.tsx
agent-pane.subagent-row-anatomy/long-name Apple System Colors changed 0.0136% own SubagentTray.tsx
agent-pane.subagent-row-anatomy/running-stats Apple System Colors Light changed 0.0192% own SubagentTray.tsx
agent-pane.subagent-row-anatomy/running-stats Apple System Colors changed 0.0136% own SubagentTray.tsx
agent-pane.subagent-row-anatomy/mixed Apple System Colors changed 2.18% own SubagentTray.tsx
agent-pane.subagent-row-anatomy/mixed Apple System Colors Light changed 2.18% own SubagentTray.tsx
agent-pane.subagent-tray/geometry Apple System Colors Light changed 0.0103% own SubagentTray.tsx
agent-pane.subagent-tray/geometry Apple System Colors changed 0.0094% own SubagentTray.tsx
agent-pane.subagent-tray/grid-31 Apple System Colors Light changed 0% own SubagentTray.tsx
agent-pane.subagent-tray/grid-31 Apple System Colors changed 0% own SubagentTray.tsx
agent-pane.subagent-tray/panel-two Apple System Colors changed 2.24% own SubagentTray.tsx
agent-pane.subagent-tray/panel-two Apple System Colors Light changed 2.22% own SubagentTray.tsx
agent-pane.subagent-tray/panel-one-running Apple System Colors changed 0.0112% own SubagentTray.tsx
agent-pane.subagent-tray/panel-one-running Apple System Colors Light changed 0.0098% own SubagentTray.tsx
agent-pane.subagent-tray/short-dock Apple System Colors Light changed 0.0652% own SubagentTray.tsx
agent-pane.subagent-tray/short-dock Apple System Colors changed 0% own SubagentTray.tsx
agent-pane.subagent-tray/panel-118 Apple System Colors Light changed 0% own SubagentTray.tsx
agent-pane.subagent-tray/panel-118 Apple System Colors changed 0% own SubagentTray.tsx
agent-pane.subagent-tray/workflow-progress Apple System Colors changed 0.0498% own SubagentTray.tsx
agent-pane.subagent-tray/workflow-progress Apple System Colors Light changed 0.0113% own SubagentTray.tsx
agent-pane.subagent-tray/one-running Apple System Colors changed 0.0095% own SubagentTray.tsx
agent-pane.subagent-tray/one-running Apple System Colors Light changed 0.0094% own SubagentTray.tsx
agent-pane.subagent-tray-head/folded Apple System Colors Light unchanged 0% own SubagentTray.tsx
agent-pane.subagent-tray-head/folded Apple System Colors unchanged 0% own SubagentTray.tsx
agent-pane.subagent-tray-head/open Apple System Colors Light changed 3.36% own SubagentTray.tsx
agent-pane.subagent-tray-head/open Apple System Colors changed 0.818% own SubagentTray.tsx

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

Probably yours: agent-pane-agents-pill.test.ts, agent-pane-working-counts.test.ts, subagent-tray-columns.test.ts and 1 more fails here but not on main's latest full suite. Seen on other PRs too (likely flaky): session-info-dead-clicks.test.tsx. This PR merged before its CI finished: fix forward on main.

CI failed on 005844339f (run 41604053024 attempt 1): 3 code, 1 unknown.

Job Verdict Why
web / react-apps-base-check (8) code a web test failed
web / react-apps-base-check (3) code a web test failed
web / react-apps-base-check (6) code a web test failed
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Failures:

  • new in this PR agent-pane-agents-pill.test.ts by default the running agents sit in the tray above the composer, not in the transcript: failed (job)
  • new in this PR agent-pane-working-counts.test.ts with the tray on, the line counts nothing: the tray lists the same work: failed (job)
  • seen on other PRs session-info-dead-clicks.test.tsx every line of the tray, and its header, does something: failed (job)
  • new in this PR subagent-tray-columns.test.ts expanded tray keeps trailing columns with real durations (Apple System Colors): failed (job)
  • new in this PR subagent-tray-columns.test.ts expanded tray keeps trailing columns with real durations (Apple System Colors Light): failed (job)
Matched log lines
web / react-apps-base-check (8): (fail) by default the running agents sit in the tray above the composer, not in the transcript [1043.16ms]
web / react-apps-base-check (3): (fail) with the tray on, the line counts nothing: the tray lists the same work [1077.13ms]
web / react-apps-base-check (6): (fail) every line of the tray, and its header, does something [25.98ms]

Not re-run automatically: web / react-apps-base-check (8), web / react-apps-base-check (3), web / react-apps-base-check (6), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: web / Web status; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules
red: web / react-apps-base-check (3); NEW webview test reds: test/agent-pane-working-counts.test.ts > with the tray on, the line counts nothing: the tray lists the same work; do not merge until green; see lane-rules
red: web / react-apps-base-check (6); NEW webview test reds: test/subagent-tray-columns.test.ts > expanded tray keeps trailing columns with real durations (Apple System Colors); test/subagent-tray-columns.test.ts > expanded tray keeps trailing columns with real durations (Apple System Colors Light); do not merge until green; see lane-rules
red: web / react-apps-base-check (8); NEW webview test reds: test/agent-pane-agents-pill.test.ts > by default the running agents sit in the tray above the composer, not in the transcript; do not merge until green; see lane-rules
red: web / react-apps-check; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules

Shipped in:

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent opus-5.5): SHIP at 0058443

Rebased onto #32743 (the tray lists only the chat's own sub-sessions); the conflict is one line, and both filters are kept. The tray tests pass at this head (subagent-tray 44/44, names and fixture 7/7).

@teamleaderleo
teamleaderleo merged commit 87ac1a7 into feat-cmux-next Nov 3, 2026
126 of 131 checks passed
@teamleaderleo
teamleaderleo deleted the lane/tray-newest-first branch November 3, 2026 08:40
teamleaderleo added a commit that referenced this pull request Nov 3, 2026
teamleaderleo added a commit that referenced this pull request Nov 3, 2026
… list's view (#33364)

The open list is newest first since #33364, so the row with no Stop (the
oldest, Overnight check) is now below the list's 140px fold; its slot's
center fell on the composer's model chip and the click never reached the
row.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8
teamleaderleo added a commit that referenced this pull request Nov 3, 2026
cmux-bot Bot pushed a commit that referenced this pull request Nov 3, 2026
…29938's live line (#33614)

* base red: the spacing table finds the live line across its lead span (#33241)

#33241 draws the live line's verb in its own span ("Sending" | " message to …"),
so no single text node holds "Sending message to" and step-to-live / live-to-step
measured nothing. The test now finds the live line by its row's text.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8

* base red: the codex live line test reads the live line's column class (#33157)

#33157 gives the live line `cv-worked--live` (its words on the status rows' text
column), so its quiet box renders "cv-worked cv-worked--live is-quiet".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8

* base red: the working-counts tray lists its subagents newest first (#33364)

#33364 orders the open running tray newest first: Tester (spawned after Reviewer)
now leads.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8

* base red: the live permission tests move the turn past the approved call (#33408, #33439)

In a running turn with nothing after it, the latest finished call is lifted onto the
live line (turns.ts liftedStep, #29938), so its row and its Approved mark are not drawn.
#33439 pushed only the call's completion; the tests now push the reply's first words
after it, the state the passing resync test already reaches.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo added a commit that referenced this pull request Nov 3, 2026
…the panel splits Running / Finished (#33341)

* Running tray: the header expands in place or opens Background tasks; the panel splits Running / Finished

The tray's header keeps its expand and #33104's names, and gains a panel
button in the lines' Stop column, right before its chevron, that opens the
chat's Background tasks panel (the ⋯ menu's path, now one shared
openBackgroundPanel). The panel lists its agents under "Running N" and
"Finished N", an ended agent's line shows its duration or Failed, and every
agent and task row opens its transcript with the back chevron, as before.
Arms (panel button, whole header, none) in trayOpen.experiment.ts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-f0cbd725ab08829f1ad0

* gallery: the Background tasks fixture's ended agent completes, so no base center-line red on a failed done line shows in its states

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-f0cbd725ab08829f1ad0

* test: the tray-open test reads the folded bar's newest name, as #33364 settled

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-f0cbd725ab08829f1ad0

* gallery: the Background tasks fixture keeps base's three agents; the panel's new states read Running 2 / Finished 1

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-f0cbd725ab08829f1ad0

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
teamleaderleo added a commit that referenced this pull request Nov 3, 2026
…nd task-named done lines (#33252) (#33600)

* test(webviews): the tray lists newest first (#33364), a done line names its task (#33252)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8

* test(webviews): the tray click check scrolls each target row into the list's view (#33364)

The open list is newest first since #33364, so the row with no Stop (the
oldest, Overnight check) is now below the list's 140px fold; its slot's
center fell on the composer's model chip and the click never reached the
row.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 00584433 Deployed Nov 3, 2026 by teamleaderleo via cmux-tui tree preflight #104968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

leo-named-fix An obvious fix to something Leo named: lands on push, review runs in parallel risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant