Skip to content

docs(defaults guard): name the Tunable helper forms the exact match does not see #33321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lawrencecchen merged 2 commits into from
Nov 3, 2026
Merged

docs(defaults guard): name the Tunable helper forms the exact match does not see #33321

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1965b23
docs(defaults guard): name the Tunable helper forms the exact match d…
lawrencecchen Nov 3, 2026
db5d409
Merge branch 'feat-cmux-next' into docs/defaults-guard-unseen-helpers
cmux-bot[bot] Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion scripts/ci/defaults_guard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,16 @@ def tunable_source_defaults(sources: Mapping[str, str]) -> dict[str, object]:
# declares plus the superclasses and protocols they name, so a subclass reaches its base's helper and a
# conforming type a protocol extension's. A token that only shares the name (`model.toggle()`, a closure
# named `make`, `JSONValue.number`) is not a call of it: that matched every `static func bind` in the app
# (#32983, #32979). Still not resolved: a helper reached through a generic parameter (`T.points`).
# (#32983, #32979). Not resolved (the guard before #33161 caught them by name; no Tunable helper in the tree
# is called this way, 2026-11-03; a Tunable that uses one changes its default with no review):
# - a conformance or superclass declared in another file than the caller (`extension C: HasPoints {}`
# elsewhere, or `extension Sub` in another file than `class Sub: Base`): inheritance is read per file
# - inheritance more than one level deep (`Leaf: Mid`, `Mid: Base`; `protocol Q: HasPoints`)
# - a nested generic clause before the colon (`struct G<T: Collection<Int>>: HasPoints`)
# - a typealias of the helper's type (`typealias CT = ChromeTunables`, then `CT.points`), or a local
# `let T = ChromeTunables.self`
# - a helper reached through a generic parameter (`T.points`)
# A `class func` helper is no node at all (static_declarations reads `static` only).
helper_files: dict[str, set[str]] = {}
for key, (path, kind, name, _) in nodes.items():
if key in selected and kind == "func":
Expand Down
Loading