[lawrencecchen]

Summary

A comment only, in tunable_source_defaults. It lists the forms of Tunable helper call that the exact match from #33161 does not see:

• a conformance or superclass in another file
• inheritance more than one level deep
• a nested generic clause
• a typealias of the helper type, or a local X.self
• a generic T.points
• a class func helper

The #33161 review found these forms. No Tunable helper in the tree is called in these ways today, and the lead decided to leave them.

This edit changes the guard file, so the defaults guard lists it as a change and needs a receipt.

Observed / Not run

python3 tests/test_defaults_guard.py passes (73 tests). prepush-gate.py is clean.

Changelog

none

---

^{Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.}

---

Summary by cubic

Adds a comment in tunable_source_defaults (scripts/ci/defaults_guard.py) documenting the Tunable helper call forms that the exact match from #33161 doesn't see: a conformance or superclass declared in another file, inheritance more than one level deep, a nested generic clause, a typealias or local X.self, a helper reached through a generic parameter (T.points), and a class func helper. No Tunable helper uses these forms today, so they remain unsupported. Editing the guard file also makes the defaults guard list it as a change requiring a receipt.

^{Written for commit db5d409. Summary will update on new commits.}

[github-actions]

cmux status _{(one comment, edited in place; each line is updated by the job that owns it)}

Review 1965b23: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr33321 -f ref=docs/defaults-guard-unseen-helpers -f platform=macos -f backend_mode=local

Default changes

This pull request changes 1 default at db5d4091f4cf (what everyone gets without configuring anything):

• guard.scripts/ci/defaults_guard.py: (none) -> "edited"

Signed off on this commit by review (independent-subagent), carried from 1965b2357d3f across base merges.

Merge receipt: merged as 732ad010ea41 with these defaults changed, signed off by review (independent-subagent), carried from 1965b2357d3f across base merges.

Regenerate the snapshot with python3 scripts/ci/defaults_guard.py snapshot.

Shipped in:

• cmux NEXT nightly 1.0.0-nightly.4161078434801 (732ad010ea)
• cmux NEXT nightly 1.0.0-nightly.4161217392901 (1a7e2c1865)

[lawrencecchen]

Review (independent-subagent): SHIP at 1965b23

• Only a comment changed. All changed lines are # comments, and the AST is identical to feat-cmux-next.
• The six forms in the comment match the defaults guard: a shared helper name is no tunable source (6182 -> 449); an unchecked BLOCK still counts #33161 review findings. "Caught by name before defaults guard: a shared helper name is no tunable source (6182 -> 449); an unchecked BLOCK still counts #33161" is true for the first five. The comment states class func on its own line, and the old guard did not see it either.
• python3 tests/test_defaults_guard.py: 73 tests pass.
• Notes, not blocking: with multiple levels, only the bare call is missed. If an existing Tunable is changed into one of these forms, its fingerprint disappears, so that one change still needs a review.