Skip to content

test(nightly): expect the overtaken conjunct on build-sign-notarize-nightly #33306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teamleaderleo merged 1 commit into from
Nov 3, 2026
Merged

test(nightly): expect the overtaken conjunct on build-sign-notarize-nightly #33306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion tests/test_nightly_universal_build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -906,6 +906,9 @@ NOT_PUBLISHED="needs.resolve-nightly-cmux-tui-client.outputs.already_published !
NOT_CONTINUE="needs.decide.outputs.continue_only != 'true'"
# A nightly-next push that a newer push replaced builds nothing (one build slot, #21917).
NOT_SUPERSEDED="needs.resolve-nightly-cmux-tui-client.outputs.superseded != 'true'"
# A build a newer published build is already above spends no notarization (#33109): the macOS
# signer adds it as one more top-level conjunct, so it only narrows the gate.
NOT_OVERTAKEN="needs.pick-nightly-sign-runner.outputs.overtaken != 'true'"
# The helper, the variant and the macOS signer each exclude build_only with a top-level `&&`.
BUILD_GATE="needs.decide.outputs.should_build == 'true' && $PUBLISH_SCHEDULE && needs.decide.outputs.build_only != 'true' && $NOT_PUBLISHED && $NOT_SUPERSEDED && $NOT_CONTINUE"
# nightly-next's early controls wait for their admission receipt (#30284): the resolver, the
Expand All @@ -918,7 +921,7 @@ SIGN_FALLBACK="!cancelled() && needs.decide.result == 'success' && needs.build-n
if [ "$(job_if build-nightly-app)" != " if: needs.decide.outputs.should_build == 'true' && $PUBLISH_SCHEDULE && $NOT_PUBLISHED && $NOT_SUPERSEDED && $NOT_CONTINUE" ] \
|| [ "$(job_if build-nightly-ghostty-cli-helper)" != " if: needs.decide.outputs.should_build == 'true' && $PUBLISH_SCHEDULE && needs.decide.outputs.build_only != 'true' && $NOT_PUBLISHED && $NOT_SUPERSEDED && $NOT_CONTINUE && $EARLY_ADMISSION" ] \
|| [ "$(job_if prepare-nightly-variant-primary)" != " if: $BUILD_GATE" ] \
|| [ "$(job_if build-sign-notarize-nightly)" != " if: \"$SIGN_FALLBACK && $BUILD_GATE\"" ] \
|| [ "$(job_if build-sign-notarize-nightly)" != " if: \"$SIGN_FALLBACK && $BUILD_GATE && $NOT_OVERTAKEN\"" ] \
|| [ "$(job_if resolve-nightly-cmux-tui-client)" != " if: needs.decide.outputs.should_build == 'true' && $PUBLISH_SCHEDULE && $EARLY_ADMISSION" ] \
|| [ " if: needs.decide.outputs.should_build == 'true' && $PUBLISH_SCHEDULE && $NOT_PUBLISHED && $NOT_SUPERSEDED && $NOT_CONTINUE" != "$(job_if build-nightly-app)" ] \
|| [ "$(job_if publish-nightly)" != " if: \"always() && !cancelled() && needs.decide.result == 'success' && needs.decide.outputs.should_build == 'true' && needs.decide.outputs.fast_build != 'true' && needs.decide.outputs.build_only != 'true' && $PUBLISH_SCHEDULE && $NOT_PUBLISHED && needs.decide.outputs.no_publish != 'true' && (((needs.build-sign-notarize-nightly.result == 'success' || needs.signer-dmg.result == 'success') && needs.build-sign-notarize-nightly.outputs.notary_pending != 'true' && (needs.signer-dmg.result == 'success' || needs.verify-signed-nightly.result == 'success') && needs.verify-final-dmg-nightly.result == 'success' && (needs.verify-final-dmg-nightly.outputs.smoked_in_job == 'true' || !(needs.signer-dmg.result == 'success' && vars.NIGHTLY_NEXT_PARALLEL_SMOKE != 'off' && needs.decide.outputs.track == 'nightly-next') && needs.verify-final-dmg-nightly.outputs.image == '' || needs.launch-smoke-nightly.result == 'success' && needs.verify-final-dmg-nightly.outputs.image != '' && needs.launch-smoke-nightly.outputs.image == needs.verify-final-dmg-nightly.outputs.image)) || (needs.recover-nightly-next-notarization.outputs.accepted == 'true' && needs.verify-recovered-nightly-next.result == 'success'))\"" ]; then
Expand Down
Loading