Repository navigation
test(nightly): expect the overtaken conjunct on build-sign-notarize-nightly - #33306
Merged
Merged
Conversation
…ightly #33109 added needs.pick-nightly-sign-runner.outputs.overtaken != 'true' to the macOS signer's job if:, and test_nightly_universal_build.sh matches that if: verbatim, so the release-notary guard group went red on feat-cmux-next. The conjunct only narrows the gate; build_only stays a top-level exclusion. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-d750cf10922c785efa64
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 3, 2026 07:59 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Collaborator
Author
|
Owned by an agent session · session |
Collaborator
Author
|
Review (subagent claude-opus-5-5): SHIP at 72caefc Ran tests/test_nightly_universal_build.sh at the head (pass); the expected if: matches nightly.yml's build-sign-notarize-nightly line exactly, and build_only stays a top-level conjunct, so the check only got stricter. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes base red: release-notary guard (regressed by #33109)
cmux-next guards / nightly-guards / workflow-guard-tests / release-notaryfailed on feat-cmux-next since 0ca0646 (run 41591687838) with:#33109 added
&& needs.pick-nightly-sign-runner.outputs.overtaken != 'true'tobuild-sign-notarize-nightly's jobif:, andtests/test_nightly_universal_build.shmatches thatif:verbatim. The workflow change is right: the new clause is one more top-level conjunct, so it only narrows the gate and build_only stays excluded. The test was out of date, so this updates the expected string (a namedNOT_OVERTAKENconjunct) and leaves #33109's behaviour alone: only the outer DMG/zip is notarized, and an overtaken build spends no notarization.Verified:
bash tests/test_nightly_universal_build.shpasses locally (exit 0).Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the nightly release-notary guard, which went red after #33109 added an
overtakenconjunct tobuild-sign-notarize-nightly's job gate without updating the test that matches it verbatim.The test now expects the new
NOT_OVERTAKENconjunct. No workflow behavior changes: the new clause only narrows the gate, andbuild_onlyremains a top-level exclusion.Written for commit 72caefc. Summary will update on new commits.