Repository navigation
base red: Cloud start state words hide with no 1 px box (design-token check, after #33139) - #33175
Conversation
… check, after #33139) #33139 (adb7fe3) gave the card its own .visually-hidden with height: 1px, which the design-token ratchet refuses (1px is off the control-height scale). The words sit in the 16 px mark (position: relative); they are clipped to nothing with clip and clip-path, as modelPicker.css's .sr-only does. Red at adb7fe3 and at tip: bun run check:design-tokens new design token violation (1 > 0): agent-session/acpmux/cloudStart.css height height 1px Green here: Design token ratchet passed: 2039 recorded violations. bun test src/agent-session/acpmux/CloudStartView.test.tsx: 15 pass.
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 191abdc; does not block Shipped in:
|
|
Review (independent subagent): SHIP at e819bc4 Checked:
|
|
Found 6 test failures on Blacksmith runners: Failures
|
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Fixes the web-lint red at feat-cmux-next tip (
webviews: bun run check:design-tokens, exit 1). Culprit: #33139 (adb7fe3).Cause
#33139 gave the Cloud start card its own
.visually-hiddenrule withheight: 1px. The design-token ratchet does not allow 1px forheight(it is not on the control-height scale) and the baseline forcloudStart.csshas no 1px height.Takes back #33139: only the 1 px box of its .visually-hidden rule; the words stay hidden for sight and stay for screen readers, so #33139's fix stays.
Fix
The state words stay in the 16 px mark (
position: relative). The rule clips them to nothing withclipandclip-path: inset(50%), with no 1 px box, asmodelPicker.css's.sr-onlydoes. No exception and no baseline change. The words are still in the DOM for screen readers, and they do not draw over the step names.Red at the base, green at the head
Command:
cd webviews && bun run check:design-tokensnew design token violation (1 > 0): agent-session/acpmux/cloudStart.css height height 1pxDesign token ratchet passed: 2039 recorded violations.Changelog
none
Observed / Not run
Observed:
bun run check:design-tokensred and green as above;bun test src/agent-session/acpmux/CloudStartView.test.tsx15 pass (it includes #33139's test that the card hides the words itself);scripts/web-lint.shpassed;prepush-gate.pypassed.Not run: no gallery capture. The change only touches a rule for text that is clipped to nothing.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the design-token violation that made
bun run check:design-tokensfail onfeat-cmux-nextafter #33139.The
.visually-hiddenrule added in #33139 used a1pxheight, which the design-token ratchet rejects. The state words now stay in the 16px mark and are clipped to nothing withclipandclip-path: inset(50%), matchingmodelPicker.css's.sr-onlypattern so no 1px box is needed. The words remain in the DOM for screen readers and no longer draw over the step names.Written for commit e819bc4. Summary will update on new commits.