Repository navigation
Cloud start checklist: state words no longer overlap step names; Starting Claude while it starts - #33139
Conversation
…step names
The row state words (In progress, Waiting) are screen-reader text, but the agent
pane never loads the pages' global .visually-hidden, so they drew in the 16 px
icon column over the step names. The card hides them itself; each row is one
16 px icon column then the name. The harness row reads Starting {harness}
until the harness has started.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Unclear: CI failed on
Not re-run automatically: Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 39ca8ed to compare; do not merge until green; see lane-rules Shipped in:
|
|
Owned by an agent session · session |
|
Found 6 test failures on Blacksmith runners: Failures
|
|
Review (codex, router-review): SHIP at 5c067bb Reviewer: codex gpt-6.1-sol xhigh, fast tier. Follow-ups: 1. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward. SHIP at 5c067bb No correctness regressions found. Catalog generation passed for all 21 locales; component tests could not run because Bun and dependencies are absent.
Follow-ups:
|
… check, after #33139) (#33175) #33139 (adb7fe3) gave the card its own .visually-hidden with height: 1px, which the design-token ratchet refuses (1px is off the control-height scale). The words sit in the 16 px mark (position: relative); they are clipped to nothing with clip and clip-path, as modelPicker.css's .sr-only does. Red at adb7fe3 and at tip: bun run check:design-tokens new design token violation (1 > 0): agent-session/acpmux/cloudStart.css height height 1px Green here: Design token ratchet passed: 2039 recorded violations. bun test src/agent-session/acpmux/CloudStartView.test.tsx: 15 pass.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Leo, 2026-11-02, on the "Starting in Cloud" card's "Initializing session" list: "odd stuff here".
"In progress" and "Waiting" drew over "Set up a Cloud machine", "Clone repository", "Run setup script" and "Started Claude", with "In progress" wrapped and clipped on the left.
Cause: each row's state words are screen-reader text (
.visually-hidden), but the agent pane never loads the pages' global.visually-hiddenrule (webviews/src/styles.css), so the words rendered inside the 16 px icon column and overflowed onto the names. Regressed when the checklist landed (#30386).What changed:
.acpmux-cloud-start .visually-hiddenitself, so each row is one 16 px icon column (spinner running, check done, muted dot waiting, alert failed, ring skipped) then the step name, at the summary's 16 px inset. The words stay for screen readers.cloudStartup.harnessStarting).agent-pane.cloud-start/checklist-harness(running last step) andchecklist-harness-failed; done is the existinginitialized, other failureschecklist-setup-failed.Design spec: design/cloud.md. Risk: CSS and one label key in one card.
Agent session: agent session
🤖 Generated with Claude Code