Skip to content

Cloud start checklist: state words no longer overlap step names; Starting Claude while it starts - #33139

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
leo/cloud-start-status-overlap
Nov 3, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
leo/cloud-start-status-overlap

Conversation

@teamleaderleo

Copy link
Copy Markdown
Collaborator

Leo, 2026-11-02, on the "Starting in Cloud" card's "Initializing session" list: "odd stuff here".

"In progress" and "Waiting" drew over "Set up a Cloud machine", "Clone repository", "Run setup script" and "Started Claude", with "In progress" wrapped and clipped on the left.

Cause: each row's state words are screen-reader text (.visually-hidden), but the agent pane never loads the pages' global .visually-hidden rule (webviews/src/styles.css), so the words rendered inside the 16 px icon column and overflowed onto the names. Regressed when the checklist landed (#30386).

What changed:

  • cloudStart.css hides .acpmux-cloud-start .visually-hidden itself, so each row is one 16 px icon column (spinner running, check done, muted dot waiting, alert failed, ring skipped) then the step name, at the summary's 16 px inset. The words stay for screen readers.
  • The harness row reads "Starting {harness}" until the harness has started, then "Started {harness}" (new key cloudStartup.harnessStarting).
  • Tests: the harness label by state, and the card's own hidden-text rule. Gallery: agent-pane.cloud-start/checklist-harness (running last step) and checklist-harness-failed; done is the existing initialized, other failures checklist-setup-failed.

Design spec: design/cloud.md. Risk: CSS and one label key in one card.

Agent session: agent session

🤖 Generated with Claude Code

…step names

The row state words (In progress, Waiting) are screen-reader text, but the agent
pane never loads the pages' global .visually-hidden, so they drew in the 16 px
icon column over the step names. The card hides them itself; each row is one
16 px icon column then the name. The harness row reads Starting {harness}
until the harness has started.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-3bab30503f0b9a7059e5
@teamleaderleo teamleaderleo added the leo-named-fix An obvious fix to something Leo named: lands on push, review runs in parallel label Nov 3, 2026
@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 5c067bb: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr33139 -f ref=leo/cloud-start-status-overlap -f platform=macos -f backend_mode=local

Gallery before/after for 5c067bb: 16 states rendered, 16 images differ, 1686 more touched states not rendered. Images are in the run's artifact, not on this public PR; the independent review of this head reads them on its own, so the PR needs no hand-made screenshots of these states.

gh run download 41587434121 -R manaflow-ai/cmux -n gallery-advisory-33139-5c067bbee38b033ae34cad4695ecc8b40b468635 (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.cloud-start/checklist-harness Apple System Colors Light new 0% own CloudStartView.gallery.tsx
agent-pane.cloud-start/checklist-harness Apple System Colors new 0% own CloudStartView.gallery.tsx
agent-pane.cloud-start/checklist-harness-failed Apple System Colors Light new 0% own CloudStartView.gallery.tsx
agent-pane.cloud-start/checklist-harness-failed Apple System Colors new 0% own CloudStartView.gallery.tsx
agent-pane.cloud-start/sent Apple System Colors Light changed 2.22% own CloudStartView.gallery.tsx
agent-pane.cloud-start/sent Apple System Colors changed 2.2% own CloudStartView.gallery.tsx
agent-pane.cloud-start/machine Apple System Colors Light changed 2.35% own CloudStartView.gallery.tsx
agent-pane.cloud-start/machine Apple System Colors changed 2.34% own CloudStartView.gallery.tsx
agent-pane.cloud-start/copying Apple System Colors Light changed 2.4% own CloudStartView.gallery.tsx
agent-pane.cloud-start/copying Apple System Colors changed 2.4% own CloudStartView.gallery.tsx
agent-pane.cloud-start/opening Apple System Colors changed 2.45% own CloudStartView.gallery.tsx
agent-pane.cloud-start/opening Apple System Colors Light changed 2.45% own CloudStartView.gallery.tsx
agent-pane.cloud-start/failed Apple System Colors Light changed 2.24% own CloudStartView.gallery.tsx
agent-pane.cloud-start/failed Apple System Colors changed 2.18% own CloudStartView.gallery.tsx
agent-pane.cloud-start/checklist-machine Apple System Colors Light changed 2.65% own CloudStartView.gallery.tsx
agent-pane.cloud-start/checklist-machine Apple System Colors changed 2.61% own CloudStartView.gallery.tsx
agent-pane.url-chip/globe Apple System Colors Light unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/globe Apple System Colors unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/cached-favicon Apple System Colors Light unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/cached-favicon Apple System Colors unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/token-url Apple System Colors Light unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/token-url Apple System Colors unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/pull-request-polished Apple System Colors Light unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/pull-request-polished Apple System Colors unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/pull-request-polished-draft Apple System Colors Light unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/pull-request-polished-draft Apple System Colors unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/pull-request-polished-merged Apple System Colors Light unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/pull-request-polished-merged Apple System Colors unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/pull-request-polished-long-title Apple System Colors Light unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/pull-request-polished-long-title Apple System Colors unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/pull-request-theme-colors Apple System Colors Light unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/pull-request-theme-colors Apple System Colors unchanged 0% names Localizable.xcstrings

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

Unclear: web / react-apps-check (1) failed: no known signature; failed step: Fail on the gate checks. This PR merged before its CI finished: fix forward on main.

CI failed on 5c067bbee3 (run 41587434370 attempt 1): 2 unknown.

Job Verdict Why
web / react-apps-check (1) unknown no known signature; failed step: Fail on the gate checks
web / react-apps-check unknown no known signature; failed step: Check webview test shards

Not re-run automatically: web / react-apps-check (1), web / react-apps-check are not machine failures.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on 39ca8ed to compare; do not merge until green; see lane-rules
red: web / Web status; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules
red: web / react-apps-check; a job it gathers is red on this change (its line here); do not merge until green; see lane-rules
red: web / react-apps-check (1); NEW: green on the base 39ca8ed; do not merge until green; see lane-rules

Shipped in:

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 3, 2026
@teamleaderleo
teamleaderleo merged commit adb7fe3 into feat-cmux-next Nov 3, 2026
131 of 136 checks passed
@teamleaderleo
teamleaderleo deleted the leo/cloud-start-status-overlap branch November 3, 2026 06:04
@blacksmith-sh

blacksmith-sh Bot commented Nov 3, 2026

Copy link
Copy Markdown

Found 6 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmpsz47v9vv/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpz0i6drkx/summary-missing.json (live):/summary-missing.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex, router-review): SHIP at 5c067bb

Reviewer: codex gpt-6.1-sol xhigh, fast tier.

Follow-ups: 1. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward.

SHIP at 5c067bb
Visual verdict: no images; Leo tries the build

No correctness regressions found. Catalog generation passed for all 21 locales; component tests could not run because Bun and dependencies are absent.

  1. [P2] [follow-up] CloudStartView.gallery.tsx:144: Capture the running and failed harness states; no after images were available to verify alignment.

Follow-ups:

lawrencecchen added a commit that referenced this pull request Nov 3, 2026
… check, after #33139) (#33175)

#33139 (adb7fe3) gave the card its own .visually-hidden with height: 1px,
which the design-token ratchet refuses (1px is off the control-height scale).
The words sit in the 16 px mark (position: relative); they are clipped to
nothing with clip and clip-path, as modelPicker.css's .sr-only does.

Red at adb7fe3 and at tip: bun run check:design-tokens
  new design token violation (1 > 0): agent-session/acpmux/cloudStart.css height height 1px
Green here: Design token ratchet passed: 2039 recorded violations.
bun test src/agent-session/acpmux/CloudStartView.test.tsx: 15 pass.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 5c067bbe Deployed Nov 3, 2026 by teamleaderleo via cmux-tui tree preflight #104231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

leo-named-fix An obvious fix to something Leo named: lands on push, review runs in parallel risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant