Skip to content

base red: the queued-row test asks the DOM whether the model picker covers an action #32783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teamleaderleo merged 1 commit into from
Nov 3, 2026
Merged

base red: the queued-row test asks the DOM whether the model picker covers an action #32783

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions webviews/test/agent-pane-queue-row-click.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,12 +472,16 @@ await requireBrowserLane("agent-pane-queue-row-click.test.ts", async () => {
await caughtUp(page, "the cwd fix.");
calls.length = 0;
await openChip(page, CHIPS.model);
// Whatever draws at the action's centre must belong to the open picker: a row, the search
// field, or the menu's own gaps (a separator, its padding), never the queued row. Asked of the
// DOM, not matched on the hit's markup, so a separator over the action counts as the picker's.
for (const action of ['[data-action="steer"]', '[data-action="delete"]', '[data-menu="queued-more"]']) {
const { covered } = await hitAt(page, `${ROW} ${action}`);
expect({ action, inPicker: covered !== null && /acpmux-quick|role="menu/.test(covered) }).toEqual({
action,
inPicker: true,
});
const { x, y } = await hitAt(page, `${ROW} ${action}`);
const inPicker = await page.evaluate(
([px, py]) => document.elementFromPoint(px, py)?.closest(".acpmux-quick-menu, [role=menu]") != null,
[x, y] as const,
);
expect({ action, inPicker }).toEqual({ action, inPicker: true });
}
const { x, y } = await hitAt(page, `${ROW} [data-menu="queued-more"]`);
await page.mouse.move(x, y, { steps: 4 });
Expand Down
Loading