Repository navigation
base red: the queued-row test asks the DOM whether the model picker covers an action - #32783
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
…overs an action The picker still covers a queued row's Steer, trash and more actions, but at their centre the hit is now the menu's own separator, which the test's outerHTML match on acpmux-quick or role=menu did not recognise. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-2f629b93d5a20c58e6f8
b1be004 to
c18f9e3
Compare
|
Review (subagent opus-5.5 medium): SHIP at c18f9e3 Visual verdict: unchanged by this diff (test-only). Checked that the new Follow-ups: [follow-up] |
Fixes the base red at
webviews/test/agent-pane-queue-row-click.test.ts:477: "the model picker covers the row's actions, and a press there stays in the picker" expected{action: '[data-action="steer"]', inPicker: true}and gotinPicker: false(base runs 41537873916 at b32e700, 41539691165, 41551051684, 41552172035, 41552636560).Base-red-job: web / react-apps-check
Cause. No product regression: the picker still covers all three of the row's actions, and a press there still stays in the picker. A diagnostic run on this branch (run 41559053955) showed that, at the centre of Steer, the trash can and ⋯,
elementFromPointnow hits the picker menu's own<div role="separator" class="ui-separator">. It sits in the gap between the menu's note row (y 621–649) and its next row (658), inside.acpmux-quick-menu(589–718), and the row's actions are at y ≈ 642–664. The test decided "in the picker" by regex-matching the hit's outerHTML foracpmux-quickorrole="menu, and a bare separator matches neither. The picker's vertical layout moved and put the separator there. The first base red is at b32e700 (#30879, which changes no web code), so the shift came from the picker/composer layout changes merged just before it. I did not pin down one regressing PR: the REST quota for the host ran out before I could bisect earlier base runs. The model picker's own work (#30194 compact width, #31498 catalog harnesses, by teamleaderleo's lanes) is the likeliest source.Fix. The test now asks the DOM,
elementFromPoint(x, y)?.closest(".acpmux-quick-menu, [role=menu]"), instead of matching markup. A separator or the menu's padding over an action counts as the picker's, and anything from the queued row still fails. The second half of the test (a real press at ⋯ opens no row menu and sends no queue call) is unchanged.Test.
bun test test/agent-pane-queue-row-click.test.tsvia cmux-ci (run 41559958396): 16 pass, 0 fail, chromium and webkit.vp fmt --checkclean.Agent session: agent session
🤖 Generated with Claude Code