Repository navigation
base red: gallery plays wait for what the transcript draws now (gutter gaps, sent rows, reply time) - #32269
Conversation
- gutter-select gap pairs: the drag starts on the upper row's gap target. Since #27580 rows have no bottom padding (the stack places the gap under the row), so the old start point (row bottom - padding/2) landed on the row's content and selected nothing. - sent-message-rows: a turn's run of sends folds into one "Sent N messages" line (#31398); the plays open it after "Worked for". - transcript#agent-messages: opens the message-run line (#31398), then the shell call. - transcript#grid-rhythm-hover: a reply mid-turn draws no action row since #29740 (Copy once per turn); the play hovers the reply and checks none is drawn. - user-bubble#answer-time-tooltip: since #31609 a reply's time is its exact time at the row's end, shown on hover, and its tooltip is the turn's time and tokens; the play waits for the time to show instead of a tooltip with a year. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-ac5053f7854c8635a4d0
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Gallery before/after for
States
Pick other states with a Shipped in:
|
|
Owned by an agent session · session |
|
Found 1 test failure on Blacksmith runners: Failure
|
…it in now; sent rows' shift rows count the run they open - acpmux-batch-send: openTurn opens the "Sent N messages" line (#31398) after Worked for. - message-runs#open: opens a finished turn's Worked for first when the run's line is inside it. - shift-baseline: sent-message-rows sent, look-arrow, look-quote and recorded-file now open one more fold (the run line), which moves the reply and footer below it down 154px, as every fold opening does; their rows take the measured score (PR run 41446958864). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-ac5053f7854c8635a4d0
|
Review (subagent claude-opus-5-5, correctness): SHIP at f5466bd Visual verdict: unchanged by this diff (gallery plays and baseline rows only). Each play now targets what its component draws.
Follow-ups:
|
…ches' shift row counts its run A batch message whose text the transcript never held opens straight to its call (SentMessageLine.tsx), so batch-raw waits for the call itself and clicks Raw only when one is drawn. batches now opens the run line (#31398), which moves the reply below it, so its row takes the measured 0.04078 (PR run 41449180896). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-ac5053f7854c8635a4d0
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
|
Review (subagent opus-5.5 medium): SHIP at a894815 Checked: each play now waits for or clicks what its component draws: the run line, the shell call (behind Raw when the message has words), the row gap target, the reply time revealed on hover, and no action row on a reply mid-turn. The waitFor types match play.ts, and the raised shift rows cover only the extra fold-open step (the rows below move about 154px, as every fold opening does). |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Base red fix: the
gallery healthworkflow reports these gallery states as broken on every full base render. Each play waited for, or pressed, something the transcript no longer draws after recent transcript changes. The components behave as their PRs intend, so the plays now follow what they draw. Nothing goes on the allowlist.agent-pane.gutter-select#*-gap(8 pairs except tool-to-tool) — "Gap drag selected no text"padding-block: 0), so the stack places them under each row. The play started its drag atrow bottom - padding/2, which is now 1px inside the row's content. The press never reached the gap target, sogutterSelect.tsignored it. #31579 repaired the gap target and the browser test, but not this play.[data-transcript-gap="row"]target, or at the nearest point the target itself covers.agent-pane.sent-message-rows#{sent,with-preview,recorded-file,written-file,look-arrow,look-quote}— waitFor.cv-sentopenTurnopens thebutton[data-message-run]line, then waits for.cv-sent.agent-pane.transcript#agent-messages— waitFor.cv-shell__folder.cv-tool.is-togglebecame that line instead of the shell call.agent-pane.transcript#grid-rhythm-hover— waitFor.cv-reply-actionsopacity 1hasReplyActionsis always false: Copy once per turn). The variant was added after that change and waited for a row that is never drawn.agent-pane.user-bubble#answer-time-tooltip— waitFor a tooltip with a yearOnly gallery play files change.
scripts/web-lint.sh --base origin/feat-cmux-nextpasses.Base-red-job: cmux-next / gallery health (0)
Base-red-job: cmux-next / gallery health (1)
Base-red-job: cmux-next / gallery health (2)
Base-red-job: cmux-next / gallery health (3)
Base-red-job: cmux-next / gallery health (4)
Base-red-job: cmux-next / gallery health (5)
Base-red-job: cmux-next / gallery health (6)
Base-red-job: cmux-next / gallery health (7)
Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the gallery plays that
gallery healthreports broken on every full base render — each play waited for or pressed something the transcript no longer draws, and now follows what it draws. Nothing goes on the allowlist.agent-pane.gutter-select#*-gap[data-transcript-gap="row"]target, or the nearest point the target covers.agent-pane.sent-message-rows#*andAcpmuxBatchSend.gallery.tsopenTurnopens the run line after "Worked for"; batch-raw waits for the call itself and clicks Raw only when drawn (a file-read message opens straight to its call);shift-baseline.jsonscores the sent, look, recorded-file, and batches rows' measured shifts.MessageRuns.gallery.ts#openopenLineopens "Worked for" first when the run's line is inside it.agent-pane.transcript#agent-messagesagent-pane.transcript#grid-rhythm-hoveragent-pane.user-bubble#answer-time-tooltipOnly gallery play files and
shift-baseline.jsonchange.scripts/web-lint.sh --base origin/feat-cmux-nextpasses.Written for commit a894815. Summary will update on new commits.