Repository navigation
base red: row-gap drags select again; Retry stage and recap test follow the grid's action row (#27580) - #31579
Conversation
…s stage, the recap test counts the footer band (#27580) #27580 moved transcript gaps out of the rows (padding-block 0) into the virtual stack: - a row gap target (.acpmux-row__gap) inherited the 0 padding, so it was 0 tall and a drag from between two rows selected nothing. RowFrame now gives it the placed gap under its row. - a prompt action row is laid in the turn gap under its row; the Retry gallery stage is a div with styles.css paint containment, which clipped it away. The stage keeps layout containment alone, as article rows do in the app. - the rest gap starts under the turn footer band (transcriptGrid.ts restBand); the recap card test sized its pane without that band. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-ac5053f7854c8635a4d0
…ngs on screen (#27580) The stage div took .acpmux-row's --cv-inset as a relative offset plus its own padding, so the action row #27580 lays in the gap (right: -6) landed past the 560px viewport and the click on Retry hit nothing. The inset is a wrapper's now and the row's offset is cleared. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-ac5053f7854c8635a4d0
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Stale: these images are of Gallery before/after for
States
Pick other states with a Passes: CI passes on CI passes on Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: Shipped in:
|
|
Owned by an agent session · session |
|
Found 6 test failures on Blacksmith runners: Failures
|
Review BLOCK at 8ab2e42: the gap span came after the row content at z-index 0, so it covered the prompt and footer action rows #27580 lays in the gap and took their clicks. It now sits at z-index -1 inside the row (an article with layout containment is its stacking context). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-ac5053f7854c8635a4d0
|
Review (codex gpt-6.1-sol high, sweep, via the review router; full diff from merge base c0b3866 to this head): BLOCK at 855ea57 [P2] [blocking] files/webviews/src/agent-session/acpmux/App.tsx:2295 - The gap target is positioned at |
…z-index check:layers refuses a raw z-index, and vp fmt the long style line. The gap span now precedes the row content, so the action rows laid in the same gap, positioned later in the row, paint and hit-test over it (positioned boxes at one level stack in tree order). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-ac5053f7854c8635a4d0
|
Awareness note from an agent lane that does not own this PR; it is not a review or a request to take the PR over. For awareness: this restores Leo ask-4ef8ccaaeb (drag-select from the dead zones between transcript rows), first delivered by #26704 and regressed by #27580. Please add |
|
Review (codex gpt-6-astra high, next-review): BLOCK at dfbe9ce BLOCK at dfbe9ce Visual verdict: no images; Leo tries the build [follow-up]
Follow-ups: none |
…the placed gap under it The webview verdict at dfbe9ce named transcript-gap-select-browser's RTL tests (4) as this PR's own: they pad a row by 64 and expect its gap target over that padding, which the placed-gap style had replaced. The target keeps its inherited padding and extends below the row by the placed gap (content-box), so it covers everything from the row's content to the next row. The test now checks that span: the padding's top to the next row's top. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-ac5053f7854c8635a4d0
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Base reds from #27580 (ours), which moved the transcript's gaps out of the rows into the virtual stack and lays a prompt's action row in the turn gap (design/grid.md 5.5). Each test below passes on #31384 (only #27580 reverted) and fails on feat-cmux-next:
transcript-gutter-select-browser.test.ts"a drag from each row gap starts at its nearest mounted caret", chromium and webkit; gallery: "Gap drag selected no text")..acpmux-row__gaptook its height from the row's padding, which is now 0, so a drag from between two rows selected nothing. RowFrame gives it the placed gap under its row (tops[i+1] - tops[i] - heights[i]). User-visible fix.retry-model-menu.test.ts, 8 tests). The stage div took.acpmux-row's--cv-insetas a relative offset plus its own padding, so the action row laid in the gap (right: -6) landed past the 560px viewport. The stage's inset is now a wrapper's; the row clears its offset and keeps layout containment only, as article rows do. Fixture-only.agent-pane-recap-card.test.ts"the card leaves the turn's footer in view above it"). The rest gap starts under the turn footer's band (transcriptGrid.ts restBand), and the test sized the pane without it. Test-only.Tests: red at base (CI run 41362440478 and cmux-ci at 0dbfb2e/c0b3866c), green at this head (cmux-ci, all 3 files).
Not in this PR:
agent-pane-stream-jitter(reply moves 26 = restBand when a turn ends) andstreaming-text-framesp95 are still red at base. They need a design call on where the live line's room goes when the footer arrives.Risk: small. One inline style on the gap target, a gallery fixture, and a test.
Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes three regressions from #27580, which moved transcript gaps out of rows into the virtual stack and lays a prompt's action row in the turn gap.
RowFramesizes the gap target from the row's own bottom padding plus the placed gap under it (down to the next row), instead of inheriting the row's now-zero padding. It comes before the row content, so the action rows laid in the same gap paint and hit-test over it.transcriptGrid.ts restBand.Written for commit 524c6a9. Summary will update on new commits.