Skip to content

Agent chat: a started chat names every pull request on its own, no "and N more" - #32183

Merged
teamleaderleo merged 3 commits into
feat-cmux-nextfrom
lane/started-card-every-pr
Nov 2, 2026
Merged

teamleaderleo merged 3 commits into
feat-cmux-nextfrom
lane/started-card-every-pr

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Leo (2026-10-31): "this +11 is really bad you guys should just render them all separately".

Leo-ask: ask-815b78fca8

The PR chip row with the "+11" he said that of was taken out entirely on his later, explicit order (#29614, "remove the chips"), and this PR does not bring it back. The one place in cmux NEXT that still folded a chat's pull requests into a count was the started chat's status line (its row in the transcript's started-chats card and its hover card): cmux #22092 and 1 more. It now names every pull request on its own, cmux #22092 · cmux #22093 · ..., and wraps onto more lines instead of clipping.

  • startedSessions.ts: StartedPullRequests.others lists every PR but the named one, newest first (a branch PR whose number more than one repository has still counts once).
  • SessionStatusLine.tsx: draws each as its own span; the started.morePullRequests string goes.
  • startedSessions.css: the PR group wraps; the status stays on the first line.
  • Tests: a chat with twelve PRs names all twelve and has no "+N" or "more".

Risk: small, one component (a chat with many PRs makes its row taller). Behind nothing new; the started-session cards keep their experiment.

Agent session: agent session

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Names every pull request a started chat opened on its own instead of folding extras into an “and N more” count. A multi-PR chat now renders cmux #22092 · cmux #22093 · … and wraps onto more lines instead of clipping, so the status line never hides PRs behind a count.

  • Drops the started.morePullRequests string and its translations; StartedPullRequests.others lists each PR but the named one.
  • Other PRs are keyed by place since a fork and its upstream can share a repo #N.

Written for commit d2dba62. Summary will update on new commits.

View guided diff Turn on auto-fix

… no "and N more"

Leo (2026-10-31): "this +11 is really bad you guys should just render them
all separately". The PR chip row he said it of was removed on his later
order (#29614); the started chat's status line was the last place that still
folded a chat's pull requests into a count. It now names each one
(`cmux #22092 · cmux #22093 · ...`), wrapping onto more lines instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-1811af59a5bf16d868b8
@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review d2dba62: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr32183 -f ref=lane/started-card-every-pr -f platform=macos -f backend_mode=local

Gallery before/after for d2dba62: 16 states rendered, 6 images differ, 2986 more touched states not rendered. Images are in the run's artifact, not on this public PR; the independent review of this head reads them on its own, so the PR needs no hand-made screenshots of these states.

gh run download 41439109028 -R manaflow-ai/cmux -n gallery-advisory-32183-d2dba624603a3b40ffe2b592a8f087dfdf4d75bc (then read gallery-review.json)

States
State Theme Status Diff Picked by
agent-pane.session-hover/states Apple System Colors Light changed 0.358% own SessionHoverCard.gallery.tsx
agent-pane.session-hover/states Apple System Colors changed 0.348% own SessionHoverCard.gallery.tsx
agent-pane.session-hover/reply Apple System Colors Light unchanged 0% own SessionHoverCard.gallery.tsx
agent-pane.session-hover/reply Apple System Colors unchanged 0% own SessionHoverCard.gallery.tsx
agent-pane.session-hover/chip Apple System Colors Light unchanged 0% own SessionHoverCard.gallery.tsx
agent-pane.session-hover/chip Apple System Colors unchanged 0% own SessionHoverCard.gallery.tsx
agent-pane.session-link-chip/theme Apple System Colors Light unchanged 0% own startedSessions.css
agent-pane.session-link-chip/theme Apple System Colors unchanged 0% own startedSessions.css
agent-pane.session-link-chip/accent Apple System Colors Light unchanged 0% own startedSessions.css
agent-pane.session-link-chip/accent Apple System Colors unchanged 0% own startedSessions.css
agent-pane.session-link-chip/quiet Apple System Colors Light unchanged 0% own startedSessions.css
agent-pane.session-link-chip/quiet Apple System Colors unchanged 0% own startedSessions.css
agent-pane.session-link-chip/link-blue Apple System Colors Light unchanged 0% own startedSessions.css
agent-pane.session-link-chip/link-blue Apple System Colors unchanged 0% own startedSessions.css
agent-pane.started-sessions/two Apple System Colors Light changed 1.4% own StartedSessionCard.gallery.tsx
agent-pane.started-sessions/two Apple System Colors changed 1.37% own StartedSessionCard.gallery.tsx
agent-pane.started-sessions/states Apple System Colors Light unchanged 0% own StartedSessionCard.gallery.tsx
agent-pane.started-sessions/states Apple System Colors unchanged 0% own StartedSessionCard.gallery.tsx
agent-pane.started-sessions/harnesses Apple System Colors Light changed 0.0287% own StartedSessionCard.gallery.tsx
agent-pane.started-sessions/harnesses Apple System Colors changed 0.0287% own StartedSessionCard.gallery.tsx
agent-pane.url-chip/globe Apple System Colors Light unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/globe Apple System Colors unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/cached-favicon Apple System Colors Light unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/cached-favicon Apple System Colors unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/token-url Apple System Colors Light unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/token-url Apple System Colors unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/pull-request-polished Apple System Colors Light unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/pull-request-polished Apple System Colors unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/pull-request-polished-draft Apple System Colors Light unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/pull-request-polished-draft Apple System Colors unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/pull-request-polished-merged Apple System Colors Light unchanged 0% names Localizable.xcstrings
agent-pane.url-chip/pull-request-polished-merged Apple System Colors unchanged 0% names Localizable.xcstrings

Pick other states with a Gallery: entry.id, entry.id/variant line in the PR body.

web and size checks: green

Shipped in:

@github-actions github-actions Bot added the risk:normal Risk tier (docs/ci/risk-tiers.md) label Nov 2, 2026
@blacksmith-sh

blacksmith-sh Bot commented Nov 2, 2026

Copy link
Copy Markdown

Found 6 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp0u4mk35x/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmpm1b925ex/summary-fail.json (live):/summary-fail.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-1811af59a5bf16d868b8
…review follow-ups)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-1811af59a5bf16d868b8
@teamleaderleo
teamleaderleo merged commit 18e36f5 into feat-cmux-next Nov 2, 2026
173 of 174 checks passed
@teamleaderleo
teamleaderleo deleted the lane/started-card-every-pr branch November 2, 2026 11:49
@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (subagent claude-opus-5-5 medium): SHIP (read at the previous head; its two follow-ups are fixed at d2dba62)

Visual verdict: no images; one status line now lists each PR instead of "and N more" (wraps when long).
Checked others.length === count - 1 in every branch of startedPullRequests (no branch PR, branch PR matching one, none, or several repos), the twelve-PR test's order, no remaining started.morePullRequests reference, and that the single-line layout is unchanged.
Follow-ups: both fixed at d2dba62 (keys by place, since a fork and its upstream can share repo #N; gallery indent). fmt, lint and the started/hover tests pass there.

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex gpt-6-astra high, sweep, via the review router; full diff from merge base b37e903 to this head): SHIP at 14d5605

No P1/P2 findings.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — d2dba624 Deployed Nov 2, 2026 by teamleaderleo via cmux-tui tree preflight #100985
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant