Repository navigation
perf-gate: new-row late frames are a known breach; debug popup snapshot allowed - #22093
Conversation
…ug popup snapshot is a debug tool feat-cmux-next's perf gate went red after #21825: 3-6 of 50 new workspace rows commit one frame late on the mini (the list's insert commit runs 34-39 ms at p99), and DebugPopups.swift's window snapshot trips the source guard. Up to 8 late rows now warn with the bead; more fail, and a run with none fails until the KNOWN line goes. walks 0 stays blocking. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Receipt for
|
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryUpdates the performance gate to allow the documented late-row breach while keeping a limit on it.
Review used source inspection; no runtime checks were run. Reviews (1) · Last reviewed commit: "perf-gate: new-row late frames are a kno..." · Reviewed by Greptile |
|
Script-only change, reviewed by hand: the KNOWN entry and its ratchet use the gate's existing |
|
Shipped in:
|
…nd N more" (#32183) * Agent chat: a started chat's row names every pull request on its own, no "and N more" Leo (2026-10-31): "this +11 is really bad you guys should just render them all separately". The PR chip row he said it of was removed on his later order (#29614); the started chat's status line was the last place that still folded a chat's pull requests into a count. It now names each one (`cmux #22092 · cmux #22093 · ...`), wrapping onto more lines instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-1811af59a5bf16d868b8 * Agent chat: format the started-chat PR tests Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-1811af59a5bf16d868b8 * Agent chat: key a started chat's other PRs by place; gallery indent (review follow-ups) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-1811af59a5bf16d868b8 --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
The cmux-next perf gate has been red on feat-cmux-next since #21825 merged, for two reasons:
new_workspacesscenario, 3 to 6 of the 50 new rows commit one frame late on the mini. The row itself is drawn from the press with no walk (walks0 in every run), but the list's commit of the insert takes 34 to 39 ms at p99 once there are 33 to 70 workspaces. This happened in feat-cmux-next runs 39292677937, 39296303954 and 39300730843.DebugPopups.swift's window snapshot trips the source guard. It's a debug tool, like theControl/Debug*files already exempted.Changes:
KNOWNbreach. It warns and names cx-zf6um; more than 8 fails. Once a full run shows no late rows, the ratchet fails until theKNOWNline is removed.walks0 stays blocking.DebugPopups.swiftjoins the capture allowlist.Fixing the slow insert commit is the follow-up under cx-zf6um.
Testing
Script-only change; it parses. The scheme compile job on this PR runs the gate. Before this change, the gate's output on base showed exactly these two failures.
Changelog
none
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the cmux-next perf gate being red on
feat-cmux-nextfor two failures: late new-row commits and the debug popup snapshot source guard.cx-zf6um; more than 8 still fails, andwalks0 stays blocking.DebugPopups.swiftto the capture allowlist since its window snapshot is a debug tool like the already-exemptedControl/Debug*files.Script-only change; the gate runs on this PR's compile job and showed exactly these two failures on base.
Written for commit 7ab172d. Summary will update on new commits.