Skip to content

base red: CloudApprovalsPrepareTests imports Foundation for UUID (#31904) - #31979

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/swift-red-cloud-approvals-import
Nov 2, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
lane/swift-red-cloud-approvals-import

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Base-red-job: cmux-next swift test

The CmuxNext test target stopped building at a799d97 (#31904). CloudApprovalsPrepareTests.swift uses UUID without importing Foundation. Tip Swift suite run https://github.com/manaflow-ai/cmux/actions/runs/41406584872 failed at "Build package and tests" with cannot find 'UUID' in scope at lines 18, 34 and 50. This hides every Swift test verdict on base.

Fix: add import Foundation. The change is one line in one test file.

Observed / Not run

  • The CmuxNext package compile check at this head passed.
  • I'm not sure that check builds the test target, so the PR's own "cmux-next swift test" build step is the real evidence.
  • prepush-gate: no new violations.

Changelog

none

Agent session: agent session

🤖 Generated with Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the CmuxNext test target build so Swift test verdicts on base are no longer hidden. CloudApprovalsPrepareTests.swift used UUID without importing Foundation, causing cannot find 'UUID' in scope errors; the fix adds the missing import Foundation.

Written for commit eda69ce. Summary will update on new commits.

View guided diff Turn on auto-fix

)

The test target stopped building at a799d97: CloudApprovalsPrepareTests.swift
uses UUID with no Foundation import (tip Swift suite run 41406584872, Build package
and tests: cannot find 'UUID' in scope at :18, :34, :50).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-9124da39adbff74677d9
@cursor

cursor Bot commented Nov 2, 2026

Copy link
Copy Markdown

Bugbot needs on-demand usage enabled

Bugbot uses usage-based billing for this team and requires on-demand usage to be enabled.

A team admin can enable on-demand usage in the Cursor dashboard.

@teamleaderleo teamleaderleo left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (claude-sonnet-5-5 subagent): SHIP at eda69ce

Review (subagent claude-sonnet-5-5): SHIP at eda69ce. Diff is exactly one added line (import Foundation); the only Foundation symbol used is UUID (3 uses), no Date/URL/Data etc. Many sibling tests import Foundation the same way.

@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review eda69ce: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr31979 -f ref=lane/swift-red-cloud-approvals-import -f platform=macos -f backend_mode=local

Not verified: macOS jobs did not run: compile and app tests were skipped on eda69ce993; ci-status is green without them.

CI passes on eda69ce993 (run 41408824546 attempt 1).
macOS jobs did not run: compile and app tests were skipped: Fast static checks skipped (the macos job needs both to succeed). Re-run CI once they pass, before merging.

Written by scripts/ci/classify_failures.py (ci-failure-attribution.yml); signatures are its SIGNATURES table. A machine verdict is the runner's fault, not this PR's; yours means the failing file is one this PR changes, also red on main that main's latest full suite fails the same way, seen on other PRs that it failed on another pull request's run lately.

Shipped in:

@teamleaderleo
teamleaderleo merged commit 79813dd into feat-cmux-next Nov 2, 2026
104 of 116 checks passed
@teamleaderleo
teamleaderleo deleted the lane/swift-red-cloud-approvals-import branch November 2, 2026 07:50
@github-actions github-actions Bot added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 2, 2026

This branch was previously deployed

1 inactive deployment
ci-routing-agent — eda69ce9 Deployed Nov 2, 2026 by teamleaderleo via namespace autofix #12115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant