Skip to content

base red: CloudApprovalsPrepareTests imports Foundation (compile red from #31904) - #31976

Closed
lawrencecchen wants to merge 1 commit into
feat-cmux-nextfrom
fix/base-red-31904-foundation
Closed

lawrencecchen wants to merge 1 commit into
feat-cmux-nextfrom
fix/base-red-31904-foundation

Conversation

@lawrencecchen

Copy link
Copy Markdown
Contributor

Summary

Packages/macOS/CmuxNext/Tests/CmuxNextAppTests/CloudApprovalsPrepareTests.swift came with #31904 (a799d97). It uses UUID but did not import Foundation, so the CmuxNextAppTests target does not compile at the feat-cmux-next tip.

Before (tip watcher at 5678105, job af03529fb153139d9943b2e0):

Packages/macOS/CmuxNext/Tests/CmuxNextAppTests/CloudApprovalsPrepareTests.swift:18:47: error: cannot find 'UUID' in scope

This PR adds import Foundation in the same import order as the other CmuxNextAppTests files. No other change.

After: fleet compile-check d1026f606ce83d90543a1ec4 (--package CmuxNext, with tests) at d17b301. Result: pending, updated below.

Changelog

none

Observed / Not run

Observed:

  • python3 scripts/cmux-next/prepush-gate.py: no new violations.
  • Fleet compile-check d1026f606ce83d90543a1ec4: pending.
  • Fleet suite step 5a94777b5c01c54072f5e01a (run-swift-testing-suites.sh, CMUX_SWIFT_TEST_SUITES=CloudApprovalsPrepareTests): pending.

Not run:

  • No regression test added: the compile of the test target is the check.
  • No app build or dogfood build (test-only change).

…from #31904)

CloudApprovalsPrepareTests.swift (added in #31904, a799d97) uses UUID
but did not import Foundation, so CmuxNextAppTests failed to compile at the
feat-cmux-next tip (tip watcher at 5678105, job af03529fb153139d9943b2e0):

  CloudApprovalsPrepareTests.swift:18:47: error: cannot find 'UUID' in scope

Add the import in the same order as the other CmuxNextAppTests files.
@lawrencecchen lawrencecchen added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review d17b301: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr31976 -f ref=fix/base-red-31904-foundation -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: bash scripts/cmux-next/tests/pin-cmux-tui-linux-fetch.test.sh (+1 more) is not red on the base 69190e4; do not merge until green; see lane-rules

@blacksmith-sh

blacksmith-sh Bot commented Nov 2, 2026

Copy link
Copy Markdown

Found 6 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp95f8ptzh/summary-missing.json (live):/summary-missing.json (live): View Logs
/tmp/tmp9xt81p8v/summary-fail.json (live):/summary-fail.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@teamleaderleo

Copy link
Copy Markdown
Collaborator

Review (subagent claude-opus-5-5 medium): SHIP at d17b301 — one added import Foundation in a test file that uses Foundation types; no behaviour change. The red cmux-next checks job (god files, concurrency, l10n…) can't be caused by a test import and is base red.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Superseded by #31979 (same fix, merged first)

This branch was previously deployed

1 inactive deployment
ci-routing-agent — d17b3017 Deployed Nov 2, 2026 by lawrencecchen via namespace autofix #12110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants