Repository navigation
base red: CloudApprovalsPrepareTests imports Foundation (compile red from #31904) - #31976
lawrencecchen wants to merge 1 commit into
Conversation
…from #31904) CloudApprovalsPrepareTests.swift (added in #31904, a799d97) uses UUID but did not import Foundation, so CmuxNextAppTests failed to compile at the feat-cmux-next tip (tip watcher at 5678105, job af03529fb153139d9943b2e0): CloudApprovalsPrepareTests.swift:18:47: error: cannot find 'UUID' in scope Add the import in the same order as the other CmuxNextAppTests files.
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); NEW: |
|
Found 6 test failures on Blacksmith runners: Failures
|
|
Review (subagent claude-opus-5-5 medium): SHIP at d17b301 — one added |
|
Superseded by #31979 (same fix, merged first) |
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
Summary
Packages/macOS/CmuxNext/Tests/CmuxNextAppTests/CloudApprovalsPrepareTests.swiftcame with #31904 (a799d97). It usesUUIDbut did not import Foundation, so theCmuxNextAppTeststarget does not compile at the feat-cmux-next tip.Before (tip watcher at 5678105, job
af03529fb153139d9943b2e0):This PR adds
import Foundationin the same import order as the otherCmuxNextAppTestsfiles. No other change.After: fleet compile-check
d1026f606ce83d90543a1ec4(--package CmuxNext, with tests) at d17b301. Result: pending, updated below.Changelog
none
Observed / Not run
Observed:
python3 scripts/cmux-next/prepush-gate.py: no new violations.d1026f606ce83d90543a1ec4: pending.5a94777b5c01c54072f5e01a(run-swift-testing-suites.sh,CMUX_SWIFT_TEST_SUITES=CloudApprovalsPrepareTests): pending.Not run: