Repository navigation
fix(ci): refresh runner capacity after nightly admission waits - #31891
Merged
Merged
Conversation
Co-Authored-By: OpenAI GPT-6.1 Sol <noreply@openai.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-44e895a13a32951aa9ae
Use shared repository state for the archive picker first look and preserve repository-only scope. DEV placement rechecks bypass the fixed workflow document after waiting. Co-Authored-By: OpenAI GPT-6.1 Sol <noreply@openai.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-44e895a13a32951aa9ae
Co-Authored-By: OpenAI GPT-6.1 Sol <noreply@openai.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-44e895a13a32951aa9ae
Retain the shared-state first look, then bypass the fixed workflow observation when portable, control and dedicated build pickers recheck busy capacity. Co-Authored-By: OpenAI GPT-6.1 Sol <noreply@openai.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-44e895a13a32951aa9ae
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 2, 2026 06:02 — with
GitHub Actions
Inactive
Base automatically changed from
lane/runner-state-live-rechecks
to
feat-cmux-next
November 2, 2026 06:11
Collaborator
Author
|
Review (subagent claude-opus-5-5 medium): SHIP at a504c64 Checked: in portable_job_placement.main, nightly_next_control_runner.choose and the nightly_build_runner dedicated wait, the first look uses the document and every look after a sleep reads live. The idle path makes zero calls, and a missing or stale document behaves as before. Only scripts and tests change. Tests pass (portable 38, nightly_build_runner 59, nightly_next_control_runner 11), and the new ones fail at test-only 8ec0edd. Follow-ups:
|
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Shipped in:
|
This was referenced Nov 2, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Portable placement, nightly control admission and the dedicated nightly build wait can reuse a workflow's fixed runner document after sleeping. A busy-to-idle transition is then invisible until overflow or timeout.
Keep the shared document for the first look and request live runner capacity after each existing wait. Injected test readers keep their existing call contract. This extends the first-look policy in #31889 and depends on its shared client option; this PR is stacked on that branch.
Performance
The live recheck trades requests for correctness only after capacity was unavailable. No new timer or wait is introduced; existing waits retain their deadlines and cleanup. This table models the named fixture rate, not total installation traffic. No compilation or cache behavior changes.
Observed / Not run
All 38 portable placement, 11 nightly control and 59 nightly build tests pass. The three new busy-document regressions fail at test-only commit 8ec0edd and pass with the fix. git diff --check passes. No application build is needed for these picker reads.
Changelog
none
Agent session: agent session
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes nightly admission waits reusing a workflow's fixed runner document after sleeping, so a busy-to-idle transition no longer stays invisible until overflow or timeout.
Portable placement, nightly control, and the dedicated nightly build picker now keep the shared document only for their first look, then request live runner capacity on each recheck. Runners that become idle during the existing wait window are now found at the first recheck instead of after overflow or timeout, and no new timers or waits are introduced. Injected test readers keep their existing call contract.
Written for commit a504c64. Summary will update on new commits.