Repository navigation
ci: route nightly tick controls through fleet picker - #30509
teamleaderleo wants to merge 2 commits into
Conversation
Bugbot needs on-demand usage enabledBugbot uses usage-based billing for this team and requires on-demand usage to be enabled. A team admin can enable on-demand usage in the Cursor dashboard. |
d8aee23 to
1abca6c
Compare
|
Found 45 test failures on Blacksmith runners: Failures
...and 35 more test failures. View all on Blacksmith
|
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
red: cmux-next checks (god files, concurrency, crash safety, l10n); no finished base run on c026ef2 to compare; do not merge until green; see lane-rules |
|
Orphaned: only the sweep's base merge since, and no lane holds a lease on it. The orphan sweep could not merge |
|
Owned by an agent session · session |
|
Held, not resolved: the HOLD (main-source live admission for CI_CONTROL_RUNNER) must land first, and base since moved both runs-on lines to declared pool reads (#32457, |
|
Still held, left as is. State on current base: the dead-pin problem this PR fixed (the tick's literal |
|
Superseded by #32457: base's tick and feed-watch jobs no longer pin a single Blacksmith label; they resolve from the declared runner pool (fromJSON(vars.RUNNER_POOLS).linux_2 / linux_4). This PR's only remaining hunk (vars.CI_CONTROL_RUNNER || 'ubuntu-24.04') and its test would undo that pool design and trip the hosted-runner guard. The HOLD's outstanding work, wiring the live-admission picker (scripts/ci/nightly_next_control_runner.py) into these workflows, is not on base yet and belongs in its own PR built on the runner-pool design. |
#35630) #30657 added scripts/ci/nightly_next_control_runner.py and nightly_next_control_rescue.py as a helper-only prerequisite for #30509, which closed in favour of the runner-pool design (#32457). No workflow on feat-cmux-next or main calls either; only their own tests, a pool test and the test registry named them. The tick already picks its runner from RUNNER_POOLS. Agent-Session: https://cmux.com/deeplink/agent?id=aid-f08996319b14c7281027 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
HOLD: main-source live admission repair is incomplete; the current head must not land.
The nightly-next tick request job was pinned to
blacksmith-2vcpu-ubuntu-2404; run 41286823037 remained queued while that pool admitted nothing. The tick and feed-watch control jobs now use the liveCI_CONTROL_RUNNERpicker result first and fall back to hosted Ubuntu under the declared light Linux exception. The CI routing test rejects the old Blacksmith pin across all nightly-next control workflows.Validation:
PYTHONPATH=tests python3 -m unittest tests.test_ci_nightly_off_blacksmith(11 passed, 1 skipped)git diff --checkagent-identity footer --repo manaflow-ai/cmux
agent session
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
The nightly-next tick request job stayed queued because it was pinned to
blacksmith-2vcpu-ubuntu-2404, a pool that admitted nothing (run 41286823037). The tick and feed-watch control jobs now use the liveCI_CONTROL_RUNNERfleet-picker result first and fall back to hosted Ubuntu as the light-linux exception.Bug Fixes
Written for commit 543e915. Summary will update on new commits.