Skip to content

base red: tooling-tests registry, test_ci_overflow_pick_reads_pool.py (#30878) becomes manual - #31065

Merged
lawrencecchen merged 1 commit into
feat-cmux-nextfrom
fix/base-red-registry-1101d
Nov 1, 2026
Merged

lawrencecchen merged 1 commit into
feat-cmux-nextfrom
fix/base-red-registry-1101d

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

tooling-tests is red on every feat-cmux-next PR (seen on #31013). The registry check fails with:

tests/test_ci_overflow_pick_reads_pool.py: linux-guard lane is not run by any workflow   (#30878)

#30878 registered this test as linux-guard but added no ci-guards.yml step that runs it. CLAUDE.md does not allow new CI tests (Lawrence 2026-10-23). So the test becomes lane = "manual", with the command to run it, as #30624 and #30872 did for earlier tests.

Side effect: the nightly-next car guards (car_guards.py, focused_tests.py) run only linux-guard tests. Before this PR they could pick this test when a car changed a workflow it names. As a manual test it is not run there. The only way to keep it in that lane is a new CI step, which CLAUDE.md does not allow. #30624 and #30872 had the same effect.

Red and green

  • python3 scripts/ci/validate_test_execution_registry.py --pr-lanes feat-cmux-next --base-sha HEAD: exit 1 at the feat tip, exit 0 at this head (601 tests).
  • test_ci_test_execution_registry.py and test_pr_lane_coverage.py: OK.
  • The test itself passes (about 2 s).

Observed / Not run

  • Observed: the commands above.
  • Not run: nothing else is needed; this PR changes only the registry.

Changelog

none

… registered as linux-guard becomes manual

validate_test_execution_registry.py --pr-lanes feat-cmux-next failed on every pull request
(seen on #31013):
  tests/test_ci_overflow_pick_reads_pool.py: linux-guard lane is not run by any workflow
#30878 (da249ca) registered it as linux-guard and added no ci-guards.yml step. CLAUDE.md
forbids new CI tests (Lawrence 2026-10-23), so it becomes a manual entry with its run
command, as #30624 and #30872 did. The test passes (about 2 s).

Red at 9dee26d: python3 scripts/ci/validate_test_execution_registry.py --pr-lanes feat-cmux-next --base-sha HEAD   exit 1
Green here: same command, exit 0.
@lawrencecchen lawrencecchen added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 4d368eb: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr31065 -f ref=fix/base-red-registry-1101d -f platform=macos -f backend_mode=local

Shipped in:

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Review (subagent, correctness first): SHIP at 4d368eb

What the reviewer confirmed:

  • At origin/feat-cmux-next 69104a3, the validator fails on exactly this entry.
  • No workflow runs the file. The ci-guards tests/*.py step only compiles it, and the discovery runners point at other folders.
  • At this head, the validator exits 0 (601 tests). The registry tests pass (34 and 17).
  • The reason is accurate, and the test passes (4 tests, 2.4 s).

Note: the car guards no longer pick this test, because they run only linux-guard tests. This is now stated in the description.

@lawrencecchen lawrencecchen added the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Nov 1, 2026
@lawrencecchen
lawrencecchen merged commit 6dee40a into feat-cmux-next Nov 1, 2026
204 of 223 checks passed
@lawrencecchen
lawrencecchen deleted the fix/base-red-registry-1101d branch November 1, 2026 15:49

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 4d368eb6 Deployed Nov 1, 2026 by lawrencecchen via wait for same-key tree publisher #96711
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant