Repository navigation
base red: tooling-tests registry, test_ci_overflow_pick_reads_pool.py (#30878) becomes manual - #31065
Merged
Merged
Conversation
… registered as linux-guard becomes manual validate_test_execution_registry.py --pr-lanes feat-cmux-next failed on every pull request (seen on #31013): tests/test_ci_overflow_pick_reads_pool.py: linux-guard lane is not run by any workflow #30878 (da249ca) registered it as linux-guard and added no ci-guards.yml step. CLAUDE.md forbids new CI tests (Lawrence 2026-10-23), so it becomes a manual entry with its run command, as #30624 and #30872 did. The test passes (about 2 s). Red at 9dee26d: python3 scripts/ci/validate_test_execution_registry.py --pr-lanes feat-cmux-next --base-sha HEAD exit 1 Green here: same command, exit 0.
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
lawrencecchen
temporarily deployed
to
ci-routing-agent
November 1, 2026 15:27 — with
GitHub Actions
Inactive
Contributor
Author
|
Review (subagent, correctness first): SHIP at 4d368eb What the reviewer confirmed:
Note: the car guards no longer pick this test, because they run only linux-guard tests. This is now stated in the description. |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tooling-testsis red on every feat-cmux-next PR (seen on #31013). The registry check fails with:#30878 registered this test as
linux-guardbut added noci-guards.ymlstep that runs it. CLAUDE.md does not allow new CI tests (Lawrence 2026-10-23). So the test becomeslane = "manual", with the command to run it, as #30624 and #30872 did for earlier tests.Side effect: the nightly-next car guards (
car_guards.py,focused_tests.py) run onlylinux-guardtests. Before this PR they could pick this test when a car changed a workflow it names. As amanualtest it is not run there. The only way to keep it in that lane is a new CI step, which CLAUDE.md does not allow. #30624 and #30872 had the same effect.Red and green
python3 scripts/ci/validate_test_execution_registry.py --pr-lanes feat-cmux-next --base-sha HEAD: exit 1 at the feat tip, exit 0 at this head (601 tests).test_ci_test_execution_registry.pyandtest_pr_lane_coverage.py: OK.Observed / Not run
Changelog
none