Skip to content

base red: tooling-tests registry, three tests from #30648 and #30657 become manual - #30872

Merged
lawrencecchen merged 1 commit into
feat-cmux-nextfrom
fix/base-red-registry-1101c
Nov 1, 2026
Merged

lawrencecchen merged 1 commit into
feat-cmux-nextfrom
fix/base-red-registry-1101c

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

tooling-tests is red on every feat-cmux-next PR (seen on #30824). The registry check fails with:

tests/test_ci_fast_checks_runner.py: linux-guard lane is not run by any workflow      (#30648)
tests/test_nightly_next_control_rescue.py: linux-guard lane is not run by any workflow (#30657)
tests/test_nightly_next_control_runner.py: linux-guard lane is not run by any workflow (#30657)

Those PRs registered each test as linux-guard but added no ci-guards.yml step that runs it. CLAUDE.md does not allow new CI tests (Lawrence 2026-10-23). So each test becomes lane = "manual", with the command to run it, the same fix #30624 made for test_ci_blacksmith_linux_sizes.py.

Red and green

  • python3 scripts/ci/validate_test_execution_registry.py --pr-lanes feat-cmux-next --base-sha HEAD: exit 1 at the feat tip, exit 0 at this head (599 tests).
  • test_ci_test_execution_registry.py and test_pr_lane_coverage.py: OK.

Observed / Not run

  • Observed: the commands above, plus each of the 3 tests (all pass, about 1 s each).
  • Not run: nothing else is needed; this PR changes only the registry.

Changelog

none


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes tooling-tests being red on every feat-cmux-next PR. Three tests from #30648 and #30657 were registered as linux-guard but no ci-guards.yml step runs them; since no new CI tests are allowed (Lawrence 2026-10-23), each becomes manual with its run command, as #30624 did for test_ci_blacksmith_linux_sizes.py.

With this change, python3 scripts/ci/validate_test_execution_registry.py --pr-lanes feat-cmux-next --base-sha HEAD exits 0 at this head (599 tests).

Written for commit cf237d2. Summary will update on new commits.

View guided diff Turn on auto-fix

…linux-guard become manual

validate_test_execution_registry.py --pr-lanes feat-cmux-next failed on every
pull request:
  tests/test_ci_fast_checks_runner.py: linux-guard lane is not run by any workflow (#30648, ecc5d60)
  tests/test_nightly_next_control_rescue.py: same (#30657, e5d30ae)
  tests/test_nightly_next_control_runner.py: same (#30657)
No ci-guards.yml step runs them, and CLAUDE.md forbids new CI tests (Lawrence
2026-10-23), so each becomes a manual entry with its run command, as #30624 did
for test_ci_blacksmith_linux_sizes.py. All three pass (about 1 s each).

Red at 710d274: python3 scripts/ci/validate_test_execution_registry.py --pr-lanes feat-cmux-next --base-sha HEAD   exit 1
Green here: same command, exit 0 (599 tests, manual=36).
@lawrencecchen lawrencecchen added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 1, 2026
@lawrencecchen lawrencecchen added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review cf237d2: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr30872 -f ref=fix/base-red-registry-1101c -f platform=macos -f backend_mode=local

Shipped in:

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

You’re at about 91% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

View guided diff | Turn on auto-fix | Re-trigger cubic

@blacksmith-sh

blacksmith-sh Bot commented Nov 1, 2026

Copy link
Copy Markdown

Found 6 test failures on Blacksmith runners:

Failures

Test View Logs
/tmp/tmp8vvbp9i3/summary-fail.json (live):/summary-fail.json (live): View Logs
/tmp/tmpu4cpfl9c/summary-missing.json (live):/summary-missing.json (live): View Logs
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows/
[new_workspaces] debug.new_workspace timed 0 of 50 new workspace rows
View Logs
[new_workspaces] the window draws no frames/[new_workspaces] the window draws no frames View Logs
[tabs] debug.tab_switch timed 0 of 40 switches/
[tabs] debug.tab_switch timed 0 of 40 switches
View Logs
[tabs] the window draws no frames/[tabs] the window draws no frames View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Review (subagent, correctness first): SHIP at cf237d2

The reviewer checked these points:

  • At origin/feat-cmux-next 1b95d04, the validator fails on exactly these three entries.
  • No workflow runs the three files.
  • At this head, the validator exits 0 (599 tests), and both registry tests pass.
  • All three tests pass when run.

Nit, not fixed here: the "after changing" hints name nightly.yml and fast-checks.yml, but those workflows do not call these scripts yet.

@lawrencecchen lawrencecchen added the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Nov 1, 2026
@lawrencecchen
lawrencecchen merged commit 1a73d0c into feat-cmux-next Nov 1, 2026
216 of 244 checks passed
@lawrencecchen
lawrencecchen deleted the fix/base-red-registry-1101c branch November 1, 2026 12:29
lawrencecchen added a commit that referenced this pull request Nov 1, 2026
… registered as linux-guard becomes manual (#31065)

validate_test_execution_registry.py --pr-lanes feat-cmux-next failed on every pull request
(seen on #31013):
  tests/test_ci_overflow_pick_reads_pool.py: linux-guard lane is not run by any workflow
#30878 (da249ca) registered it as linux-guard and added no ci-guards.yml step. CLAUDE.md
forbids new CI tests (Lawrence 2026-10-23), so it becomes a manual entry with its run
command, as #30624 and #30872 did. The test passes (about 2 s).

Red at 9dee26d: python3 scripts/ci/validate_test_execution_registry.py --pr-lanes feat-cmux-next --base-sha HEAD   exit 1
Green here: same command, exit 0.

This branch was previously deployed

1 inactive deployment
ci-routing-agent — cf237d2f Deployed Nov 1, 2026 by lawrencecchen via wait for same-key tree publisher #96077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant