Repository navigation
ci: enforce absolute fast-check request deadlines - #30822
Merged
teamleaderleo merged 1 commit intoNov 1, 2026
Merged
Conversation
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 1, 2026 11:23 — with
GitHub Actions
Inactive
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base bbb608c; does not block Shipped in:
|
This was referenced Nov 1, 2026
teamleaderleo
added a commit
that referenced
this pull request
Nov 4, 2026
…#34428) Run 41718897738's admit step spent 182 s polling for an idle fleet runner (helper ecc5d60, #30648). 159a701 (#34270) decides on one census read: an online fleet runner keeps the fleet label (the lane-gh broker bounds a checks job left queued there at 180 s), none overflows at once. The pin also carries #30762, #30822, #31896 and #33652, each already reviewed and merged on feat-cmux-next. Agent-Session: https://cmux.com/deeplink/agent?id=aid-342ae944382c55b76f4c Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fast-checks runtime’s 180-second census bound now covers the complete HTTP operation, including response bodies and signed artifact downloads. Socket inactivity timeouts alone let a peer that drips bytes keep
response.read()alive indefinitely. A scoped process alarm interrupts open, TLS, headers and body reads at the monotonic deadline, restores any prior alarm, and leaves clients without a deadline unchanged. No worker threads are created for timeout enforcement.This is the fix-forward for the blocking audit of #30762 and keeps its strict
ROUTE_TOKENand separateSNAPSHOT_TOKENbehavior. It also covers the sharedpr_runner_pool.GitHubclient used by the approved runtime. #30724 overlaps only in the same client file for unrelated cmux-tui selector guards; this branch does not alter those selectors.Observed / Not run
At
540050e3d9d2ee24da18184a497d06bec272f974, the fast-checks picker suite passes 13/13, including local HTTP drip-server regressions for API JSON and signed artifact bodies; both server and handler threads are stopped and joined. Fulltests.test_ci_pr_runner_poolpassed 243 tests before this final test-only addition;py_compileandgit diff --checkpass. The focused suite was run again at the final head.Review audit: #30762 (merged
265c68a569ac4af557bdd5ad2e4b26365a453503); this change addresses the audit finding that socket timeouts did not establish an absolute body-read deadline.Changelog
none
Agent session: agent session
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Enforces absolute wall-clock deadlines on fast-checks GitHub API and artifact download requests so a peer dripping bytes can no longer keep
response.read()alive past the 180-second census bound.SIGALRMprocess alarm covering connect, TLS, headers, and body reads; restores any prior alarm and timer on exit.Written for commit 540050e. Summary will update on new commits.