Skip to content

Revert "Cloud: every signed NEXT build (DEV and nightly) defaults to NEXT Cloud via the app-server link" - #30405

Merged
lawrencecchen merged 1 commit into
feat-cmux-nextfrom
revert/pr-28899
Nov 1, 2026
Merged

lawrencecchen merged 1 commit into
feat-cmux-nextfrom
revert/pr-28899

Conversation

@lawrencecchen

@lawrencecchen lawrencecchen commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Reverts #28899 (dc8a4a4), opened by gh-merge-green --revert.

Changelog

Changed: reverts #28899 (- Changed: signed cmux NEXT DEV and NEXT nightly use NEXT Cloud (the development Worker and app-server link) by default. Agent session: agent session 🤖 Generated with Claude Code)


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Reverts #28899, restoring the previous behavior where signed NEXT DEV and nightly builds use production Cloud instead of defaulting to NEXT Cloud.

  • Signed NEXT builds return to production endpoints, production auth, and their standard Keychain and UserDefaults storage.
  • The app-server link and staging sign-in are now used only by Debug builds with explicit environment overrides.
  • Machine actions (kill, pause, resume, resize, rename, idle pause, snapshots, restore) go back through /api/vm instead of app server ops.
  • Removed the signed-DEV configuration and auth-persistence tests added with the original change.

Written for commit 12df5f6. Summary will update on new commits.

View guided diff Turn on auto-fix

Takes back #28899: CmuxNextApp +94 lines turned the feat tip arch ratchet red (6be2728); re-land with the code moved to a package.

…NEXT Cloud via the app-server link" (#28899)

This reverts commit dc8a4a4.
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 12df5f6: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr30405 -f ref=revert/pr-28899 -f platform=macos -f backend_mode=local

red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 8a137da; does not block

Default changes

This pull request changes 1 default at 12df5f665569 (what everyone gets without configuring anything):

  • tunable-source.CmuxNextApp/Handlers/CloudGitHubHandlers.swift:bind: "cbf6a234bb57fc4c4d00531376bf1ed462b1e86e72c97d0b801043f472a0de21" -> "9310ac496c3ad803630ec95d53217e75c0272d6729f5a2d388cd842f7bf7503c"

Signed off on this commit by review (subagent, correctness first).

Merge receipt: merged as 9aa898c5357b with these defaults changed, signed off by review (subagent, correctness first).

Regenerate the snapshot with python3 scripts/ci/defaults_guard.py snapshot.

Shipped in:

@lawrencecchen

Copy link
Copy Markdown
Contributor Author

Review (subagent, correctness first): SHIP at 12df5f6

@lawrencecchen lawrencecchen added the ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds label Nov 1, 2026
@blacksmith-sh

blacksmith-sh Bot commented Nov 1, 2026

Copy link
Copy Markdown

Found 4 test failures on Blacksmith runners:

Failures

Test View Logs
nightly must build and hand off the macOS 26 helper and Xcode 26.5 app before publishin
g/
nightly must build and hand off the macOS 26 helper and Xcode 26.5 app before publishin
g
View Logs
test_helper_never_takes_a_hosted_mac_and_skips_compile_on_hit (main.WorkflowTests.t
est_helper_never_takes_a_hosted_mac_and_skips_compile_on_hit)/
test_helper_never_takes_a_hosted_mac_and_skips_compile_on_hit (main.WorkflowTests.t
est_helper_never_takes_a_hosted_mac_and_skips_compile_on_hit)
View Logs
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)/
test_the_repository_highlights_validate (main.DigestTests.test_the_repository_highl
ights_validate)
View Logs
test_under_githubs_limit_with_headroom (main.NightlyWorkflowSize.test_under_githubs
_limit_with_headroom)/
test_under_githubs_limit_with_headroom (main.NightlyWorkflowSize.test_under_githubs
_limit_with_headroom)
View Logs

Fix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@lawrencecchen
lawrencecchen merged commit 9aa898c into feat-cmux-next Nov 1, 2026
204 of 234 checks passed
@lawrencecchen
lawrencecchen deleted the revert/pr-28899 branch November 1, 2026 09:25

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 12df5f66 Deployed Nov 1, 2026 by lawrencecchen via wait for same-key tree publisher #94573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-land Reviewed at this head; next-autoland merges it into feat-cmux-next when its only reds are base reds risk:normal Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant