Repository navigation
cmux NEXT: scale chat text with font-size shortcuts - #26628
Conversation
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Not verified: macOS jobs did not run: compile and app tests were skipped on CI passes on Written by red: cmux-next checks (god files, concurrency, crash safety, l10n); base red: the same failure on the base 921c778; does not block Default changesThis pull request changes 9 defaults at
Signed off on this commit by Merge receipt: merged as Regenerate the snapshot with Shipped in:
|
|
Bead |
This comment has been minimized.
This comment has been minimized.
|
Review (codex gpt-6-astra high, next-review): SHIP at 964e1ae No blocking findings.
Review limited to supplied files; repository lookups were denied by the approval policy. Tests were not run. |
|
Owned by an agent session · session |
…t-shortcuts-adopt-1028
|
take it (drain-acpmux helper: a lane pushed 48e2ee8 and aeab59d after this claim, so the PR goes back to that lane. Done before the handback: merged feat-cmux-next at 903b7a7, router-review SHIP at 903b7a7 (#26628 (comment)), and before/after light/dark screenshots added to the body. The new head aeab59d now conflicts with feat-cmux-next and needs its own review; the defaults guard failed at it.) |
|
Review (codex, router-review): SHIP at 3d1a535 Reviewer: codex gpt-6-astra high, fast tier. Follow-ups: 1. Each lands as an issue in this repo that links this receipt; the lane that opened the PR fixes it forward. SHIP at 3d1a535 Visual verdict: no images; Leo tries the build.
Follow-ups:
|
Regenerated web/data/next-docs/palette-reference.generated.json with bun web/scripts/export-next-docs.ts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-fc739fd2f4e557ae7189
Regenerated web/data/next-docs/palette-reference.generated.json with bun web/scripts/export-next-docs.ts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-fc739fd2f4e557ae7189
Regenerated web/data/next-docs/palette-reference.generated.json with bun web/scripts/export-next-docs.ts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-fc739fd2f4e557ae7189
|
Reverted by #30432. This PR added +67 lines to How to re-land:
|
Lawrence via Leo: “leo make sure font size everywhere (like text input area) is customizable”.
In a focused Agent Chat, Cmd +/−/0 now changes Settings > Appearance > Chat Font Size, the same setting the composer and transcript use in #26577. The existing workspace font-size action still changes Ghostty terminals when a terminal is focused. Agent Chat page zoom remains available through its View menu, palette, and CLI actions. Repeated presses are serialized per app instance, so rapid Cmd + presses each count.
The app test covers terminal isolation, chat increase/decrease/reset, a rapid two-press sequence, and the 28-point setting limit. The shortcut test checks that Home, chat, and terminal resolve to their proper actions. This is the native companion to #26577.
Validation at
aeab59d02e1ec29188f98b8671d0440074e7f051:feat-cmux-nextatea29e41bc6d35be421f8b99ad23213055d8aeee1; generated palette/CLI/shortcut references are current. The 102 removed shortcut-doc lines are the three page-zoom shortcuts removed from the catalog.8bfd12f63b17d3dbb85b3071covers AgentChatFontSizeShortcutTests, HomeZoomKeyTests and KeybindingsFocusConflictTests. Base gate162b718512cd96977d81872dcovers the existing shortcut suites atea29e41bc6d35be421f8b99ad23213055d8aeee1. Pending; no passing result claimed yet. The older base gate ata8615fdapassed both existing suites.git diff --checkpasses.Documentation follow-up: #29016, from the earlier exact-head review, corrects the stale Agent Chat Zoom reset-shortcut help.
Agent session: agent session