Repository navigation
ci: validate structured runner pool labels - #30164
Merged
Merged
Conversation
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
Collaborator
Author
|
Review (subagent, gpt-6-astra): SHIP at 1359211. Arrays/objects fail closed; macOS and ARM64 remain rejected; approved Blacksmith labels and _dead metadata pass. No workflow or trust-setting changes. |
|
Found 33 test failures on Blacksmith runners: Failures
...and 23 more test failures. View all on Blacksmith: run 41274341617, run 41274341461
|
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 1, 2026 05:03 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light-3x.png)
This is a narrow fix-forward for the base-red policy regression exposed by #30081. The nightly hosted-Mac guard reads
RUNNER_POOLSfromruns-onexpressions, but the runner-label policy treated that JSON object as an unvalidated non-label variable.RUNNER_POOLSis now parsed as pool metadata:_deadtimestamps are ignored, while every pool member is checked for hosted macOS labels and self-hosted fleet labels. Empty configuration remains allowed, trusted Blacksmith Linux/macOS pool members remain allowed, malformed non-empty JSON fails closed, and no blanket exemption was added.Leo’s routing rule is that paid runners are bounded overflow and hosted Macs are not part of the route. This keeps the policy test aligned with that rule without changing workflow permissions or runner trust.
Validation:
python3 tests/test_ci_nightly_no_hosted_mac.py— 5 passedgit diff --check— passedtests/test_runner_label_policy.pystill reports the pre-existingCI_CONTROL_RUNNERreport-list drift on this base; the new structured-pool tests pass.Agent session: agent session
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the base-red policy regression from #30081 by validating
RUNNER_POOLSas structured JSON pool metadata in the nightly runner-label policy. Previously the JSON object was treated as an unvalidated non-label variable, letting hosted Macs slip through pool definitions._deadmetadata timestamps are ignored; every other pool label is checked for hosted macOS and self-hosted fleet labels. Empty configuration and trusted Blacksmith Linux/macOS pools remain allowed. Malformed JSON, non-object values, and non-string labels all fail closed. No blanket exemption was added; workflow permissions and runner trust are unchanged.Written for commit 1359211. Summary will update on new commits.